30969 Commits

Author SHA1 Message Date
Dominik Schilling (ocean90)
09dccfb925 Passwords: Deprecate second parameter of wp_new_user_notification().
The second parameter `$plaintext_pass` was removed in [33023] and restored as `$notify` in [33620] with a different behavior. If you have a plugin overriding `wp_new_user_notification()` which hasn't been updated you would get a notification with your username and the password "both".
To prevent this the second parameter is now deprecated and reintroduced as the third parameter.

Adds unit tests.

Merge of [34116] to the 4.3 branch.

Props kraftbj, adamsilverstein, welcher, ocean90.
See #33654.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@34118 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-14 13:02:03 +00:00
Helen Hou-Sandi
15214a8873 Comments: Fix inline edit/reply on small screens.
Merges [34094] to the 4.3 branch.

props ocean90, SergeyBiryukov.
see #33596.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@34095 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-13 12:53:14 +00:00
Dominik Schilling (ocean90)
2a6dea74c6 Passwords: Refresh password fields when content is pasted into fields.
Use feature detection to determine whether password inputs should use the `keyup` or `input` event.

Merge of [34060] to the 4.3 branch.

Props peterwilsoncc, adamsilverstein.
Fixes #33398.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@34078 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-12 12:29:54 +00:00
Andrew Ozz
7bc13a7465 Settings: reassign the label when switching password fields so it always highlights the visible field.
Props umesh.nevase.
Fixes #33778 4.3.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@34063 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-11 23:22:30 +00:00
Jeremy Felt
fb4900397f Multisite: Display content attribution drop down when deleting a user
The previous move from echo() to _e() left some of the output hanging. Introduced in [32333].

Merge of [34057] to the 4.3 branch.

Props figureone.
Fixes #33811.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@34058 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-11 20:48:47 +00:00
Dominik Schilling (ocean90)
2b9cb82a72 Site Icon: For preview fall back to full size URL when thumbnail size doesn't exist.
Prevents a JavaScript error for rare cases when cropping is skipped and the image is smaller than `thumbnail`.

Merge of [34056] to the 4.3 branch.

Props tyxla.
See #33417.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@34057 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-11 20:15:41 +00:00
Dominik Schilling (ocean90)
29e7774fb0 About: Remove period from placeholder.
The position of periods is different in some languages, like Japanese. This removes the period from the last placeholder for the Template Hierarchy section. It doesn't include a new period to avoid a string change in a minor release.

Merge of [34054] to the 4.3 branch.

Props extendwings, chriscct7.
See #33429.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@34055 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-11 19:27:08 +00:00
Dominik Schilling (ocean90)
c0da1ceb87 Users: Import the global var $wp_hasher in wp_new_user_notification().
Adds `@global` entries to the DocBlock.

Merge of [34052] to the 4.3 branch.

See #33826.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@34053 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-11 19:17:52 +00:00
Andrew Ozz
7e3d8f4645 TinyMCE: ensure the wordpress plugin is loaded before calling _createToolbar().
Props hauvong, azaozz.
Fixes #33393 for 4.3.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@34032 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-11 01:46:17 +00:00
Boone Gorges
2d22aabae7 Move wp_delete_user() tests to their own file.
See #33800.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@34031 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-11 01:39:52 +00:00
Andrew Ozz
dcb9873834 TinyMCE: update to 4.2.5, changelog: http://www.tinymce.com/develop/changelog/?ctrl=version&act=index&pr_id=1.
Fixes #33782 for 4.3.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@34029 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 23:56:25 +00:00
Andrew Ozz
3a7c781c87 Formatting: fix removing line break placeholders from HTML comments at the end of wpautop().
Props miqrogroove.
Fixes #33645 for 4.3.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@34024 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 22:22:41 +00:00
Gary Pendergast
cf5fc77f6e WPDB: get_table_from_query() didn't find table names with hyphens in them.
Merge of [33718] to the 4.3 branch.

Props dustinbolton, pento.

See #33470.



git-svn-id: https://develop.svn.wordpress.org/branches/4.3@33991 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 06:54:13 +00:00
Sergey Biryukov
b12dc9f330 Prevent unintended password change after clicking "Generate Password" and then "Cancel" when editing a user profile.
Merges [33766] to the 4.3 branch.

Props peterwilsoncc.
Fixes #33419 for 4.3.1.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@33980 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 17:31:40 +00:00
Boone Gorges
225d5ed8cf Pass the $public_only value to 'get_usernumposts' filter.
[32523] introduced the $public_only parameter to `count_user_posts()`. That
changeset was supposed to pass `$public_only` to the 'get_usernumposts' filter
at the end of the function, but only the documentation was modified, not the
filter itself.

This changeset also fixes an incorrect variable name in the docblock for
the same filter, and includes clarification on the accepted values for
the `$post_type` parameter.

Merges [33710] and [33716] to the 4.3 branch.

Props swisspidy, tmatsuur, tyxla, DrewAPicture.
Fixes #33481 for 4.3.1. 


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@33953 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-08 20:57:31 +00:00
Scott Taylor
6e9d02a430 When creating "Sample Page" on install, comments should be closed.
Props macmanx. 
Cherry-picks [33693] onto 4.3 branch.
Fixes #33490 for 4.3.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@33950 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-08 19:04:05 +00:00
Boone Gorges
404942c442 In Walker_CategoryDropdown::start_el(), cast values to strings before deciding whether to append 'selected' attribute.
As of [32484], `wp_dropdown_categories()` uses the `$value_field` value to
decide whether a given `<option>` should be 'selected'. However, `$value_field`
can refer to a value that is a string, such as a category's slug. This causes
problems when doing a loose comparison (`==`) with the value of the 'selected'
parameter, which defaults to `0`, because when doing a loose comparison
between an integer and a string, PHP will cast the string to an integer. This
creates false matches, resulting in `<option>` elements getting a 'selected'
attribute incorrectly.

We address the issue by casting the comparison values to strings, and then
using the strict comparison operator `===`.

Merges [33681] to the 4.3 branch.

Fixes #33452 for 4.3.1.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@33949 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-08 19:03:17 +00:00
Weston Ruter
8eb9b09fd5 Customizer: Prevent JS error during init when nav_menus panel is removed by plugin.
Cherry-picks [33753] onto 4.3 branch.
Fixes #33411 for 4.3.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@33943 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-07 06:27:11 +00:00
Weston Ruter
819c244a96 Customizer: Collapse any expanded panel/sections before expanding other panel/sections.
Fix removes need for workaround introduced in [33488] for direct link from nav menu widget to the customizer widgets panel. The todo is now implemented.

Cherry-picks [33837] onto 4.3 branch.
Props celloexpressions, westonruter.
Fixes #33396 for 4.3.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@33942 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-07 06:19:35 +00:00
Weston Ruter
2087b5e14d Customizer: Ensure persistence of unchanged active state for controls, sections, and panels.
Cherry-picks [33754] onto 4.3 branch.
Props nikeo, westonruter.
Fixes #33428 for 4.3.
See also #33494.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@33941 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-07 06:13:17 +00:00
Weston Ruter
e6b8284fce Customize: Fix logic for determining the container element when focusing on a panel, section, or control.
Cherry-picks [33939] on the 4.3 branch.
Fixes #33695 for 4.3


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@33940 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-07 06:04:39 +00:00
Dion Hulse
52f5b355a9 WP_Filesystem: SSH2 handler: Remove support for is_writable() via SSH, it turns out PHP doesn't verify the writability via SFTP and instead uses a comparison based on the current php system process user instead of the ssh user.
This fixes the 'The update cannot be installed because we will be unable to copy some files.' error encountered during updates by skipping the write test completely.

Merges [33688] to the 4.3 branch.
Props jobst.
Fixes #33480 for 4.3


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@33883 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 04:05:45 +00:00
Dion Hulse
917536de43 Term Splitting: Switch to a faster cron unschedule process to benefit sites with thousands of affected jobs. Fix the cron hook name in the failsafe rescheduler.
Merges [33727] to the 4.3 branch
Props Otto42, dd32, peterwilsoncc
Fixes #33423 for trunk


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@33877 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 03:30:26 +00:00
Weston Ruter
a27f0e8d53 Widgets: Switch back to using array_key_exists() instead of isset() for widget instance existence check.
Reverts unnecessary change in [32602] since `array_key_exists()` does actually work with `ArrayIterator` objects.

Merges [33696] to the 4.3 branch.
See #32474.
Fixes #33442 for the 4.3 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@33721 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-24 19:30:37 +00:00
Dion Hulse
8c5901f148 The 4.3 branch is now 4.3.1-alpha.
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@33649 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-19 13:19:01 +00:00
Dion Hulse
09ea2689f1 Term Splitting: Fix a reversal of parameters to wp_schedule_single_event() introduced in [33621].
The existing invalid cron entries will not be purged automatically (as the 'timestamp' is never matched) so we do this ourselves.

Merges [33646] to the 4.3 branch.
Props mechter for noticing!
See #30261.
Fixes #33423 for the 4.3 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@33647 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-19 11:36:06 +00:00
Helen Hou-Sandi
0a201ff931 Branch 4.3.
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@33634 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-18 18:11:31 +00:00
Konstantin Obenland
08a58ff927 WordPress 4.3
git-svn-id: https://develop.svn.wordpress.org/trunk@33633 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-18 18:01:25 +00:00
Konstantin Obenland
6367a427f4 About: Use actual locale and not subtitle debug cruft.
H/t dimadin.

See #32929.


git-svn-id: https://develop.svn.wordpress.org/trunk@33632 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-18 17:06:37 +00:00
Konstantin Obenland
03bc4e6299 About: Update release video to use the correct ID.
Also adjusts locale handling to work with Videopress' subtitle implementation.

Props siobhan, jacklenox, sararosso, hugobaeta, nickmomrik, rauchg.
See #32929.



git-svn-id: https://develop.svn.wordpress.org/trunk@33631 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-18 17:01:50 +00:00
Boone Gorges
48beba441b When generating a fallback post_name using the post ID, wp_insert_post() should clear the post cache immediately.
If the post cache is not cleared at this point, the cache can become stale
for operations performed before the cache is cleared later in the function.
Specifically, the generation of a `guid` for new posts can use stale data,
resulting in non-unique values. [33262] introduced a call to `get_post()`
that introduced just such an invalidation problem.

Fixes #5305.

git-svn-id: https://develop.svn.wordpress.org/trunk@33630 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-18 02:50:23 +00:00
Konstantin Obenland
8f23b0db45 4.3-RC3-33629
git-svn-id: https://develop.svn.wordpress.org/trunk@33629 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-17 21:45:42 +00:00
Konstantin Obenland
c992631099 4.3-RC3
git-svn-id: https://develop.svn.wordpress.org/trunk@33628 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-17 21:39:05 +00:00
Dominik Schilling (ocean90)
0ec540b946 Pinking shears.
git-svn-id: https://develop.svn.wordpress.org/trunk@33627 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-17 21:38:24 +00:00
Dominik Schilling (ocean90)
f545d74256 Upgrade: Update $_old_files for 4.3.
fixes #33394.

git-svn-id: https://develop.svn.wordpress.org/trunk@33626 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-17 20:23:06 +00:00
Konstantin Obenland
e7c16b2d0a Passwords: Use keyup event to prevent IE8's misinterpretation of propertychange.
Props adamsilverstein, peterwilsoncc.
Fixes #33385.



git-svn-id: https://develop.svn.wordpress.org/trunk@33625 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-17 18:45:33 +00:00
Andrew Ozz
b30fcd7597 Fix creating of extra <br /> tags in both PHP and JS variants of wpautop(). Add PHP tests to catch similar problems in the future.
Props valendesigns, azaozz. Fixes #33377.

git-svn-id: https://develop.svn.wordpress.org/trunk@33624 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-17 17:35:58 +00:00
Helen Hou-Sandi
3b1e1f0376 List tables: Yet more primary column fallbacks.
Some custom list tables override enough methods for the column definition fallback to never kick in, so let's ensure that toggling columns only applies when a primary column is defined in some way. We also need to show a toggle button when we can when there are no row actions.

props Chouby, obenland, ocean90.
fixes #33313.


git-svn-id: https://develop.svn.wordpress.org/trunk@33623 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-17 15:37:03 +00:00
Konstantin Obenland
eea1678cd3 Editor: Exclude shift from modifier keys when handling spacebar shortcuts.
Patterns that activate on enter are still canceled with any modifier active.

Props azaozz.
Fixes #33382.



git-svn-id: https://develop.svn.wordpress.org/trunk@33622 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-17 14:50:42 +00:00
Boone Gorges
e33ff607e6 Don't run term-splitting routine on new installations.
Props pento.
Fixes #30261.

git-svn-id: https://develop.svn.wordpress.org/trunk@33621 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-17 14:28:03 +00:00
Konstantin Obenland
e7a203cdf2 Passwords: Restore second parameter for wp_new_user_notification().
After [33023] users would always be notified, this restores previous behavior.

Props markjaquith, ocean90.
Fixes #33358.



git-svn-id: https://develop.svn.wordpress.org/trunk@33620 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-17 14:24:43 +00:00
Boone Gorges
9c70cea98f Don't suspend cache invalidation when running term splitting batch routine.
`wp_suspend_cache_invalidation()` was originally added to increase performance,
but the switch to batch processing in [33615] mitigates serious performance
concerns.

As a precaution against timeouts, the batch size has been reduced from 20 to 10.

Props Chouby.
See #30261.

git-svn-id: https://develop.svn.wordpress.org/trunk@33619 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-15 19:24:42 +00:00
Helen Hou-Sandi
7abf08a52c Menu customizer: Ensure the search results section is full height.
fixes #33375.


git-svn-id: https://develop.svn.wordpress.org/trunk@33618 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-14 21:31:23 +00:00
Weston Ruter
a4bbc4454c Customize: Fix keyboard accessibility for toggling screen options and contextual help.
Also fix layout of search results in mobile.

Props valendesigns, afercia, adamsilverstein.
Fixes #33184.


git-svn-id: https://develop.svn.wordpress.org/trunk@33617 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-14 21:22:57 +00:00
Boone Gorges
6d5da327f5 Remove unit test related to pre-4.1 term splitting during wp_update_term().
After [33615], `wp_update_term()` no longer checks `$wp_db_version` before
attempting a split. This is because pre-4.1 versions of WordPress must be
allowed to update to 4.3+.

See #30261.

git-svn-id: https://develop.svn.wordpress.org/trunk@33616 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-14 04:15:34 +00:00
Boone Gorges
f18355e66e Term splitting routine should be run in a separate process, triggered via wp-cron.
[32814] introduced a routine to split shared terms, which was run during the
regular WP database upgrade. This turned out to be problematic because plugins
are not loaded during the db upgrade (due to `WP_INSTALLING`), with the result
that plugins were not able to hook into the 'split_shared_term' action during
the bulk split. We work around this limitation by moving the term splitting
routine to a separate process, triggered by a wp-cron hook.

Props boonebgorges, Chouby, peterwilsoncc, pento, dd32.
Fixes #30261.

git-svn-id: https://develop.svn.wordpress.org/trunk@33615 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-14 03:58:41 +00:00
Dominik Schilling (ocean90)
23eaa36145 Capabilities: Fall back to the edit_posts capability for orphaned comments.
Also avoid PHP notices because of orphaned comments in the comments list table.
Includes unit test.

props pento, dd32.
fixes #33154.

git-svn-id: https://develop.svn.wordpress.org/trunk@33614 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-13 22:30:26 +00:00
Konstantin Obenland
ce531d8723 About: Third pass at 4.3 about page:
* Improves some of the feature descriptions.
* Uses .org CDN for images and feature video.
* Fixes an overzealous Jetpack style that adds unwanted padding.
* Uses more specific `WP_List_Table` header.
* Adds 4.3 tagline to freedoms and credit page.
* Adds infrastructure for 4.3 about video. Only the ID needs to be updated.
* Makes all strings translatable.

Props siobhan, adamsilverstein, melchoyce, ocean90, markjaquith, helen, obenland.
Fixes #32929.



git-svn-id: https://develop.svn.wordpress.org/trunk@33613 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-13 22:10:06 +00:00
Scott Taylor
df480edb24 After [33325], supply a missing post_type in ->mw_editPost().
Add unit test.

Props ocean90.
Fixes #20662.


git-svn-id: https://develop.svn.wordpress.org/trunk@33612 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-13 15:27:57 +00:00
Boone Gorges
ee67bd08f9 When splitting a shared 'nav_menu' term, ensure that nav items and theme locations are retained.
Props boonebgorges, dd32.
Fixes #33187.

git-svn-id: https://develop.svn.wordpress.org/trunk@33611 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-12 14:06:21 +00:00