43041 Commits

Author SHA1 Message Date
Sergey Biryukov
f2302a3112 Build/Test Tools: Check if all the required PHP extensions are loaded before running the test suite.
Add the GD extension as a hard requirement.

This improves the reliability of the test suite and ensures that if the test infrastructure changes in the future and a platform requirement such as GD accidentally gets removed, the tests fail with an appropriate error message.

Follow-up to [48592].

Props ayeshrajans, jrf, johnbillion.
Fixes #50640.

git-svn-id: https://develop.svn.wordpress.org/trunk@49535 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-07 13:18:24 +00:00
Timothy Jacobs
a104c26283 App Passwords: Bump database version to flush rewrite rules.
Application Passwords introduced a new Rewrite Rule to handle the Authorization header on certain systems. This bumps the database version so the change is applied to sites upon upgrading to 5.6.

Fixes #51723.


git-svn-id: https://develop.svn.wordpress.org/trunk@49534 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-06 22:13:41 +00:00
Sergey Biryukov
da1763cf5b Docs: Add a @see reference to esc_url() from esc_url_raw().
Follow-up to [49512].

See #50585.

git-svn-id: https://develop.svn.wordpress.org/trunk@49513 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-06 14:14:50 +00:00
Sergey Biryukov
73d785a307 Docs: Improve return value description for esc_url().
Add a reference to `esc_url()` from `esc_url_raw()` return value description.

Props stevenlinx, audrasjb, helen.
Fixes #50585.

git-svn-id: https://develop.svn.wordpress.org/trunk@49512 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-06 14:01:06 +00:00
Sergey Biryukov
c95968a640 Bundled Themes: Correct list block alignment in editor styles.
Additionally:
* Indent nested lists in list and category blocks.
* Match ordered and unordered indentation for the classic block's lists.

This applies to:
* Twenty Ten
* Twenty Eleven
* Twenty Thirteen
* Twenty Fourteen
* Twenty Fifteen
* Twenty Sixteen
* Twenty Seventeen

Props sabernhardt, amolv, kjellr, audrasjb, francina.
Fixes #51157.

git-svn-id: https://develop.svn.wordpress.org/trunk@49511 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-06 11:51:12 +00:00
Sergey Biryukov
1e06d3511d Twenty Twenty: Correctly indent nested unordered lists in RTL editor styles.
Props sabernhardt.
Fixes #51574.

git-svn-id: https://develop.svn.wordpress.org/trunk@49510 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-06 11:36:14 +00:00
Sergey Biryukov
b4a488b650 Docs: Fix typo in a comment in Walker::display_element().
Props david.binda, sabernhardt.
Fixes #51713.

git-svn-id: https://develop.svn.wordpress.org/trunk@49509 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-05 18:44:48 +00:00
Sergey Biryukov
31af0afd4f Twenty Thirteen: Correct alignment of blocks inside a full-width or wide-width group block.
Props sabernhardt.
Fixes #51440.

git-svn-id: https://develop.svn.wordpress.org/trunk@49508 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-05 15:03:41 +00:00
Sergey Biryukov
691408de7f Twenty Twenty: Correct heading blocks alignment in editor styles.
This explicitly sets top and bottom margins instead of defining all four sides in shorthand notation.

Props sabernhardt, Lumne.
Fixes #51148.

git-svn-id: https://develop.svn.wordpress.org/trunk@49507 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-05 15:00:18 +00:00
Sergey Biryukov
33111495b2 Docs: Improve documentation for WP_Query::is_archive() per the documentation standards.
Follow-up to [49504].

See #50545.

git-svn-id: https://develop.svn.wordpress.org/trunk@49506 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-05 09:42:49 +00:00
Sergey Biryukov
e38410c2fd Docs: Consistently place @see tags after @since in WP_Query methods, per the documentation standards.
See #50768.

git-svn-id: https://develop.svn.wordpress.org/trunk@49505 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-05 09:40:38 +00:00
Helen Hou-Sandi
7a16c4d580 Improve documentation for is_archive().
Props stevenlinx.
Fixes #50545.


git-svn-id: https://develop.svn.wordpress.org/trunk@49504 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-04 17:01:28 +00:00
Sergey Biryukov
da97d6779a Docs: Change the @since entry for template and template_lock post type arguments to 5.0.0.
These arguments were introduced with the initial block editor, but not documented previously.

Follow-up to [49495].

Props TimothyBlynJacobs.
See #46261.

git-svn-id: https://develop.svn.wordpress.org/trunk@49496 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-04 02:45:26 +00:00
Sergey Biryukov
1d2ecc5b6e Docs: Add documentation for the template_lock argument to register_post_type().
Add a `@since` entry for `template` and `template_lock` arguments.

Follow-up to [49041], [49492], [49494].

See #46261.

git-svn-id: https://develop.svn.wordpress.org/trunk@49495 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-04 02:30:24 +00:00
Sergey Biryukov
4d30852307 Docs: Adjust documentation for some WP_Post_Type properties:
* Split the summary for `$template` per the documentation standards. The summary should be a single sentence.
* Change the type for `$template_lock` to `string|false`, to clarify that `true` is not supported.
* Fix typo in `$delete_with_user` description, adjust for better readability.

Follow-up to [49041], [49492].

See #46261.

git-svn-id: https://develop.svn.wordpress.org/trunk@49494 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-04 02:28:55 +00:00
Sergey Biryukov
aed826aab1 Docs: Add a reference to wp_insert_post() for information on the arguments accepted by wp_update_post().
See #50768.

git-svn-id: https://develop.svn.wordpress.org/trunk@49493 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-04 01:37:21 +00:00
Robert Anderson
d72c668d55 Editor: Add explicit template and template_lock attributes
Add and document the template and template_lock attributes on WP_Post_Type that
are used by the block editor.

Props metalandcoffee.
See #46261.


git-svn-id: https://develop.svn.wordpress.org/trunk@49492 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-04 01:03:22 +00:00
Jonathan Desrosiers
4ddaf4b5df Build/Test Tools: Disable update attempts while running unit tests.
This fixes an issue introduced in [49369] that causes l10n related tests to fail when the PHPUnit test suite is run multiple times without hints of the site being under version control.

[49369] removed the `.git` folder from the ZIP artifact created during the initial setup job. This ZIP file is used by the later jobs in the workflow that run the test suite. The absence of the `.git` folder in these later jobs caused the language packs initially loaded from `phpunit/data/languages` folder to be updated asynchronously, resulting in unexpected values when running the tests a second time.

This change disables all Core auto-update and asynchronous language pack update attempts when running PHPUnit tests.

Props ocean90, SergeyBiryukov.
See #50401.
Fixes #51670.

git-svn-id: https://develop.svn.wordpress.org/trunk@49491 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-03 21:07:33 +00:00
Jonathan Desrosiers
cd369595fe Upgrade/Install: Change the notice displayed after saving auto-update settings to .notice-success.
This better conveys the message of the notice and brings consistency with other success notices throughout Core.

Props audrasjb.
Fixes #51701.

git-svn-id: https://develop.svn.wordpress.org/trunk@49490 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-03 17:53:34 +00:00
John Blackbourn
aef5ef26cd Docs: Add more information about how to use filters that run before WordPress initialises.
Fixes #50134


git-svn-id: https://develop.svn.wordpress.org/trunk@49489 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-03 17:34:20 +00:00
John Blackbourn
8fffa6c243 Tests: Remove some useless assertions from the image editor tests.
In each of these instances the variable being tested is a directly instantiated object and can never be a `WP_Error`, unlike when `wp_get_image_editor()` is used.

See #51344


git-svn-id: https://develop.svn.wordpress.org/trunk@49488 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-03 15:50:51 +00:00
Sergey Biryukov
8d5bc0835b Docs: Document the $linkdata parameter of wp_insert_link() using hash notation.
Props stevenlinx, peterwilsoncc.
Fixes #50853.

git-svn-id: https://develop.svn.wordpress.org/trunk@49487 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-03 03:50:29 +00:00
Helen Hou-Sandi
2b7b306f24 Post-WordPress 5.6 Beta 3 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@49486 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-02 21:20:22 +00:00
Helen Hou-Sandi
f648ebbf44 WordPress 5.6 Beta 3.
git-svn-id: https://develop.svn.wordpress.org/trunk@49485 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-02 20:57:35 +00:00
Sergey Biryukov
14fe5a8932 Docs: Update description for the $context parameter of sanitize_title() and sanitize_title_with_dashes().
This brings some consistency between the two DocBlocks and adjusts the latter one per the documentation standards.

Follow-up to [49482].

See #50569.

git-svn-id: https://develop.svn.wordpress.org/trunk@49484 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-02 20:18:12 +00:00
Helen Hou-Sandi
d6653ff05b Upgrade/Install: Update help tab text to include major WordPress updates.
Props audrasjb.
Fixes #51653.


git-svn-id: https://develop.svn.wordpress.org/trunk@49483 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-02 20:14:25 +00:00
Helen Hou-Sandi
38212b2400 Formatting: Update docs for $context in sanitize_title_with_dashes().
Props stevenlinx, audrasjb.
Fixes #50569.


git-svn-id: https://develop.svn.wordpress.org/trunk@49482 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-02 20:10:47 +00:00
Jonathan Desrosiers
61c7935c46 Customize: Ensure menu items expand horizontally on large screens.
Props clorith, garrett-eclipse.
Fixes #51647.

git-svn-id: https://develop.svn.wordpress.org/trunk@49481 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-02 20:05:35 +00:00
Helen Hou-Sandi
85abd2fc8b Site Health: Site errors are for *this* site, not necessarily *your* site.
Props techboyg5, Clorith, audrasjb.
Fixes #51524.


git-svn-id: https://develop.svn.wordpress.org/trunk@49480 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-02 19:53:58 +00:00
Helen Hou-Sandi
07171631d0 About: Optimize freedoms sprite and add 2 column layout.
Props garrett-eclipse, ryelle.
Fixes #46363.


git-svn-id: https://develop.svn.wordpress.org/trunk@49479 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-02 19:43:36 +00:00
Jonathan Desrosiers
f82f8eccf5 Bundled Themes: Sync Twenty Twenty-One with the latest changes from GitHub.
For a full list of changes since [49330], see 5759e96...e7d5991.

Props poena, luminuu, ryelle, kjellr, aristath, justinahinon, felipeelia, joostdevalk.
See #51526.

git-svn-id: https://develop.svn.wordpress.org/trunk@49478 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-02 19:43:07 +00:00
Jonathan Desrosiers
d936f9ffe6 Upgrade/Install: Prevent removal of additional data from plugin update info.
This switches to using `wp_parse_args()` instead of a combination of `array_merge()` and `array_intersect_key()` when ensuring that all expected default keys are present in the update information for a plugin.

This prevents non-default data returned by 3rd-party plugins from being unintentionally stripped out.

Props peterwilsoncc, chriscct7.
Fixes #51609.

git-svn-id: https://develop.svn.wordpress.org/trunk@49477 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-02 19:11:32 +00:00
Helen Hou-Sandi
9d356ed8d9 Remove accidentally duplicated code introduced in [49475].
See #46536.


git-svn-id: https://develop.svn.wordpress.org/trunk@49476 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-02 19:07:29 +00:00
Helen Hou-Sandi
140b29db87 Privacy: More precise checking of user request action names.
Props garrett-eclipse.
Fixes #46536.


git-svn-id: https://develop.svn.wordpress.org/trunk@49475 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-02 18:40:06 +00:00
Helen Hou-Sandi
4985f741d3 General: Make some inline comments more descriptive.
Props jorbin.
Fixes #51683.


git-svn-id: https://develop.svn.wordpress.org/trunk@49474 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-02 18:02:11 +00:00
Robert Anderson
bea15ce1a8 Editor: Update packages
@wordpress/block-directory@1.17.2
@wordpress/block-editor@5.1.2
@wordpress/block-library@2.26.2
@wordpress/edit-post@3.25.2
@wordpress/editor@9.24.2
@wordpress/format-library@1.25.2
@wordpress/reusable-blocks@1.0.2

Props isabel_brison.
See #51696.


git-svn-id: https://develop.svn.wordpress.org/trunk@49473 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-02 04:55:00 +00:00
Sergey Biryukov
55ee43ab94 Docs: Use a consistent plural form of "status".
Props Collizo4sky, Presskopp, davidbaumwald.
Fixes #51690.

git-svn-id: https://develop.svn.wordpress.org/trunk@49472 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-02 01:36:39 +00:00
Sergey Biryukov
06ed23578c Upgrade/Install: Switch "Check again" link on WordPress Updates screen to sentence case.
This brings some consistency with other text links on the screen, e.g. "View version details" for plugins or themes.

Follow-up to [49150].

Props afercia.
See #51523.

git-svn-id: https://develop.svn.wordpress.org/trunk@49471 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-02 01:15:11 +00:00
Sergey Biryukov
560c25765e Twenty Sixteen: Ensure the <nav> elements in widgets do not affect bottom margin.
Follow-up to [49208].

Props sabernhardt.
Fixes #51445.

git-svn-id: https://develop.svn.wordpress.org/trunk@49470 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-31 02:53:15 +00:00
Sergey Biryukov
4bfc35718a Twenty Fifteen: Ensure the <nav> elements in widgets do not affect bottom margin.
Follow-up to [49208].

Props sabernhardt.
See #51445.

git-svn-id: https://develop.svn.wordpress.org/trunk@49469 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-31 02:52:43 +00:00
Jake Spurlock
f72dc8ca54 Upgrade/Install: During the install process, add additional checking for exising tables.
If reinstalling WordPress, there is a condition where tables would exist in the database. Ensures that when that is the case, the install process can carry along without issue.

Fixes #51676.

Props xknown, garubi, mukesh27, desrosj, johnbillion, metalandcoffee, davidbaumwald, whyisjake.



git-svn-id: https://develop.svn.wordpress.org/trunk@49452 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-30 17:50:25 +00:00
Peter Wilson
088fd3cd39 Taxonomy: Revert Light-weight/partial term counts.
Partial revert of [49141], [49171], [49316].

All functional changes are removed, appropriate term counting unit tests are retained.

See #40351.


git-svn-id: https://develop.svn.wordpress.org/trunk@49451 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-30 04:57:16 +00:00
Sergey Biryukov
bba3c98cec Tests: Remove the GLOB_BRACE flag for glob() function from unit tests.
The flag was previously used in PDF preview tests when cleaning up temporary files.

As noted in the PHP documentation, the flag is not available on some non-GNU systems, like Solaris or Alpine Linux.

Follow-up to [40130].

Props amykamala, sawanoboly.
Fixes #51661.

git-svn-id: https://develop.svn.wordpress.org/trunk@49450 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-30 02:01:33 +00:00
Adam Silverstein
3b706fc512 Users: Password generation - restore "Cancel" aria label after r49248.
Restore the "Cancel" button aria label to "Cancel password change" after it was inadvertently changed in r49248.

Props SergeyBiryukov.
Fixes #42852.



git-svn-id: https://develop.svn.wordpress.org/trunk@49392 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-29 18:41:31 +00:00
Adam Silverstein
ae33c9414c REST API: JS Client - improve collection route construction for empty parents.
Fix an issue where the constructed path for hierarchical collections could contain a double slash ("//") when items contained empty parents, causing an error.

Props nicomollet.
Fixes #44745.


git-svn-id: https://develop.svn.wordpress.org/trunk@49390 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-29 18:30:41 +00:00
Jonathan Desrosiers
cbcc595974 Themes: Ensure that only privileged users can set a background image when a theme is using the deprecated custom background page.
Props xknown, zieladam, peterwilsoncc, whyisjake.
Merges [49379] to trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@49388 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-29 18:06:18 +00:00
Jonathan Desrosiers
d5ddd6d4be Meta: Sanitize meta key before checking protection status.
Props zieladam, peterwilsoncc, xknown, whyisjake.
Merges [49377,49381] to trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@49387 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-29 18:05:21 +00:00
Jonathan Desrosiers
2ca15d1e5c Upgrade/install: Improve logic check when determining installation status.
Improve handling of ambiguous return values to determine if a blog is installed.

Props zieladam, xknown.
Merges [49377] to trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@49386 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-29 18:03:35 +00:00
Jonathan Desrosiers
a6488f3ffb XML-RPC: Return error message if attachment ID is incorrect.
Throw an error for incorrect attachment IDs when requesting a media object to ensure return signature is correct and doesn't include incorrectly typed values within the object.

Props zieladam, peterwilsoncc, whyisjake.
Merges [49376] to trunk.
See #49905.

git-svn-id: https://develop.svn.wordpress.org/trunk@49385 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-29 18:02:22 +00:00
Jonathan Desrosiers
5bc27786d1 Coding standards: Modify escaping functions to avoid potential false positives.
Props xknown, zieladam, peterwilsoncc.
Merges [49375] to trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@49384 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-29 18:00:58 +00:00