43729 Commits

Author SHA1 Message Date
Jonathan Desrosiers
b91fab0ddf Build/Test Tools: Update some devDependencies.
This updates a handful of dependencies to their latest versions.

- `qunit` from `2.14.0` to `2.14.1`.
- `uglify-js` from `3.13.0` to `3.13.1`.
- `wait-on` from `5.2.1` to `5.3.0`.

See #52624.

git-svn-id: https://develop.svn.wordpress.org/trunk@50545 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-18 17:47:01 +00:00
Jonathan Desrosiers
4d66791327 External Libraries: Update Clipboard.js library to version 2.0.8.
This updates the `clipboard` library from version `2.0.6` to `2.0.8`.

A full list of changes can be found on GitHub: https://github.com/zenorocha/clipboard.js/compare/v2.0.6...v2.0.8.

Fixes #52850.

git-svn-id: https://develop.svn.wordpress.org/trunk@50544 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-18 15:52:10 +00:00
Jonathan Desrosiers
4842f978a7 External Libraries: Update jQuery Color library to version 2.2.0.
This updates the `jquery-color` library from version `2.1.2` to `2.2.0`.

This also switches back to installing the dependency from NPM instead of GitHub. The maintainers have resumed publishing to NPM with the 2.2.0 release.

A full list of changes can be found on GitHub: https://github.com/jquery/jquery-color/compare/2.1.2...2.2.0.

Props hareesh-pillai, desrosj.
Fixes #51405.

git-svn-id: https://develop.svn.wordpress.org/trunk@50543 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-18 15:48:43 +00:00
Jonathan Desrosiers
afbcd1bd63 Build/Test Tools: Revert [50540].
The E2E workflow is failing after this change. Reverting to to investigate further.

Unprops desrosj.
See #52843.

git-svn-id: https://develop.svn.wordpress.org/trunk@50542 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-18 14:33:12 +00:00
Sergey Biryukov
3c85e60449 Coding Standards: Use strict comparison for JS fragment in some admin files.
Follow-up to [48083].

Props nayanchamp7, rnaby.
Fixes #52845, #41988.

git-svn-id: https://develop.svn.wordpress.org/trunk@50541 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-18 14:11:55 +00:00
Jonathan Desrosiers
6447fcc8a6 Build/Test Tools: Remove explicit puppeteer dependency.
This was added in [48177] to fix an issue where Puppeteer was not being installed correctly as a dependency of `@wordpress/wp-scripts`. This has been fixed, so this explicit dependency can be removed.

Props isabel_brison.
Fixes #52843.

git-svn-id: https://develop.svn.wordpress.org/trunk@50540 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-18 12:42:28 +00:00
Sergey Biryukov
3f7760b93e Docs: Correct formatting for the description of some register_post_type() parameters.
Props audrasjb.
Fixes #52836.

git-svn-id: https://develop.svn.wordpress.org/trunk@50538 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-17 17:31:19 +00:00
Sergey Biryukov
d984b548c8 Tests: Correct some newly introduced @covers tags.
Follow-up to [50289], [50344].

Props jrf.
See #39265.

git-svn-id: https://develop.svn.wordpress.org/trunk@50537 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-16 18:44:40 +00:00
Kelly Choyce-Dwan
1479f1e543 Help/About: Run image comparison script after all assets have loaded.
If the callback is called before the images are loaded, the comparison doesn't work. `wp.domReady` uses `DOMContentLoaded`, which does not guarantee that the images are loaded. This switches to use the `load` event, which waits for all resources to load.

Props vladytimy, joyously, sergeybiryukov.
Fixes #52758.



git-svn-id: https://develop.svn.wordpress.org/trunk@50535 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-15 19:49:50 +00:00
Sergey Biryukov
a33ee3511a Twenty Seventeen: Remove extra space around post editor.
The editor uses the full height of its container, so the added margins cause the visual editor to break out of the container. This removes the top & bottom margins, and makes the left & right margins consistent with the meta box area.

Follow-up to [50465].

Props joseeyoast, audrasjb.
Fixes #52816.

git-svn-id: https://develop.svn.wordpress.org/trunk@50534 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-15 13:24:24 +00:00
Sergey Biryukov
b22c4a1dce Coding Standards: Remove some extra whitespace in sanitize_comment_cookies().
See #52627.

git-svn-id: https://develop.svn.wordpress.org/trunk@50533 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-14 16:59:45 +00:00
Sergey Biryukov
1f993de977 Docs: Synchronize $category_name description in WP_Block_Pattern_Categories_Registry methods.
Follow-up to [48156].

See #52628.

git-svn-id: https://develop.svn.wordpress.org/trunk@50532 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-13 11:15:14 +00:00
Sergey Biryukov
72e10ec97b Docs: Correct DocBlock formatting for register_block_style_handle().
Follow-up to [48141].

See #52628.

git-svn-id: https://develop.svn.wordpress.org/trunk@50531 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-13 11:13:55 +00:00
Sergey Biryukov
a3dd4b7d56 Site Health: Use a singular string in dashboard widget if there is only one critical issue or recommendation.
Props Presskopp, hareesh-pillai.
Fixes #52521.

git-svn-id: https://develop.svn.wordpress.org/trunk@50530 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-13 10:57:27 +00:00
Sergey Biryukov
1446948f95 Docs: Add missing @since tags for item_link and item_link_description post type and taxonomy labels.
Follow-up to [50527].

See #52688.

git-svn-id: https://develop.svn.wordpress.org/trunk@50529 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-13 10:23:56 +00:00
David Baumwald
43443bdf15 Docs: Correct unregister_block_style @param for $block_name.
In `unregister_block_style`, the `$block_name` parameter was documented as an array.  This change corrects the type to `string`, as that's what is expected in `WP_Block_Styles_Registry->unregister`. 

Props kraftner.
Fixes #52795.

git-svn-id: https://develop.svn.wordpress.org/trunk@50528 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-12 20:03:44 +00:00
Greg Ziółkowski
380d0445e8 Editor: Make block type aware of variations
Currently block variations are only defined on the client. In some cases, creating block variations on the server can be very useful, especially when needed data is not exposed in the REST APIs.

Related to https://github.com/WordPress/gutenberg/pull/29095.

Props: gwwar, timothyblynjacobs.
Fixes: #52688.



git-svn-id: https://develop.svn.wordpress.org/trunk@50527 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-12 13:33:21 +00:00
Sergey Biryukov
6877f57f36 Accessibility: Administration: Use a darker color for post dates in the Activity and Quick Draft dashboard widgets.
This ensures that the color meets the WCAG 2.0 AA recommended contrast ratio.

Follow-up to [50025].

Props sabernhardt, Otshelnik-Fm, audrasjb.
Fixes #52760.

git-svn-id: https://develop.svn.wordpress.org/trunk@50525 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-12 12:04:21 +00:00
Kelly Choyce-Dwan
cded2eb52a Help/About: Use absolute URLs for inline images on About pages.
This ensures the images are loaded correctly from both single site and network About pages.

Props TobiasBg, audrasjb.
Fixes #52743.



git-svn-id: https://develop.svn.wordpress.org/trunk@50523 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-11 21:36:55 +00:00
Sergey Biryukov
4fadd1f574 Coding Standards: Consistently format opendir() calls in get_plugins().
Props sabernhardt, subrataemfluence.
Fixes #44250.

git-svn-id: https://develop.svn.wordpress.org/trunk@50522 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-11 15:17:56 +00:00
Jonathan Desrosiers
e20b23d810 External Libraries: Update jQuery hoverIntent to version 1.10.1.
This updates the `jquery-hoverintent` dependency from 1.8.3 to 1.10.1.

For a full list of changes, see https://github.com/briancherne/jquery-hoverIntent/compare/v1.8.3...v1.10.1.

Fixes #52686.

git-svn-id: https://develop.svn.wordpress.org/trunk@50521 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-10 15:23:06 +00:00
Jonathan Desrosiers
9af2725b7c External Libraries: Update jQuery to version 3.6.0.
This updates the jQuery dependency from 3.5.1 to 3.6.0.

For a full list of changes, see https://github.com/jquery/jquery/compare/3.5.1...3.6.0.

Fixes #52707. See #51812.

git-svn-id: https://develop.svn.wordpress.org/trunk@50520 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-10 15:05:43 +00:00
Sergey Biryukov
5c7c0df15b Help/About: Correct the WebM video URL on About page.
Props mihdan, audrasjb.
Fixes #52756.

git-svn-id: https://develop.svn.wordpress.org/trunk@50518 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-10 10:26:33 +00:00
Peter Wilson
6d4739c51f Docs: Improve spelling in [50516].
Props jeremyfelt.
See #52628, #34564.


git-svn-id: https://develop.svn.wordpress.org/trunk@50517 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-09 23:20:24 +00:00
Peter Wilson
bc14aea75d Docs: Improve compatibility comment in WP_List_Table.
Improve comment explaining backward compatibility check for the primary column in `WP_List_Table::get_column_info()`.

Unprops helen, markjaquith.
See #52628, #34564.



git-svn-id: https://develop.svn.wordpress.org/trunk@50516 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-09 22:33:47 +00:00
Sergey Biryukov
5ae4c30a03 Classic Editor: Make sure word count is hidden if JavaScript is disabled.
Removing `display: block` from the element allows the `.hide-if-no-js` class to have the intended effect.

Follow-up to [34275].

Props sabernhardt, mukesh27.
Fixes #52662.

git-svn-id: https://develop.svn.wordpress.org/trunk@50512 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-09 10:11:21 +00:00
Jonathan Desrosiers
a6f9088a35 Update $_old_files for 5.7.
Follow up to [50066].

See #52334.

git-svn-id: https://develop.svn.wordpress.org/trunk@50510 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-08 18:28:35 +00:00
Jonathan Desrosiers
94e3c028e6 Bundled Themes: Bump theme version numbers for WordPres 5.7.
This updates all new default themes to new versions, which will be released shortly after WordPress 5.7. The new versions are:

- Twenty Twenty-One: 1.2
- Twenty Twenty: 1.7
- Twenty Nineteen: 2.0
- Twenty Seventeen: 2.6
- Twenty Sixteen: 2.4
- Twenty Fifteen: 2.9
- Twenty Fourteen: 3.1
- Twenty Thirteen: 3.3
- Twenty Twelve: 3.4
- Twenty Eleven: 3.7
- Twenty Ten: 3.3

Fixes #52704.

git-svn-id: https://develop.svn.wordpress.org/trunk@50507 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-08 14:15:53 +00:00
Sergey Biryukov
3d8a5fd839 Upgrade/Install: Display version number on the "Update now" button on WordPress Updates screen.
Additionally, adjust the "Update to latest nightly" button to include the major version number of the nightly build.

This makes the button labels more accurate and provides more clear understanding of what the update will be.

Follow-up to [49984].

Props afragen, pbiron, SergeyBiryukov.
Fixes #52513.

git-svn-id: https://develop.svn.wordpress.org/trunk@50506 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-08 11:29:37 +00:00
John Blackbourn
fa05e5e733 Docs: Add examples of possible names for various hooks whose name contains a dynamic portion.
This provides greater discoverability of such hooks in search results on the Code Reference site as well as increased clarity when reading the source.

See #50734, #52628


git-svn-id: https://develop.svn.wordpress.org/trunk@50505 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-07 12:30:38 +00:00
Sergey Biryukov
c3be472657 Docs: Add a @since note to wp_admin_bar_edit_menu() about the "View Post" link on Comments screen for a single post.
Follow-up to [47903].

Props sabernhardt, janak007, munyagu.
Fixes #42366.

git-svn-id: https://develop.svn.wordpress.org/trunk@50504 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-07 11:54:53 +00:00
John Blackbourn
26772874ce Build/Test Tools: Ensure the test_php_and_js_shortcode_attribute_regexes_match() test can run when testing using either the src or build directory.
Props alexstine, desrosj

See #51734


git-svn-id: https://develop.svn.wordpress.org/trunk@50501 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-05 15:26:22 +00:00
Sergey Biryukov
a577e4f21e XML-RPC: Pass an empty array to the xmlrpc_call action in methods that have no arguments.
This avoids an "Undefined variable" PHP notice in the `::mt_supportedMethods()` and `::mt_supportedTextFilters()` methods.

Follow-up to [50353].

Props dd32.
Fixes #52524.

git-svn-id: https://develop.svn.wordpress.org/trunk@50499 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-05 11:01:54 +00:00
Robert Anderson
0db14900ff Editor: Update @wordpress npm packages
Update @wordpress npm packages to the latest published versions. This includes
block editor bug fixes for WordPress 5.7 RC 3.

See #52718.


git-svn-id: https://develop.svn.wordpress.org/trunk@50496 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-05 04:08:33 +00:00
Kelly Choyce-Dwan
ae72cc12b0 Help/About: Clarify two strings.
The intro text has been updated for accuracy and to make it easier for translation. The button text has been updated for accuracy.

Props jdy68, audrasjb, marybaum, davidbaumwald.
See #52347.



git-svn-id: https://develop.svn.wordpress.org/trunk@50495 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-04 19:08:38 +00:00
Jonathan Desrosiers
401fb2f60c Twenty Twenty-One: Make text readable when dark background is selected for the Media & Text block.
This change ensures that the text in the Media & Text block is readable when dark background colors are selected.

This is a regression that was introduced in [49987].

Props hellofromTonya, poena, paaljoachim, ryelle.
Fixes #52702.

git-svn-id: https://develop.svn.wordpress.org/trunk@50493 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-04 16:55:16 +00:00
Sergey Biryukov
5cfc632581 Docs: Update inline comments in some test files per the documentation standards.
See #52628.

git-svn-id: https://develop.svn.wordpress.org/trunk@50491 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-04 10:11:38 +00:00
Peter Wilson
f2779be7f0 Roles/Caps: Return same result from current_user_can and user_can().
Ensure `current_user_can()` and `user_can()` return the same results for logged out users. For core capabilities this changes `user_can( 0, 'exist' )` to return `true` rather than `false` in line with `current_user_can( 'exist' )` for logged out users.

Convert `current_user_can()` and `current_user_can_for_blog()` to wrapper functions ultimately calling `user_can()`.

Add anonymous user to primitive capability checks as appropriate. Convert `Tests_User_Capabilities::test_other_caps_for_all_roles()` to use a data provider and add tests to check whether user exists in the database (`WP_User::exists()`) as that intentionally differs from the `exist` capability.

Props jjj, johnbillion, peterwilsoncc, SergeyBiryukov, TimothyBlynJacobs.
Fixes #52076.



git-svn-id: https://develop.svn.wordpress.org/trunk@50490 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-04 00:12:55 +00:00
Robert Anderson
58fff52e45 Block Editor: Fix color support for dynamic blocks
Changes wp_apply_colors_support to check for for color instead of
__experimentalColor when determining block support for color.

Props nosolosw, rafhun, youknowriad.
See #52709.


git-svn-id: https://develop.svn.wordpress.org/trunk@50488 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-03 23:29:48 +00:00
Jonathan Desrosiers
8ab1912b10 Build/Test Tools: Update some dependencies.
This updates the following `devDependencies`:

- `grunt-contrib-cssmin` from `3.0.0` to `4.0.0`.
- `uglify-js` from `3.12.8` to `3.13.0`.

See #52624.

git-svn-id: https://develop.svn.wordpress.org/trunk@50487 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-03 21:14:15 +00:00
Jonathan Desrosiers
137b305fff Build/Test Tools: Pin SHA versions to the remaining 3rd party actions.
This also adds inline comments to the end of each action installed using a SHA value to make it easier to determine which version of an action is currently being used.

Follow up to [50474,50476].

Props johnbillion.
See #52625.

git-svn-id: https://develop.svn.wordpress.org/trunk@50486 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-03 20:29:04 +00:00
Jonathan Desrosiers
cca6459b28 Build/Test Tools: Generalize the NPM test workflow.
The NPM test GitHub Actions workflow is currently used to verify that `npm install` and `npm run build` will complete successfully on Windows.

This generalizes the workflow and adds testing for Linux and MacOS to confirm that the scripts used to build WordPress also complete successfully in those environments.

Because MacOS workflow runs consume GHA minutes at a 10x rate, it’s added in a separate job in order to perform a more strict check.

This also adds steps to verify that using `npm run build:dev` and `npm run grunt clean`/`npm run grunt clean —dev` run successfully 

Props johnbillion.
Fixes #52658.

git-svn-id: https://develop.svn.wordpress.org/trunk@50485 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-03 19:50:40 +00:00
Sergey Biryukov
4349463f32 Docs: Update documentation in some WP_REST_Request tests per the documentation standards.
Follow-up to [49329].

See #52628.

git-svn-id: https://develop.svn.wordpress.org/trunk@50484 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-03 19:24:44 +00:00
Sergey Biryukov
69032204d5 Help/About: Clarify a string about lazy-loading iframes.
Props davidbaumwald, audrasjb, hellofromTonya.
See #52347.

git-svn-id: https://develop.svn.wordpress.org/trunk@50483 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-02 21:36:04 +00:00
Jonathan Desrosiers
481bdeebdf Build/Test Tools: Add path detection when running GitHub Actions on pull_request.
This change adds a list of paths to check when determining which workflows to run on `pull_request`. This will prevent certain workflows from running unnecessarily when the files updated are not related to the tests and checks being performed.

Props peterwilsoncc, johnbillion.
Fixes #52667.

git-svn-id: https://develop.svn.wordpress.org/trunk@50479 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-02 19:57:15 +00:00
Kelly Choyce-Dwan
fdbffbd2bd Help/About: Iterate on the 5.7 About Page.
Adds a more obviously interactive comparison for viewing the color scheme differences. Improvements on RTL and IE11. Update strings to be more clear and consistent. Switch to the CDN for loading images.

Props sarahricker, desrosj, melchoyce, SergeyBiryukov, tikifez, clorith, marybaum, audrasjb, francina, hellofromTonya.
Fixes #52693. See #52347.



git-svn-id: https://develop.svn.wordpress.org/trunk@50478 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-02 19:48:41 +00:00
Jonathan Desrosiers
780e0ffd91 Build/Test Tools: Change the cancel-workflow-action version to a SHA value.
Additionally, the `access_token` input now defaults to `github.token`, so specifying it is unnecessary.

Follow up to [50474].

Props johnbillion.
See #52625.

git-svn-id: https://develop.svn.wordpress.org/trunk@50476 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-02 17:47:33 +00:00
Mike Schroder
ae983c3f99 Upgrade/Install: Invalidate OPcache for version.php during update.
Invalidate OPcache for `wp-content/version.php` on update individually, since it’s copied separately.

Props stodorovic, krstarica, cenay, desrosj, pbiron, sergeybiryukov, mikeschroder.
Fixes #51686, #51281.
See #36455.

git-svn-id: https://develop.svn.wordpress.org/trunk@50475 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-02 17:11:35 +00:00
Jonathan Desrosiers
bb046b0700 Build/Test Tools: Pin the welcome-action to a specific commit SHA.
Some GitHub Action scripts require additional permissions to perform the desired operations. This permission is usually given by passing a personal access token (PAT) to the action as an input.

Because PATs grant access to sensitive information about the repository and actions with PATs become trusted actors, 3rd party actions should not be installed by specifying a major or minor version.

Instead, specifying a full length commit SHA will use the 3rd party action as an immutable release, ensuring the workflows within the repository are not affected by upstream security problems should they occur.

Props johnbillion.
See #52625.

git-svn-id: https://develop.svn.wordpress.org/trunk@50474 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-02 16:09:16 +00:00
Jonathan Desrosiers
1ca0e68fc1 Build/Test Tools: Run automated testing workflows for trunk branch.
This ensures a seamless transition when the primary branch is changed from `master` to `trunk` in the GitHub mirror. Once the transition is completed, the `master` branch can be removed.

See https://make.wordpress.org/systems/2021/03/02/update-git-wordpress-org-to-rename-master-to-trunk/ and https://make.wordpress.org/core/2020/06/18/proposal-update-all-git-repositories-to-use-main-instead-of-master/.

See #52625.

git-svn-id: https://develop.svn.wordpress.org/trunk@50473 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-02 15:26:03 +00:00