Instead of using `Array.toString()` to serialize an array with comma delimiters, explicitly `join` the array using spaces instead. Also ensure that `xfn` is handled properly if it ever gets stored as an array.
Cherry-picks [34788].
Props tyxla, westonruter.
Fixes#34111 for 4.3.
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@34789 602fd350-edb4-49c9-b593-d223f7449a82
Updates event handler in `wpAjax.invalidateForm()` to support `wp-check-valid-field`.
Merge of [34114] to the 4.3 branch.
Fixes#33406.
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@34120 602fd350-edb4-49c9-b593-d223f7449a82
The second parameter `$plaintext_pass` was removed in [33023] and restored as `$notify` in [33620] with a different behavior. If you have a plugin overriding `wp_new_user_notification()` which hasn't been updated you would get a notification with your username and the password "both".
To prevent this the second parameter is now deprecated and reintroduced as the third parameter.
Adds unit tests.
Merge of [34116] to the 4.3 branch.
Props kraftbj, adamsilverstein, welcher, ocean90.
See #33654.
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@34118 602fd350-edb4-49c9-b593-d223f7449a82
Use feature detection to determine whether password inputs should use the `keyup` or `input` event.
Merge of [34060] to the 4.3 branch.
Props peterwilsoncc, adamsilverstein.
Fixes#33398.
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@34078 602fd350-edb4-49c9-b593-d223f7449a82
The previous move from echo() to _e() left some of the output hanging. Introduced in [32333].
Merge of [34057] to the 4.3 branch.
Props figureone.
Fixes#33811.
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@34058 602fd350-edb4-49c9-b593-d223f7449a82
Prevents a JavaScript error for rare cases when cropping is skipped and the image is smaller than `thumbnail`.
Merge of [34056] to the 4.3 branch.
Props tyxla.
See #33417.
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@34057 602fd350-edb4-49c9-b593-d223f7449a82
The position of periods is different in some languages, like Japanese. This removes the period from the last placeholder for the Template Hierarchy section. It doesn't include a new period to avoid a string change in a minor release.
Merge of [34054] to the 4.3 branch.
Props extendwings, chriscct7.
See #33429.
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@34055 602fd350-edb4-49c9-b593-d223f7449a82
[32523] introduced the $public_only parameter to `count_user_posts()`. That
changeset was supposed to pass `$public_only` to the 'get_usernumposts' filter
at the end of the function, but only the documentation was modified, not the
filter itself.
This changeset also fixes an incorrect variable name in the docblock for
the same filter, and includes clarification on the accepted values for
the `$post_type` parameter.
Merges [33710] and [33716] to the 4.3 branch.
Props swisspidy, tmatsuur, tyxla, DrewAPicture.
Fixes#33481 for 4.3.1.
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@33953 602fd350-edb4-49c9-b593-d223f7449a82
As of [32484], `wp_dropdown_categories()` uses the `$value_field` value to
decide whether a given `<option>` should be 'selected'. However, `$value_field`
can refer to a value that is a string, such as a category's slug. This causes
problems when doing a loose comparison (`==`) with the value of the 'selected'
parameter, which defaults to `0`, because when doing a loose comparison
between an integer and a string, PHP will cast the string to an integer. This
creates false matches, resulting in `<option>` elements getting a 'selected'
attribute incorrectly.
We address the issue by casting the comparison values to strings, and then
using the strict comparison operator `===`.
Merges [33681] to the 4.3 branch.
Fixes#33452 for 4.3.1.
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@33949 602fd350-edb4-49c9-b593-d223f7449a82
Fix removes need for workaround introduced in [33488] for direct link from nav menu widget to the customizer widgets panel. The todo is now implemented.
Cherry-picks [33837] onto 4.3 branch.
Props celloexpressions, westonruter.
Fixes#33396 for 4.3.
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@33942 602fd350-edb4-49c9-b593-d223f7449a82
This fixes the 'The update cannot be installed because we will be unable to copy some files.' error encountered during updates by skipping the write test completely.
Merges [33688] to the 4.3 branch.
Props jobst.
Fixes#33480 for 4.3
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@33883 602fd350-edb4-49c9-b593-d223f7449a82
Reverts unnecessary change in [32602] since `array_key_exists()` does actually work with `ArrayIterator` objects.
Merges [33696] to the 4.3 branch.
See #32474.
Fixes#33442 for the 4.3 branch.
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@33721 602fd350-edb4-49c9-b593-d223f7449a82
The existing invalid cron entries will not be purged automatically (as the 'timestamp' is never matched) so we do this ourselves.
Merges [33646] to the 4.3 branch.
Props mechter for noticing!
See #30261.
Fixes#33423 for the 4.3 branch.
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@33647 602fd350-edb4-49c9-b593-d223f7449a82
Also adjusts locale handling to work with Videopress' subtitle implementation.
Props siobhan, jacklenox, sararosso, hugobaeta, nickmomrik, rauchg.
See #32929.
git-svn-id: https://develop.svn.wordpress.org/trunk@33631 602fd350-edb4-49c9-b593-d223f7449a82
If the post cache is not cleared at this point, the cache can become stale
for operations performed before the cache is cleared later in the function.
Specifically, the generation of a `guid` for new posts can use stale data,
resulting in non-unique values. [33262] introduced a call to `get_post()`
that introduced just such an invalidation problem.
Fixes#5305.
git-svn-id: https://develop.svn.wordpress.org/trunk@33630 602fd350-edb4-49c9-b593-d223f7449a82
