1764 Commits

Author SHA1 Message Date
Sergey Biryukov
6ec895a915 Date/Time: Use delta comparison in get_gmt_from_date() tests to avoid race conditions.
Follow-up to [35284].

Props keesiemeijer.
Merges [41920] to the 4.5 branch.
See #38815.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@51615 602fd350-edb4-49c9-b593-d223f7449a82
2021-08-15 13:39:01 +00:00
Jonathan Desrosiers
96abcf3067 Build/Test Tools: Add an object cache drop-in.
This adds an object cache drop-in to the `tests/phpunit/includes` directory to avoid relying on and having to copy from an external repository.

Follow up to [50313].

See #50401.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@50315 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-12 20:10:11 +00:00
Sergey Biryukov
994ccb10f9 Tests: Move skipTestOnTimeout() to a more appropriate location, for consistency with other branches.
Follow-up to [50088].

Merges [50097] to the 4.5 branch.
See #51669.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@50099 602fd350-edb4-49c9-b593-d223f7449a82
2021-01-30 15:26:30 +00:00
Sergey Biryukov
f8317b35a7 Tests: Use skipTestOnTimeout() in more HTTP tests.
Adjust it to handle more types of timeouts, e.g. "Resolving timed out", "Connection timed out".

Merges [38757], [43511], [43512], [46682], [46996] to the 4.5 branch.
See #51669.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@50090 602fd350-edb4-49c9-b593-d223f7449a82
2021-01-30 12:04:12 +00:00
Jake Spurlock
05a7b2bce2 General: WordPress updates
* XML-RPC: Improve error messages for unprivileged users.
* External Libraries: Disable deserialization in Requests_Utility_FilteredIterator
* Embeds: Disable embeds on deactivated Multisite sites.
* Coding standards: Modify escaping functions to avoid potential false positives.
* XML-RPC: Return error message if attachment ID is incorrect.
* Upgrade/install: Improve logic check when determining installation status.
* Meta: Sanitize meta key before checking protection status.
* Themes: Ensure that only privileged users can set a background image when a theme is using the deprecated custom background page.

Brings the changes from [49380,49382-49388] to the 4.5 branch.

Props xknown, zieladam, peterwilsoncc, whyisjake, desrosj, dd32.


git-svn-id: https://develop.svn.wordpress.org/branches/4.5@49401 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-29 19:01:42 +00:00
Jake Spurlock
971529fb03 User: Invalidate user_activation_key on password update.
Query: Ensure that only a single post can be returned on date/time based queries.
Cache API: Ensure proper escaping around the stats method in the cache API.
Formatting: Expand `sanitize_file_name` to have better support for utf8 characters.

Brings the changes in [47634], [47635], [47637], and [47638] to the 4.7 branch.

Props: batmoo, ehti, nickdaugherty, peterwilsoncc, sergeybiryukov, sstoqnov, westi, whyisjake, whyisjake, xknown.


git-svn-id: https://develop.svn.wordpress.org/branches/4.5@47652 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-29 16:25:54 +00:00
Sergey Biryukov
daf66727df Build/Test Tools: Remove unused ::assertPostHasTerms() method from tests/term.php.
The associated test was removed in [30241].

Merges [47341] to 3.7+ branches.
See #49485.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@47489 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-22 14:29:03 +00:00
Sergey Biryukov
4f12f34567 Embeds: Remove the external oEmbed tests for YouTube.
These tests no longer test anything that WordPress core has control over. YouTube now serves everything
over HTTPS by default, so the tests for #23149 will always pass, and the tests for #32714 aren't testing
anything that core has control over.

Tests for the responses from oEmbed providers has been attempted and reverted in #32360.

Props johnbillion.
Merges [41712] to the 4.5 branch.
See #42076, #32714, #23149.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@47482 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-22 13:46:15 +00:00
Sergey Biryukov
9573084b5d Update wp_kses_bad_protocol() to recognize : on uri attributes,
`wp_kses_bad_protocol()` makes sure to validate that uri attributes don’t contain invalid/or not allowed protocols. While this works fine in most cases, there’s a risk that by using the colon html5 named entity, one is able to bypass this function.

Brings r46895 to the 4.5 branch.

Props: xknown, nickdaugherty, peterwilsoncc.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@46913 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-12 18:44:52 +00:00
Jake Spurlock
478c668350 Backporting several bug fixes.
- Query: Remove the static query property.
- HTTP API: Protect against hex interpretation.
- Filesystem API: Prevent directory travelersals when creating new folders.
- Administration: Ensure that admin referer nonce is valid.
- REST API: Send a Vary: Origin header on GET requests.
- Customizer: Properly sanitize background images.

Backports [46474], [46475], [46476], [46477], [46478], [46483], [46485] to the 4.5 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.5@46497 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 19:06:04 +00:00
Jonathan Desrosiers
fafead9bef Fix for URL sanitization in wp_kses_bad_protocol_once().
Merges [45997] to the 4.5 branch.

Props irsdl, sstoqnov, whyisjake.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@46009 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 18:21:38 +00:00
Sergey Biryukov
db04e3935e Improve handling the existing rel attribute in wp_rel_nofollow_callback().
Merges [45990] to the 4.5 branch.
Props xknown, sstoqnov.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@45999 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 17:53:08 +00:00
Jake Spurlock
7cab047134 Remove _convert_urlencoded_to_entities() from the get_the_content() callback.
Merges [45937] to the 4.5 branch.

Props vortfu, whyisjake, peterwilsoncc


git-svn-id: https://develop.svn.wordpress.org/branches/4.5@45957 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 16:38:26 +00:00
Jeremy Felt
6eb8051102 Media: Remove invalid data from test data provider.
See [43993].


git-svn-id: https://develop.svn.wordpress.org/branches/4.5@44006 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-12 23:37:16 +00:00
Jeremy Felt
0127179f66 Media: Improve verification of MIME file types.
Merges [43988] to the 4.5 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.5@43993 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-12 23:10:04 +00:00
John Blackbourn
7895704527 General: Remove the version number from the readme file in the 4.5 branch.
See #42386


git-svn-id: https://develop.svn.wordpress.org/branches/4.5@42102 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-31 18:06:57 +00:00
Gary Pendergast
1260edf573 Database: Restore numbered placeholders in wpdb::prepare().
[41496] removed support for numbered placeholders in queries send through `wpdb::prepare()`, which, despite being undocumented, were quite commonly used.

This change restores support for numbered placeholders (as well as a subset of placeholder formatting), while also adding extra checks to ensure the correct number of arguments are being passed to `wpdb::prepare()`, given the number of placeholders.

Merges [41662], [42056] to the 4.5 branch.
See #41925.



git-svn-id: https://develop.svn.wordpress.org/branches/4.5@42060 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-31 12:43:36 +00:00
Gary Pendergast
2654afaacd Build/Test Tools: Pass correct $message argument to WP_UnitTestCase::setExpectedException() in Tests_Ajax_CompressionTest::test_logged_out() and Tests_Ajax_TagSearch::test_no_results().
PHPUnit 6.4.1 and earlier versions ignored the `'0'` value, causing the issue to go unnoticed.

Merge of [41870] to the 4.5 branch.

Props SergeyBiryukov.
See #42232.



git-svn-id: https://develop.svn.wordpress.org/branches/4.5@42054 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-31 09:10:03 +00:00
Aaron D. Campbell
0f83d87e7f Database: Hardening to bring wpdb::prepare() inline with documentation.
`wpdb::prepare()` supports %s, %d, and %F as placeholders in the query string. Any other non-escaped % will be escaped.

Merges [41496] to 4.5 branch.



git-svn-id: https://develop.svn.wordpress.org/branches/4.5@41500 602fd350-edb4-49c9-b593-d223f7449a82
2017-09-19 18:13:37 +00:00
Aaron D. Campbell
6a7e5a85fb Database: Hardening for wpdb::prepare()
Previously if you passed an array of values for placeholders, additional values could be passed as well. Now additional values will be ignored.

Merges [41470] to 4.5 branch.



git-svn-id: https://develop.svn.wordpress.org/branches/4.5@41474 602fd350-edb4-49c9-b593-d223f7449a82
2017-09-19 14:59:58 +00:00
Weston Ruter
d83f0a2443 Customize: Fix phpunit tests after [40704] due to logic inversion error.
Merge of [40716] to the 4.5 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.5@40719 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-16 14:41:45 +00:00
John Blackbourn
894194b869 Build/Test tools: In Travis, skip some tests when not on trunk.
This skips time sensitive tests (copyright year and PHP/MySQL version requirements) when tests are run on branches on Travis.

Props netweb, jorbin

Fixes #39486

Merges [40241] to the 4.5 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.5@40242 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-08 00:10:29 +00:00
Aaron D. Campbell
3332aedf2a Strip control characters before validating redirect.
Merges [40183] to 4.5 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.5@40186 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-06 13:40:49 +00:00
Joe McGill
774443c94f Media: Improved media titles when created from filename.
Preserves spaces and generally creates more accurate, cleaner titles from filenames of uploaded media.

Merge of [38615] to the 4.5 branch.

Fixes #37989.


git-svn-id: https://develop.svn.wordpress.org/branches/4.5@39711 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-05 16:12:50 +00:00
Joe McGill
114597aec1 Media: Improve handling of extensionless filenames.
Merge of [37756] to the 4.5 branch.

See #37111.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@37809 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-21 14:50:55 +00:00
Pascal Birchler
edb9596c6b Embeds: Enforce a valid post ID when embedding a post from the current site.
Otherwise `wp_filter_pre_oembed_result()` could erroneously return the HTML of the current post instead of the intended result.

Merge of [37729] to the 4.5 branch.

Props kraftbj.
See #36767.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@37732 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-16 17:29:51 +00:00
Pascal Birchler
b4e06aa412 Fix tests after [37709].
Avoids using `assertNotFalse()` which is only available in PHPUnit 4.0 and above.

See [37708], [37710].
See #36767.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@37711 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-15 12:23:13 +00:00
Pascal Birchler
d60c6d1206 Embeds: Improve performance when embedding a post of the current site.
When the post being embedded is from the same site, there's no reason to do an HTTP request for it. The data can be fetched directly using `get_oembed_response_data()`.

Merge of [37708] to the 4.5 branch.

Fixes #36767.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@37709 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-15 11:31:12 +00:00
Dominik Schilling (ocean90)
d9a1e36886 Database: dbDelta() will no longer try to downgrade the size of TEXT and BLOB columns.
When upgrading to `utf8mb4`, `TEXT` fields will be upgraded to `MEDIUMTEXT` (and likewise for all other `*TEXT` and `*BLOB` fields). This is to allow for the additional space requirements of `utf8mb4`.

On the subsequent upgrade, after the `utf8mb4` upgrade, `dbDelta()` would try and downgrade the fields to their original size again. At best, this it a waste of time, at worst, this could truncate any data larger than the original size. There's no harm in leaving them at their original size, so let's do that.

Merge of [37525] to the 4.5 branch.

Props pento.
See #36748.



git-svn-id: https://develop.svn.wordpress.org/branches/4.5@37606 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-01 12:58:36 +00:00
Dominik Schilling (ocean90)
7dc9387dd8 Customize: Handle filtering sidebars_widgets when the underlying option is non-existent.
Fixes warning related to a non-array argument for `array_merge()` in `WP_Customize_Widgets::customize_register()`. 

Merge of [37352] to the 4.5 branch.

See [37166].
See #36389.
Fixes #36660.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@37453 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-17 20:33:26 +00:00
Aaron Jorbin
7ad2ba8904 Correct usage of Covers for Tests_Update_Comment_Count_Now
When @covers is used with a plain alphanumeric string, PHPUnit assumes that it is covering a class. If there is no class, it fails and exits rather than continuing to generate coverage. To cover a global function, the name must start with `::`.  See https://phpunit.de/manual/5.3/en/appendixes.annotations.html#appendixes.annotations.covers

See #35060, #36867



git-svn-id: https://develop.svn.wordpress.org/branches/4.5@37445 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-17 17:51:17 +00:00
Dominik Schilling (ocean90)
32b4f3ee2e Media: Remove an extra quote when sending a link of a media file to the editor.
Introduced in [37035].

Merge of [37288] to the 4.5 branch.

Props joemcgill, swissspidy, boonebgorges.
Fixes #36578.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@37289 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-21 21:33:14 +00:00
Dominik Schilling (ocean90)
faf89dccd4 Themes: Revert [36112]
Adding the `singular` class per default to the list of body classes is breaking the layout of Twenty Eleven and other themes. Twenty Eleven adds the `singular` class only to single pages if the page doesn't use specific page templates.

Merge of [37249] to the 4.5 branch.

Props flixos90, swissspidy.
Fixes #36510.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@37250 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-19 21:27:01 +00:00
Jeremy Felt
f98744ec86 Ensure consistent dependency order when using wp_add_inline_script()
This disables the concatenation of remaining enqueued scripts once `wp_add_inline_script()` is invoked, which allows us to reliably print these scripts and their before/after inline scripts in the desired order.

Props gitlost, azaozz, swisspidy, ocean90.
Fixes #36392.


git-svn-id: https://develop.svn.wordpress.org/trunk@37171 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-10 03:32:47 +00:00
Dominik Schilling (ocean90)
ca5db69c31 Customize: Harden assignment of Customizer settings transports for selective refreshable widgets
Theme support for `customize-selective-refresh-widgets` can be added _after_ the logic for registering the settings for incoming widgets that have been changed. This is due to themes adding the theme support in `after_setup_theme` which is also the action where `WP_Customize_Widgets::register_settings()` is called. If these both happen at priority 10, which one is called first depends on which one was added first. The other issue is that at the time that `WP_Customize_Widgets::register_settings()` is called at `after_setup_theme`, it is called before `widgets_init` and thus no widgets are yet registered. This means that any settings registered at this point will always have a `refresh` transport even if the theme supports `customize-selective-refresh-widgets`, since the `WP_Widget` instance is not visible yet to see if it supports selective refresh.

The fix: Defer `WP_Customize_Widgets::register_settings()` from `after_setup_theme` to `widgets_init` at priority 95 when the widget objects have all been registered. Also, ensure that the preview filter for `sidebars_widgets` is added before the sidebars are iterated for adding the controls.

Props westonruter.
Fixes #36389.

git-svn-id: https://develop.svn.wordpress.org/trunk@37166 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-07 20:58:56 +00:00
boonebgorges
f1c3ec9010 Use __trashed suffix rather than -%trashed% for trashed post slugs.
Percent signs are reserved characters in URIs. As such, it was impossible for
plugins to route requests to trashed posts, as happens in bbPress. The new
`__trashed` suffix should be sufficiently unique.

Also adds a test that demonstrates that the `__trashed` suffix can be
appended to slugs that contain the suffix somewhere other than the end of
the string.

Props netweb, ericlewis.
Fixes #11863.

git-svn-id: https://develop.svn.wordpress.org/trunk@37165 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-07 19:21:02 +00:00
Mark Jaquith
9deec9e723 REST API: Deliver parameters unadulterated instead of slashed.
We goofed, and parameters accessed through the REST API's methods
were slashed (inconsistently, even). This unslashes the data, so
you get the un-messed-with data that was sent.

Props joehoyle.
Fixes #36419.

git-svn-id: https://develop.svn.wordpress.org/trunk@37163 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-06 21:01:11 +00:00
John Blackbourn
6c79b715bd Role/Capability: Add create_sites and delete_sites to the list of capabilities that are checked as part of the comporehensive roles and capabilities tests.
See #32394, #36413


git-svn-id: https://develop.svn.wordpress.org/trunk@37157 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-04 22:29:55 +00:00
Aaron Jorbin
253308253b Adjust unit tests to account for change in [37144]
git-svn-id: https://develop.svn.wordpress.org/trunk@37150 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-30 19:52:14 +00:00
Konstantin Obenland
ef53a0db39 Template: Remove $size reference from get_custom_logo().
Argument was removed in [37077] in favor of `with` and `height` arguments.

Props ocean90.
Fixes #36327.



git-svn-id: https://develop.svn.wordpress.org/trunk@37135 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-30 17:19:41 +00:00
Ella Iseulde Van Dorpe
859d40bd24 Editor: wptextpattern: add back inline tests
See [37024].
See #33300.


git-svn-id: https://develop.svn.wordpress.org/trunk@37080 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-25 13:30:10 +00:00
Sergey Biryukov
0058968499 Canonical / Query: Restore the is_404() check in wp_old_slug_redirect() which was removed in [34659].
This reverts part of [34659] due to excessive canonical problems it's caused in 4.4.x.

Remove the unit tests which are no longer supported.
This also removes the `is_feed()` code to avoid confusion - only pages & embeds will be redirected.

Merges [36280] and [36281] to trunk.

Props dd32.
See #21602, #35344.

git-svn-id: https://develop.svn.wordpress.org/trunk@37075 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-23 21:53:44 +00:00
Boone Gorges
8e317daa37 Tests: Ensure that the default wp_die() handler can handle a WP_Error object.
Props dd32, utkarshpatel.
Fixes #36166.

git-svn-id: https://develop.svn.wordpress.org/trunk@37071 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-23 19:00:38 +00:00
Dominik Schilling (ocean90)
6c0a66cf49 Users: In edit_user() check for a blank password when adding a user.
Props wesleye, gitlost, adamsilverstein.
Fixes #35715.

git-svn-id: https://develop.svn.wordpress.org/trunk@37059 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-22 23:06:29 +00:00
Rachel Baker
dab5c5daa7 XMLRPC: Unit tests left off [r37043]
See #35874.

Props redsweater, rachelbaker

git-svn-id: https://develop.svn.wordpress.org/trunk@37044 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-22 15:11:06 +00:00
Weston Ruter
4569f93d3e Customize: Require opt-in for selective refresh of widgets.
* Introduces `customize-selective-refresh-widgets` theme support feature and adds to themes.
* Introduces `customize_selective_refresh` arg for `WP_Widget::$widget_options` and adds to all core widgets.
* Remove `selective_refresh` from being a component that can be removed via `customize_loaded_components` filter.
* Add `WP_Customize_Widgets::get_selective_refreshable_widgets()` and `WP_Customize_Widgets::is_widget_selective_refreshable()`.
* Fix default `selector` for `Partial` instances.
* Implement and improve Masronry sidebar refresh logic in Twenty Thirteen and Twenty Fourteen, including preservation of initial widget position after refresh.
* Re-initialize ME.js when refreshing `Twenty_Fourteen_Ephemera_Widget`.

See #27355.
Fixes #35855.


git-svn-id: https://develop.svn.wordpress.org/trunk@37040 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-21 21:58:02 +00:00
Andrew Ozz
058a2f558d Media: fix erroneously inserting a rel attribute in get_image_send_to_editor(). Reverts most of [34259] and [34260] and adds a unit test.
Props joemcgill, azaozz.
Fixes #36084.

git-svn-id: https://develop.svn.wordpress.org/trunk@37035 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-18 20:04:19 +00:00
Andrew Ozz
33947e4ba6 Responsive Images: the src of the image has to be first in the srcset, because of a bug in iOS8. Update the unit tests to reflect the changes.
Props jaspermdegroot, joemcgill, azaozz.
Fixes #35030.

git-svn-id: https://develop.svn.wordpress.org/trunk@37034 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-18 19:44:50 +00:00
Rachel Baker
da45e59bbd REST API: Add home_url to API index to avoid confusion with site_url.
Confusion abound, the API index is the generic term `url` to display the `site_url`. New `home` key will display the `home_url` in the index as well.

Fixes #35647.

git-svn-id: https://develop.svn.wordpress.org/trunk@37031 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-17 19:15:57 +00:00
Sergey Biryukov
57646fb7ba TinyMCE: Adjust textpattern tests for the changes in [37023].
See #33300.

git-svn-id: https://develop.svn.wordpress.org/trunk@37024 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-17 00:46:26 +00:00