38141 Commits

Author SHA1 Message Date
Andrew Ozz
c5387f14f6 Privacy: add wp_page_for_privacy_policy to populate_options().
Props ocean90.
Merges [43267] to the 4.9 branch.
Fixes #44076.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43268 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-14 17:01:02 +00:00
Andrew Ozz
eb02a647b8 Privacy: fix markup for the table of contents on privacy policy guide screen.
Props ocean90, azaozz.
Merges [43265] to the 4.9 branch.
Fixes #44056.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43266 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-14 16:47:37 +00:00
Andrew Ozz
13659fd67c Privacy: fix the "Privacy Policy Guide updated" message and add a link to the guide.
Props birgire, azaozz.
Merges [43263] to the 4.9 branch.
Fixes #44057.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43264 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-14 16:24:08 +00:00
Dominik Schilling (ocean90)
86e9864482 Privacy: Remove is-dismissible class from notice when privacy info has changed.
The notice isn't dismissible as it only gets removed once you visit the privacy guide, see #44057 and #44063.

Merge of [43260] to the 4.9 branch.

See #44065.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43262 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-14 16:07:12 +00:00
Dominik Schilling (ocean90)
a7c7e72a53 Privacy: Don't show privacy feature pointer to new users.
Merge of [43259] to the 4.9 branch.

See #44062.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43260 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-14 15:52:24 +00:00
Andrew Ozz
ef181c44e3 Privacy: improve inline documentation.
Props desrosj.
Merges [43256] to the 4.9 branch.
Fixes #44075.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43257 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-14 15:11:58 +00:00
Sergey Biryukov
0b266d74dc Privacy: exclude the wrapper from the default policy content.
Props azaozz.
Merges [43242] to the 4.9 branch.
Fixes #44048.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43255 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-14 14:06:28 +00:00
Sergey Biryukov
2bf0e98f60 Privacy: fix two typos in WP_Privacy_Policy_Content::get_default_content().
Props dlh.
Merges [43249] to the 4.9 branch.
Fixes #44050.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43254 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-14 14:02:36 +00:00
Sergey Biryukov
daf584fb2c Privacy: Reposition pointer to ensure dismiss link is always visible.
r43158 introduced a new admin pointer for the privacy tools added in 4.9.6. With the previous positioning, though, sometimes the `Dismiss` link would be fixed off screen, making it impossible for the user to dismiss the pointer. This happened when there were enough extra menu items, or when the viewport height was short enough.

This commit repositions the pointer to work around that problem. One down side of this workaround is that the arrow will not always be positioned next to the `Tools` menu, where it should be. That's an acceptable compromise given the current time constraints, though. A long term solution would be to make `WP_Pointer` robust enough to handle this use case.

Props imath, audrasjb, desrosj.
Merges [43246] to the 4.9 branch.
Fixes #44045.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43253 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-14 14:00:01 +00:00
Sergey Biryukov
8fa3eaed8a Privacy: define $title and $parent_file in privacy.php. Fixes showing the proper document title.
Props ocean90.
Merges [43250] to the 4.9 branch.
Fixes #44064.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43252 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-14 13:53:25 +00:00
Ian Dunn
921e31d776 Post WordPress 4.9.6 RC 1 version bump.
git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43241 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 22:33:51 +00:00
Ian Dunn
958cc9962a WordPress 4.9.6 RC 1.
git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43240 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 22:17:21 +00:00
Sergey Biryukov
8a6f1d8078 Privacy: On Privacy Settings screen, check if any pages exist before displaying the page selector.
Props abdullahramzan, desrosj, melchoyce.
Merges [43238] to the 4.9 branch.
Fixes #43940.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43239 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 21:40:28 +00:00
Sergey Biryukov
1995d39556 Privacy: Expose erasure notification recipient to filter callbacks.
The previous `user_email` value was redundant, because it always matched `$request_data->email`. That value might be different from where the message is sent, though, if `the user_erasure_fulfillment_email_to` filter is used. If they are different, then callbacks for the `user_confirmed_action_email_content` filter may want to distinguish between the email address of the user making the request, and the email address that the confirmation notification is being sent to.

Props desrosj, iandunn.
Merges [43236] to the 4.9 branch.
See #43973.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43237 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 21:21:53 +00:00
Sergey Biryukov
d698ec7241 Privacy: Normalize file paths in wp_privacy_generate_personal_data_export_file() to make sure Windows paths don't have their backslashes stripped.
Props xkon, pmbaldha.
Merges [43234] to the 4.9 branch.
Fixes #43908.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43235 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 21:12:21 +00:00
Sergey Biryukov
d61e8ba0ed Privacy: Update request confirmation notice text for clarity.
Props desrosj, melchoyce, garrett-eclipse.
Merges [43232] to the 4.9 branch.
Fixes #43970.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43233 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 21:04:21 +00:00
Sergey Biryukov
0471434401 Privacy: Send an email notification to the user once their personal data erasure request is fulfilled.
Props desrosj, allendav, garrett-eclipse.
Merges [43230] to the 4.9 branch.
Fixes #43973.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43231 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 20:43:39 +00:00
Sergey Biryukov
32df92e14f Privacy: Avoid a PHP notice in wp_ajax_wp_privacy_erase_personal_data(), make sure $eraser_key is always defined.
Props allendav.
Merges [43228] to the 4.9 branch.
Fixes #44040.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43229 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 20:24:41 +00:00
Sergey Biryukov
b6f00e0c4c General: Skip test_is_countable_ResourceBundle() on PHP 5.3 and below.
`ResourceBundle` is only countable in PHP 5.4+, which can be considered an acceptable edge case for WordPress core purposes.

Props jrf, ayeshrajans.
Merges [43226] to the 4.9 branch.
Fixes #43583.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43227 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 20:17:00 +00:00
Andrew Ozz
7215a0f819 Privacy: Replace intrusive policy update notice with menu bubbles.
Previously, when a plugin updated its suggested privacy policy text, an admin notice was shown on all screens in the Administration Panels. That was done in order to make sure that administrators were aware of it, so that they could update their policy if needed. That was a very heavy-handed and intrusive approach, though, which leads to a poor user experience, and notice fatigue.

An alternative approach is to use bubble notifications in the menu, similar to when plugins have updates that need to be installed. That still makes it obvious that something needs the administrator's attention, but is not as distracting as a notice.

The notice will still appear on the Privacy page, though, since it is relevant to that screen, and provides an explanation of why the bubble is appearing.

Props azaozz, xkon, iandunn.
Merges [43223] to the 4.9 branch.
Fixes #43954. See #43953.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43225 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 20:07:11 +00:00
Andrew Ozz
3c71eed70a TinyMCE: switch off concatenation when a custom TinyMCE theme is used. Prevents conflict with the default theme as it loads first.
Props programmin, azaozz.
Merges [43222] to the 4.9 branch.
Fixes #43969.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43224 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 19:53:18 +00:00
Sergey Biryukov
ef2fccb0f9 General: In the is_countable() polyfill, if the provided object implements SimpleXMLElement or ResourceBundle, consider it countable.
Props ayeshrajans, jrf, desrosj.
Merges [43220] to the 4.9 branch.
Fixes #43583.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43221 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 17:58:46 +00:00
Sergey Biryukov
20c77ef6b4 Privacy: Tweak Privacy Policy page intro text for clarity.
Props macbookandrew, allendav.
Merges [43218] to the 4.9 branch.
See #43933.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43219 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 16:13:49 +00:00
Andrew Ozz
ade8d0afde Privacy: fix styling on personal data tables.
Props melchoyce, allendav.
Merges [43216] to the 4.9 branch.
Fixes #43909.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43217 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 16:03:15 +00:00
Sergey Biryukov
19a34de743 Privacy: Notify admin via email when a request is confirmed.
Previously the admin didn't have any way to know if a pending request was ready to be processed, aside from manually checking the Export/Erase pages. Sending them an email is a much more convenient option.

Props garrett-eclipse, desrosj, iandunn.
Merges [43211] to the 4.9 branch.
See #43967.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43215 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 15:55:51 +00:00
Sergey Biryukov
1421555f7b Privacy: Reposition admin pointer to avoid covering collapsed menu.
Previously the pointer overlapped the menu in order to draw attention to the fact that it applies to both the `Tools` and `Settings` menus. That caused a conflict if the menu was collapsed, though, because the icons were covered by the pointer and therefore inaccessible.

Additionally, minor tweaks were made to the text order and formatting. The order of the two sections was swapped in the title and paragraph, in order to match the order of the corresponding menu items. The spacing around headings and paragraphs was tweaked to remove extraneous whitespace.

Props littler.chicken, desrosj, ianbelanger, melchoyce.
Merges [43210] to the 4.9 branch.
Fixes #43961.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43214 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 15:53:24 +00:00
Andrew Ozz
f45dc22d51 Privacy: cleanup of the "Export Personal Data" and "Erase Personal Data" screens.
Props desrosj, xkon.
Merges [43212] to the 4.9 branch.
See #43929.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43213 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 10:02:41 +00:00
Sergey Biryukov
768e9aebc2 Privacy: Pass export request ID to wp_privacy_personal_data_export_file_created filter.
Props thomasplevy.
Merges [43208] to the 4.9 branch.
Fixes #44031.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43209 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-09 23:18:26 +00:00
Sergey Biryukov
aa9a70eb53 Privacy: Make the help hint for Privacy Policy page more translatable and accessible.
Props tobifjellner.
Merges [43206] to the 4.9 branch.
See #43980.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43207 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-09 23:13:35 +00:00
Andrew Ozz
f1515e34cf Privacy: show the privacy policy guide and suggested content on a new page instead of a postbox. Then:
- Separate the guide text form the suggested policy text.
- Add table of content for easier navigation.
- Move the content to tools.php (prevents the settings menu of being open).
- Add a link to the guide from the Privacy settings screen.

Props melchoyce, azaozz.
Merges [43184] and [43203] to the 4.9 branch.
Fixes #43980.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43204 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-09 20:59:13 +00:00
Andrew Ozz
8804648f6f Privacy: remove the help tab from Settings => Privacy until we have something helpful to say :)
Props allendav.
Merges [43201] to the 4.9 branch.
Fixes #44023.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43202 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-09 18:13:38 +00:00
Andrew Ozz
64fdd83bee Privacy: remove leftover comment after [43197].
Merges [43199] to the 4.9 branch.
See #43968.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43200 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-09 17:58:03 +00:00
Andrew Ozz
e7f241d5b9 Privacy: add request type and filter to the subject of request confirmation emails for GDPR.
Props desrosj, azaozz.
Merges [43197] to the 4.9 branch.
Fixes #43968.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43198 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-09 17:53:40 +00:00
Andrew Ozz
af90fefdc0 Privacy: increase filter priority of the User group in Personal Data Exports.
Props allendav desrosj.
Merges [43195] to the 4.9 branch.
Fixes #43966.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43196 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-09 17:12:45 +00:00
Andrew Ozz
6f527bfe2b Privacy: fix spacing on small screens for the Use This Page button in Privacy Tools.
Props PressTigers, desrosj.
Merges [43193] to the 4.9 branch.
Fixes #43852.



git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43194 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-09 16:15:36 +00:00
Sergey Biryukov
c02dc69b8f Privacy: Add id attribute to WP_Privacy_Requests_Table and WP_Privacy_Data_Export_Requests_Table rows, for consistency with other post list tables.
Props desrosj.
Merges [43191] to the 4.9 branch.
Fixes #44015.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43192 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-09 15:07:21 +00:00
Sergey Biryukov
96e90f062e Docs: Remove unused ###USERNAME### placeholder reference from user_request_action_email_content filter documentation.
Props desrosj.
Merges [43189] to the 4.9 branch.
Fixes #44016.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43190 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-09 14:38:44 +00:00
Sergey Biryukov
38fa108f0c Privacy: Mark erasure requests as completed after processing.
r42986 introduced the beginnings of an Ajax handler for processing requests to erase personal data. At the time, a method for marking requests as completed was planned, but had not yet been created. This commit introduces that mechanism, bringing the erasure process closer to completion.

Props coreymckrill, allendav.
Merges [43185] to the 4.9 branch.
Fixes #43922.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43188 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-09 14:32:41 +00:00
Sergey Biryukov
39fd607088 Privacy: Mark processed requests as completed instead of confirmed.
r43008 refactored the request flow to make several improvements, but accidentally marked `completed` requests as `confirmed`. This commit restores the intended statuses, so that the data and corresponding UI reflect reality.

Props allendav, birgire.
Merges [43183] to the 4.9 branch.
Fixes #43913.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43187 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-09 14:30:59 +00:00
Sergey Biryukov
054067c75d Privacy: Reuse existing archive filenames to maintain URLs.
Whenever an admin initiates a download or email of a personal data export, a fresh copy of the file is generated. Previously, a new filename was used each time, which could lead to situations where a URL that was emailed to a data subject is broken.

That can be avoided by reusing the same filename when building fresh archives.

Props desrosj, tz-media, allendav.
Merges [43180] to the 4.9 branch.
Fixes #43905.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43186 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-09 14:29:25 +00:00
Andrew Ozz
f6769376e6 TinyMCE: fix setting of zIndex on the dialogs.
Props subrataemfluence, azaozz.
Merges [43181] to the 4.9 branch.
Fixes #43984.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43182 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-08 20:56:42 +00:00
Sergey Biryukov
9c26acf935 Privacy: Use the terms "erase"/"erasure" instead of "remove"/"removal" for personal data.
Props allendav.
Merges [43175] to the 4.9 branch.
Fixes #43920.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43176 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-07 16:45:42 +00:00
Sergey Biryukov
497959661c Privacy: Change "Email Data" link text on "Export Personal Data" screen to "Send Export Link" for clarity.
Props birgire, ianbelanger.
Merges [43172] to the 4.9 branch.
Fixes #43964.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43173 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-05 09:22:23 +00:00
Sergey Biryukov
060892dec7 Privacy: Remove stray closing tag in WP_Privacy_Policy_Content::get_default_content(), fix typo in @return tag.
Props dlh, tobifjellner.
Merges [43170] to the 4.9 branch.
Fixes #43951.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43171 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-04 01:56:49 +00:00
Sergey Biryukov
4e93444320 Docs: Add missing duplicate hook comment for user_request_key_expiration filter.
Props birgire, desrosj.
Merges [43168] to the 4.9 branch.
Fixes #43934.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43169 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-04 01:48:52 +00:00
Sergey Biryukov
606d22c898 Customize: Correct closing tag in WP_Customize_Theme_Control::content_template().
Props itowhid06.
Merges [43166] to the 4.9 branch.
Fixes #43945.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43167 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-04 01:04:59 +00:00
Ian Dunn
9760ed6bad Post WordPress 4.9.6 Beta 1 version bump.
git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43165 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-03 21:58:34 +00:00
Ian Dunn
c6272b7196 WordPress 4.9.6 Beta 1.
git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43164 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-03 21:29:47 +00:00
Andrew Ozz
ec4aebb741 Privacy: Return before scheduling cron during install to avoid error.
r43046 introduced wp_schedule_delete_old_privacy_export_files() to schedule the wp_privacy_delete_old_export_files cron job, but it did not check to make sure it wasn't running in the context of the install process. When it did run in that context, it created a database error, because the necessary database tables don't exist at that point.

Checking the current context and returning early during the installation phase avoids that issue.

Props helen, timothyblynjacobs, iandunn.
Merges [43162] to the 4.9 branch.
Fixes #43952.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43163 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-03 21:14:43 +00:00
Andrew Ozz
bd36463305 Privacy: Redirect to newly created Privacy Policy page to improve UX.
Previously the user was shown a message that the page was created, but might not understand that they still need to visit the page and publish it. Redirecting them to the page makes it more obvious that additional steps are involved.

Props Clorith, xkon, azaozz.
Merges [43160] to the 4.9 branch.
Fixes #43926.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43161 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-03 20:09:35 +00:00