38208 Commits

Author SHA1 Message Date
Dominik Schilling (ocean90)
6ed010dc57 Branch 4.9 is now 4.9.7-alpha.
git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43298 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-17 19:56:28 +00:00
Ian Dunn
7781d02f0f Bump 4.9 branch to version 4.9.5.
git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43296 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-17 18:55:55 +00:00
Ian Dunn
08bf39bf9b Bundled Themes: Bump version numbers and update changelogs for 4.9.6 release
Also, updates POT files for Twenty Ten and Twenty Eleven.

Props earnjam, laurelfulford.
Merges [43293] to the 4.9 branch.
Fixes #43915.


git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43295 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-17 18:26:20 +00:00
Ian Dunn
91d717933a Bundled Themes: Add link to privacy policy page in footer.
If a privacy policy has been set, then a link to it will automatically be shown in the footer.

The element containing the "Proudly powered by WordPress" link was chosen for the new policy link, in order to minimize visual conflicts with custom CSS that was written before the new link existed. Unfortunately, some minor conflicts are expected and unavoidable. Adding this link is required as part of GDPR compliance, and the benefits outweigh the downsides. 

To further mitigate the conflicts, a new imprint class was added to the "Proudly powered..." link, in order to facilitate targeting each link invididually with custom styles.

This was accidentally not backported to the `4.9` branch before the beta/RC phase, but there was a consensus that it is safe to do that this late in the release cycle. 
See https://wordpress.slack.com/archives/C02RQBWTW/p1526577643000132.
See https://wordpress.slack.com/archives/C02RQBWTW/p1526580781000240.

Props xkon, laurelfulford, birgire, azaozz, iandunn.
Merges [43051] to the 4.9 branch.
See #43715.


git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43294 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-17 18:20:44 +00:00
Ian Dunn
d8fcefdd25 Post WordPress 4.9.6 RC 2 version bump.
git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43289 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-15 21:28:17 +00:00
Ian Dunn
0e87a80ff3 WordPress 4.9.6 RC 2.
git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43288 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-15 21:19:53 +00:00
Ian Dunn
b55ffd3cfa Privacy: Require manage_privacy_options to edit policy page.
A user is required to have the `manage_privacy_options` capability in order to determine which page is set as the privacy policy (the `wp_page_for_privacy_policy`). Given that, it doesn't make sense to allow users without that capability to edit or delete the page. 

A similar situation exists with the `page_for_posts` and `page_on_front` options, but Editors are allowed to edit those pages. The reason that this situation is different is because it is more likely that an administrator will want to restrict modifications to the privacy policy, than it is that they will want to allow modifications. Modifications to the policy often require specialized knowledge of local laws, and can have implications for compliance with those laws.

Props dlh, desrosj.
Merges [43286] to the 4.9 branch.
Fixes #44079.


git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43287 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-15 20:58:05 +00:00
Andrew Ozz
2750118c45 Privacy: Rename exports folder to avoid deleting other files.
Previously, personal data exports were stored in `wp-content/uploads/exports`, which is generic enough that it's likely there are existing folders with that name, either created by plugins or manually by administrators. If that folder were reused by Core, then `wp_privacy_delete_old_export_files()` would delete all of the existing files inside it, which is almost certainly not what the site owner wants or expects.

To avoid that, the folder is being renamed to include a specific reference to Core, and a more verbose description of its purpose. With those factored in, it's very unlikely that there will be any conflicts with existing folders.

The `wp_privacy_exports_dir()` and `wp_privacy_exports_url()` functions were introduced to provide a canonical source for the location, and the `wp_privacy_exports_dir` and `wp_privacy_exports_url` filters were introduced to allow plugins to customize it.

Props johnjamesjacoby, allendav.
Merges [43284] to the 4.9 branch.
Fixes #44091.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43285 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-15 20:32:01 +00:00
Andrew Ozz
5a35e11560 Privacy: use the more compatible word-break: break-all;, see [43278].
Merges [43282] to the 4.9 branch.
See #44092.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43283 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-15 20:08:29 +00:00
Andrew Ozz
621b386a3f Privacy: fix styling of the "next steps" buttons on the Export/Erase tools screens when text is long.
Props audrasjb, ianbelanger.
Merges [43278] to the 4.9 branch.
Fixes #44092.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43281 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-15 19:44:47 +00:00
Andrew Ozz
dcd3b3b088 Privacy: fix styling of the Privacy Settings buttons on mobile/small screens.
Props ianbelanger, azaozz.
Merges [43279] to the 4.9 branch.
Fixes #44093.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43280 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-15 19:42:20 +00:00
Ian Dunn
d3ec75932b Privacy: require manage_privacy_options capability for showing WP_Privacy_Policy_Content::notice().
Props ocean90.
Merges [43248] to the 4.9 branch.
Fixes #44055.


git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43277 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-15 18:03:21 +00:00
Andrew Ozz
b9f0dbc332 Privacy: Reposition log in policy link to avoid overlapping elements.
Previously, the link used absolute positioning, in order to stick it at the bottom of the page. That was done in order to create visual separation between it and the "action" links, like "Lost Your Password?"

The absolute positioning can cause conflicts in some situations, though. For example, if extra text or error notices are added above the form, then the login link would be positioned on top of other elements.

Switching to relative positioning with extra margins avoids those issues, while maintaining the visual separation between the "action" links and the privacy policy link.

Props imath, melchoyce, desrosj, xkon, iandunn.
Merges [43274] to the 4.9 branch.
Fixes #44046.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43276 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-15 16:54:55 +00:00
Sergey Biryukov
7e235713cd Privacy: only remove the "Suggested text has changed" bubble when an admin visits the Privacy Policy Guide screen.
Props azaozz.
Merges [43269] to the 4.9 branch.
Fixes #44063.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43273 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-15 15:51:07 +00:00
Sergey Biryukov
5755e77efb Privacy: automatically create a Privacy Policy page when installing WordPress.
Props fclaussen, azaozz.
Merges [42981], [42982], [43243] to the 4.9 branch.
Fixes #43491.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43272 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-15 15:29:27 +00:00
Sergey Biryukov
06b7524c79 Privacy: fix Export and Erase Personal Data list-tables on small screens.
Props ianbelanger, subrataemfluence, desrosj.
Merges [43251] to the 4.9 branch.
Fixes #44026.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43271 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-15 15:09:14 +00:00
Andrew Ozz
7dcbacc723 Privacy: Escape comment URLs in personal export file to prevent XSS.
There doesn't appear to be any way for an attacker to introduce malicious input into the URL, unless a plugin is filtering the URL to add it, but it's better to be safe than sorry.

Props birgire.
Merges [43245] to the 4.9 branch.
Fixes #44054.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43270 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-15 14:07:32 +00:00
Andrew Ozz
c5387f14f6 Privacy: add wp_page_for_privacy_policy to populate_options().
Props ocean90.
Merges [43267] to the 4.9 branch.
Fixes #44076.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43268 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-14 17:01:02 +00:00
Andrew Ozz
eb02a647b8 Privacy: fix markup for the table of contents on privacy policy guide screen.
Props ocean90, azaozz.
Merges [43265] to the 4.9 branch.
Fixes #44056.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43266 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-14 16:47:37 +00:00
Andrew Ozz
13659fd67c Privacy: fix the "Privacy Policy Guide updated" message and add a link to the guide.
Props birgire, azaozz.
Merges [43263] to the 4.9 branch.
Fixes #44057.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43264 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-14 16:24:08 +00:00
Dominik Schilling (ocean90)
86e9864482 Privacy: Remove is-dismissible class from notice when privacy info has changed.
The notice isn't dismissible as it only gets removed once you visit the privacy guide, see #44057 and #44063.

Merge of [43260] to the 4.9 branch.

See #44065.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43262 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-14 16:07:12 +00:00
Dominik Schilling (ocean90)
a7c7e72a53 Privacy: Don't show privacy feature pointer to new users.
Merge of [43259] to the 4.9 branch.

See #44062.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43260 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-14 15:52:24 +00:00
Andrew Ozz
ef181c44e3 Privacy: improve inline documentation.
Props desrosj.
Merges [43256] to the 4.9 branch.
Fixes #44075.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43257 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-14 15:11:58 +00:00
Sergey Biryukov
0b266d74dc Privacy: exclude the wrapper from the default policy content.
Props azaozz.
Merges [43242] to the 4.9 branch.
Fixes #44048.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43255 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-14 14:06:28 +00:00
Sergey Biryukov
2bf0e98f60 Privacy: fix two typos in WP_Privacy_Policy_Content::get_default_content().
Props dlh.
Merges [43249] to the 4.9 branch.
Fixes #44050.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43254 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-14 14:02:36 +00:00
Sergey Biryukov
daf584fb2c Privacy: Reposition pointer to ensure dismiss link is always visible.
r43158 introduced a new admin pointer for the privacy tools added in 4.9.6. With the previous positioning, though, sometimes the `Dismiss` link would be fixed off screen, making it impossible for the user to dismiss the pointer. This happened when there were enough extra menu items, or when the viewport height was short enough.

This commit repositions the pointer to work around that problem. One down side of this workaround is that the arrow will not always be positioned next to the `Tools` menu, where it should be. That's an acceptable compromise given the current time constraints, though. A long term solution would be to make `WP_Pointer` robust enough to handle this use case.

Props imath, audrasjb, desrosj.
Merges [43246] to the 4.9 branch.
Fixes #44045.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43253 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-14 14:00:01 +00:00
Sergey Biryukov
8fa3eaed8a Privacy: define $title and $parent_file in privacy.php. Fixes showing the proper document title.
Props ocean90.
Merges [43250] to the 4.9 branch.
Fixes #44064.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43252 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-14 13:53:25 +00:00
Ian Dunn
921e31d776 Post WordPress 4.9.6 RC 1 version bump.
git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43241 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 22:33:51 +00:00
Ian Dunn
958cc9962a WordPress 4.9.6 RC 1.
git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43240 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 22:17:21 +00:00
Sergey Biryukov
8a6f1d8078 Privacy: On Privacy Settings screen, check if any pages exist before displaying the page selector.
Props abdullahramzan, desrosj, melchoyce.
Merges [43238] to the 4.9 branch.
Fixes #43940.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43239 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 21:40:28 +00:00
Sergey Biryukov
1995d39556 Privacy: Expose erasure notification recipient to filter callbacks.
The previous `user_email` value was redundant, because it always matched `$request_data->email`. That value might be different from where the message is sent, though, if `the user_erasure_fulfillment_email_to` filter is used. If they are different, then callbacks for the `user_confirmed_action_email_content` filter may want to distinguish between the email address of the user making the request, and the email address that the confirmation notification is being sent to.

Props desrosj, iandunn.
Merges [43236] to the 4.9 branch.
See #43973.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43237 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 21:21:53 +00:00
Sergey Biryukov
d698ec7241 Privacy: Normalize file paths in wp_privacy_generate_personal_data_export_file() to make sure Windows paths don't have their backslashes stripped.
Props xkon, pmbaldha.
Merges [43234] to the 4.9 branch.
Fixes #43908.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43235 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 21:12:21 +00:00
Sergey Biryukov
d61e8ba0ed Privacy: Update request confirmation notice text for clarity.
Props desrosj, melchoyce, garrett-eclipse.
Merges [43232] to the 4.9 branch.
Fixes #43970.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43233 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 21:04:21 +00:00
Sergey Biryukov
0471434401 Privacy: Send an email notification to the user once their personal data erasure request is fulfilled.
Props desrosj, allendav, garrett-eclipse.
Merges [43230] to the 4.9 branch.
Fixes #43973.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43231 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 20:43:39 +00:00
Sergey Biryukov
32df92e14f Privacy: Avoid a PHP notice in wp_ajax_wp_privacy_erase_personal_data(), make sure $eraser_key is always defined.
Props allendav.
Merges [43228] to the 4.9 branch.
Fixes #44040.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43229 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 20:24:41 +00:00
Sergey Biryukov
b6f00e0c4c General: Skip test_is_countable_ResourceBundle() on PHP 5.3 and below.
`ResourceBundle` is only countable in PHP 5.4+, which can be considered an acceptable edge case for WordPress core purposes.

Props jrf, ayeshrajans.
Merges [43226] to the 4.9 branch.
Fixes #43583.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43227 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 20:17:00 +00:00
Andrew Ozz
7215a0f819 Privacy: Replace intrusive policy update notice with menu bubbles.
Previously, when a plugin updated its suggested privacy policy text, an admin notice was shown on all screens in the Administration Panels. That was done in order to make sure that administrators were aware of it, so that they could update their policy if needed. That was a very heavy-handed and intrusive approach, though, which leads to a poor user experience, and notice fatigue.

An alternative approach is to use bubble notifications in the menu, similar to when plugins have updates that need to be installed. That still makes it obvious that something needs the administrator's attention, but is not as distracting as a notice.

The notice will still appear on the Privacy page, though, since it is relevant to that screen, and provides an explanation of why the bubble is appearing.

Props azaozz, xkon, iandunn.
Merges [43223] to the 4.9 branch.
Fixes #43954. See #43953.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43225 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 20:07:11 +00:00
Andrew Ozz
3c71eed70a TinyMCE: switch off concatenation when a custom TinyMCE theme is used. Prevents conflict with the default theme as it loads first.
Props programmin, azaozz.
Merges [43222] to the 4.9 branch.
Fixes #43969.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43224 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 19:53:18 +00:00
Sergey Biryukov
ef2fccb0f9 General: In the is_countable() polyfill, if the provided object implements SimpleXMLElement or ResourceBundle, consider it countable.
Props ayeshrajans, jrf, desrosj.
Merges [43220] to the 4.9 branch.
Fixes #43583.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43221 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 17:58:46 +00:00
Sergey Biryukov
20c77ef6b4 Privacy: Tweak Privacy Policy page intro text for clarity.
Props macbookandrew, allendav.
Merges [43218] to the 4.9 branch.
See #43933.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43219 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 16:13:49 +00:00
Andrew Ozz
ade8d0afde Privacy: fix styling on personal data tables.
Props melchoyce, allendav.
Merges [43216] to the 4.9 branch.
Fixes #43909.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43217 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 16:03:15 +00:00
Sergey Biryukov
19a34de743 Privacy: Notify admin via email when a request is confirmed.
Previously the admin didn't have any way to know if a pending request was ready to be processed, aside from manually checking the Export/Erase pages. Sending them an email is a much more convenient option.

Props garrett-eclipse, desrosj, iandunn.
Merges [43211] to the 4.9 branch.
See #43967.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43215 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 15:55:51 +00:00
Sergey Biryukov
1421555f7b Privacy: Reposition admin pointer to avoid covering collapsed menu.
Previously the pointer overlapped the menu in order to draw attention to the fact that it applies to both the `Tools` and `Settings` menus. That caused a conflict if the menu was collapsed, though, because the icons were covered by the pointer and therefore inaccessible.

Additionally, minor tweaks were made to the text order and formatting. The order of the two sections was swapped in the title and paragraph, in order to match the order of the corresponding menu items. The spacing around headings and paragraphs was tweaked to remove extraneous whitespace.

Props littler.chicken, desrosj, ianbelanger, melchoyce.
Merges [43210] to the 4.9 branch.
Fixes #43961.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43214 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 15:53:24 +00:00
Andrew Ozz
f45dc22d51 Privacy: cleanup of the "Export Personal Data" and "Erase Personal Data" screens.
Props desrosj, xkon.
Merges [43212] to the 4.9 branch.
See #43929.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43213 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-10 10:02:41 +00:00
Sergey Biryukov
768e9aebc2 Privacy: Pass export request ID to wp_privacy_personal_data_export_file_created filter.
Props thomasplevy.
Merges [43208] to the 4.9 branch.
Fixes #44031.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43209 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-09 23:18:26 +00:00
Sergey Biryukov
aa9a70eb53 Privacy: Make the help hint for Privacy Policy page more translatable and accessible.
Props tobifjellner.
Merges [43206] to the 4.9 branch.
See #43980.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43207 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-09 23:13:35 +00:00
Andrew Ozz
f1515e34cf Privacy: show the privacy policy guide and suggested content on a new page instead of a postbox. Then:
- Separate the guide text form the suggested policy text.
- Add table of content for easier navigation.
- Move the content to tools.php (prevents the settings menu of being open).
- Add a link to the guide from the Privacy settings screen.

Props melchoyce, azaozz.
Merges [43184] and [43203] to the 4.9 branch.
Fixes #43980.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43204 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-09 20:59:13 +00:00
Andrew Ozz
8804648f6f Privacy: remove the help tab from Settings => Privacy until we have something helpful to say :)
Props allendav.
Merges [43201] to the 4.9 branch.
Fixes #44023.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43202 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-09 18:13:38 +00:00
Andrew Ozz
64fdd83bee Privacy: remove leftover comment after [43197].
Merges [43199] to the 4.9 branch.
See #43968.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43200 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-09 17:58:03 +00:00
Andrew Ozz
e7f241d5b9 Privacy: add request type and filter to the subject of request confirmation emails for GDPR.
Props desrosj, azaozz.
Merges [43197] to the 4.9 branch.
Fixes #43968.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43198 602fd350-edb4-49c9-b593-d223f7449a82
2018-05-09 17:53:40 +00:00