42979 Commits

Author SHA1 Message Date
Robert Anderson
3b2097317e Editor: Update WordPress packages for RC1
@wordpress/block-directory: 1.17.3 -> 1.17.4
@wordpress/block-library: 2.26.3 -> 2.26.4
@wordpress/edit-post: 3.25.3 -> 3.25.4

Fixes #51793.
Props isabel_brison.


git-svn-id: https://develop.svn.wordpress.org/trunk@49623 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 04:11:04 +00:00
Peter Wilson
64ad8eb332 Permalinks: Prevent attachment pages 404ing following [49563].
This largely reverts [49563] due to attachment pages returning 404: File not found errors when they use the `inherit` status.

Permalink changes to attachment pages are retained when they are descendants of trashed or deleted posts.

Props Toro_Unit, helen, johnbillion, peterwilsoncc.
Fixes #51776.
See #5272.



git-svn-id: https://develop.svn.wordpress.org/trunk@49622 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 03:27:07 +00:00
Jonathan Desrosiers
828ee6c1ed Code Modernization: Only call libxml_disable_entity_loader() in PHP < 8.
This function has been deprecated in PHP 8.0 because in libxml 2.9.0, external entity loading is disabled by default, so this function is no longer needed to protect against XXE attacks.

This change fixes an instance of `libxml_disable_entity_loader()` within the getID3 library that has not yet been included in a tagged release for the library.

Props jrf, hellofromtonya.
Fixes #50898.

git-svn-id: https://develop.svn.wordpress.org/trunk@49621 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 00:58:33 +00:00
Helen Hou-Sandi
4fcdd01f33 Embeds: Document $args in wp_oembed_get().
Props hellofromTonya, audrasjb, SergeyBiryukov.
Fixes #51269.


git-svn-id: https://develop.svn.wordpress.org/trunk@49620 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 23:11:21 +00:00
Jake Spurlock
4b8faba8db Feeds: Add an early exit when calling RSS functions directly.
While this file is depracated, it shouldn't throw errors when called directly.

Fixes #35835.

Props thib3113, dd32, TheGP, flymike, zodiac1978, williampatton.


git-svn-id: https://develop.svn.wordpress.org/trunk@49619 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 22:50:03 +00:00
Jake Spurlock
737867e4ea Build/Test Tools: Update several NPM dependencies.
These updates were applied by running `npm i`. These are changing some `http` links to `https`.

See #50769.


git-svn-id: https://develop.svn.wordpress.org/trunk@49618 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 22:45:08 +00:00
Timothy Jacobs
ba8de96fc6 App Passwords: Unify availability language.
Previously App Passwords used a mix of "enabled" and "available". We've now standardized on using "available".

Additionally, we now use a 501 status code when indicating that App Passwords is not available.

Props SergeyBiryukov, ocean90, TimothyBlynJacobs.
Fixes #51513.


git-svn-id: https://develop.svn.wordpress.org/trunk@49617 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 22:40:11 +00:00
Helen Hou-Sandi
56ffe940b0 Multisite: More consistency for clean_dirsize_cache().
Props SergeyBiryukov.
Fixes #19879.


git-svn-id: https://develop.svn.wordpress.org/trunk@49616 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 22:29:42 +00:00
Sergey Biryukov
740d99daf4 Script Loader: Correct version for jQuery Migrate.
Follow-up to [49338].

See #51621, #50564.

git-svn-id: https://develop.svn.wordpress.org/trunk@49615 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 21:34:56 +00:00
Helen Hou-Sandi
117de3b2cd Posts, Post Types: Go back to "Auto Draft" for CPTs without title support.
Reverts [49288] due to late point in 5.6 cycle and lack of update in Gutenberg package to account for the string change.
See #45516.


git-svn-id: https://develop.svn.wordpress.org/trunk@49614 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 19:42:32 +00:00
Helen Hou-Sandi
271702cd27 Media: Avoid fatal error in `wp_prepare_attachment_for_js().
In certain contexts, in particular on the front-end, `get_media_states()` is not availble.

Props rebasaurus.
Fixes #51791.


git-svn-id: https://develop.svn.wordpress.org/trunk@49613 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 19:18:51 +00:00
Sergey Biryukov
2c7b5c37db Docs: Fix typo in wp_get_object_terms filter DocBlock.
Follow-up to [49597].

See #50768.

git-svn-id: https://develop.svn.wordpress.org/trunk@49612 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 17:26:42 +00:00
Sergey Biryukov
10208c1e35 Docs: Add missing full stop for a comment in create_initial_rest_routes().
Follow-up to [49154].

Props david.binda.
Fixes #51788.

git-svn-id: https://develop.svn.wordpress.org/trunk@49611 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 16:46:27 +00:00
John Blackbourn
10deb31dd6 Docs: Corrections and improvements to inline docs relating to the REST API.
See #50768


git-svn-id: https://develop.svn.wordpress.org/trunk@49610 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 11:02:32 +00:00
Sergey Biryukov
568e208e67 Docs: Drop src/ from pre_render_block duplicate hook reference.
Follow-up to [49608].

See #51612.

git-svn-id: https://develop.svn.wordpress.org/trunk@49609 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 10:51:19 +00:00
Robert Anderson
7a42314c8b Editor: Move pre_render_block, render_block_data, render_block_context
Move the pre_render_block, render_block_data, and render_block_context
filters from render_block() to WP_Block. This ensures that they are
called for all blocks, including nested blocks, not just top-level
blocks.

Fixes #51612.
Props gaambo, gziolo, TimothyBlynJacobs.


git-svn-id: https://develop.svn.wordpress.org/trunk@49608 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 00:45:55 +00:00
Timothy Jacobs
2425a11255 App Passwords: Include authorization rewrite rule in default multisite .htaccess
This rule was previously added to `WP_Rewrite`, but multisite uses a different .htaccess generation mechanism.

Props pbiron.
Fixes #51772.
See [49109].


git-svn-id: https://develop.svn.wordpress.org/trunk@49607 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-15 17:44:56 +00:00
John Blackbourn
82e44bc702 Build/Test Tools: Misc test enhancements.
See #51344


git-svn-id: https://develop.svn.wordpress.org/trunk@49606 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-15 17:17:55 +00:00
John Blackbourn
cd9ed5e3ad Built/Test Tools: Switch to a data provider for the default user role and capability tests.
This test previously performed 1,010 assertions, and a failure in any one would prevent the other assertions from running. Using a data provider means simultaneous failures will all be reported at once.

See #51344, #32394


git-svn-id: https://develop.svn.wordpress.org/trunk@49605 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-15 14:57:39 +00:00
John Blackbourn
ea852af151 Build/Test Tools: Ensure user capability assertions are performed for all default roles.
The existing assertions were erroneously placed outside the iteration of all users, and therefore were only run against the last user in the list, which is the Subscriber role.

See #51344, #32394


git-svn-id: https://develop.svn.wordpress.org/trunk@49604 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-15 14:17:31 +00:00
John Blackbourn
e8435082d6 Build/Test Tools: Standardise the name, signature, and usage of the wpSetUpBeforeClass() method that's used in test classes.
This brings consistency to this often-used method, and allows IDEs to provide help to developers when using its `$factory` parameter.

See #51344


git-svn-id: https://develop.svn.wordpress.org/trunk@49603 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-15 13:59:32 +00:00
Sergey Biryukov
9b97ec4c7d Twenty Nineteen: Remove unnecessary references to some variables in twentynineteen_hsl_hex() before they are defined.
Props ankitmaru, sabernhardt.
Fixes #49052.

git-svn-id: https://develop.svn.wordpress.org/trunk@49602 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-15 12:14:45 +00:00
John Blackbourn
5f257b4931 Build/Test Tools: Improve the reliability of the test that ensures correct dependency order when inline scripts are used.
This test already ensures `WP_Scripts->do_concat` is true, therefore it has no dependency on `SCRIPT_DEBUG` being false. This means the test can run in an environment where the `.min` suffix is not used.

This change allows for the test to pass in this situation.

See #36392, #51734, #51344


git-svn-id: https://develop.svn.wordpress.org/trunk@49601 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-14 17:20:57 +00:00
John Blackbourn
356f5664a7 Docs: For clarity, add some information about the return types of get_option().
Props ReneHermi, johannadevos

See #51278


git-svn-id: https://develop.svn.wordpress.org/trunk@49600 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-14 17:00:31 +00:00
Sergey Biryukov
c375590c0e Docs: Add missing descriptions for _WP_List_Table_Compat methods.
Props johannadevos, SaeedFard, swissspidy, desrosj, SergeyBiryukov.
Fixes #46842.

git-svn-id: https://develop.svn.wordpress.org/trunk@49599 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-14 16:52:25 +00:00
John Blackbourn
fca21076e0 Docs: Revert an accidental revert of this package name.
See #51414, #50768


git-svn-id: https://develop.svn.wordpress.org/trunk@49598 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-14 16:38:23 +00:00
John Blackbourn
c19f56747f Docs: Various docblock corrections and improvements.
See #50768


git-svn-id: https://develop.svn.wordpress.org/trunk@49597 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-14 16:33:52 +00:00
Sergey Biryukov
36f47ff751 Docs: Add missing descriptions for Automatic_Upgrader_Skin methods.
Props johannadevos, dilipbheda.
Fixes #44546.

git-svn-id: https://develop.svn.wordpress.org/trunk@49596 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-14 16:21:19 +00:00
Sergey Biryukov
637a3e8b5d Docs: Clarify that get_pages() returns an array of pages, not an HTML list.
Props ben.meredith@gmail.com, ovenall, johannadevos.
Fixes #39049. See #51768.

git-svn-id: https://develop.svn.wordpress.org/trunk@49595 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-14 15:00:00 +00:00
John Blackbourn
4da40cd5f0 Docs: Correct the Chocolatey package name for Node in the local environment setup instructions.
Props pbearne

See #51414


git-svn-id: https://develop.svn.wordpress.org/trunk@49594 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-14 10:15:17 +00:00
Andrew Ozz
33c782abeb Upgrade/Install: Ensure the current user can update core when saving the auto-update options.
See #51742.

git-svn-id: https://develop.svn.wordpress.org/trunk@49593 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-13 16:55:48 +00:00
Sergey Biryukov
5fa6731441 Upgrade/Install: Account for the automatic_updater_disabled filter in core auto-update settings UI.
Follow-up to [49587].

Props markparnell, audrasjb.
See #51742.

git-svn-id: https://develop.svn.wordpress.org/trunk@49592 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-13 11:12:55 +00:00
Sergey Biryukov
0d27319c73 I18N: Remove HTML tags from translatable strings on WordPress Updates screen.
Follow-up to [49587].

Props fierevere.
See #51742.

git-svn-id: https://develop.svn.wordpress.org/trunk@49591 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-13 10:48:24 +00:00
Helen Hou-Sandi
3b1a27cfd1 Post-WordPress 5.6 Beta 4 bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@49590 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 23:43:40 +00:00
Helen Hou-Sandi
7f4a7ef5f7 WordPress 5.6 Beta 4, for real.
git-svn-id: https://develop.svn.wordpress.org/trunk@49589 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 23:06:31 +00:00
Helen Hou-Sandi
43a370a723 WordPress 5.6 Beta 4.
git-svn-id: https://develop.svn.wordpress.org/trunk@49588 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 23:00:38 +00:00
Helen Hou-Sandi
9fb87a2d24 Upgrade/Install: Better UI for auto-update settings on update screen.
This adds clearer messages about what your current settings mean for updates, uses a more compact link-based action instead of a checkbox to change the setting, and respects constants and filters.

Props audrasjb, karmatosed, helen, azaozz, hedgefield, marybaum.
Fixes #51742.


git-svn-id: https://develop.svn.wordpress.org/trunk@49587 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 22:35:54 +00:00
Sergey Biryukov
d6fa3df420 Customize: Exclude widget ID attributes from search.
Having search terms match the ID attributes leads to confusing results, specifically when the admin interface is set to a language other than English.

Follow-up to [27650].

Props afercia, dlh, noisysocks.
Fixes #46456.

git-svn-id: https://develop.svn.wordpress.org/trunk@49586 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 22:03:36 +00:00
Sergey Biryukov
e9e2e6fc2c Bundled Themes: Add block-patterns tag to Twenty Nineteen and Twenty Twenty.
Follow-up to [49347], [49348].

See #51098, #51099.

git-svn-id: https://develop.svn.wordpress.org/trunk@49585 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 21:54:59 +00:00
Sergey Biryukov
cb60fe2323 Bundled Themes: Introduce block patterns for Twenty Seventeen.
Props melchoyce, kjellr, onemaggie, ryelle, beafialho, bridgetwillard, poena.
Fixes #51100.

git-svn-id: https://develop.svn.wordpress.org/trunk@49584 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 21:20:21 +00:00
Sergey Biryukov
ddc94bc982 Bundled Themes: Introduce block patterns for Twenty Sixteen.
Props melchoyce, kjellr, onemaggie, ryelle, beafialho, bridgetwillard, poena, jffng.
Fixes #51101.

git-svn-id: https://develop.svn.wordpress.org/trunk@49583 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 21:12:32 +00:00
Sergey Biryukov
17f7e5fc98 Administration: Make sure auto-update counts properly update when bulk deleting plugins or themes.
Props pbiron, noisysocks, desrosj, audrasjb, hellofromTonya.
Fixes #50870.

git-svn-id: https://develop.svn.wordpress.org/trunk@49582 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 20:40:13 +00:00
Helen Hou-Sandi
f517634e28 Upgrade/Install: Enable all core autoupdates for new installs.
Likely needs more work for multisite installs.

Reference: https://make.wordpress.org/core/2020/11/10/wp5-6-auto-update-implementation-change/

Props audrasjb, azaozz.
See #51743.


git-svn-id: https://develop.svn.wordpress.org/trunk@49581 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 20:19:46 +00:00
John Blackbourn
0ad0c55a28 General: Convert wp_array_get() to a "private" function and add tests.
This function may be promoted in the future if it's deemed useful enough.

Props dd32, jorgefilipecosta, Hareesh Pillai

Fixes #51720


git-svn-id: https://develop.svn.wordpress.org/trunk@49580 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 20:18:08 +00:00
Sergey Biryukov
e0f55936d9 Editor: Update packages.
The following package versions were changed:

@wordpress/block-directory: 1.17.2 -> 1.17.3
@wordpress/block-editor: 5.1.2 -> 5.1.3
@wordpress/block-library: 2.26.2 -> 2.26.3
@wordpress/edit-post: 3.25.2 -> 3.25.3
@wordpress/editor: 9.24.2 -> 9.24.3
@wordpress/format-library: 1.25.2 -> 1.25.3
@wordpress/reusable-blocks: 1.0.2 -> 1.0.3

See https://github.com/WordPress/gutenberg/pull/26874 for the list of fixed bugs.

Props isabel_brison.
Fixes #51696.

git-svn-id: https://develop.svn.wordpress.org/trunk@49579 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 19:34:55 +00:00
Jonathan Desrosiers
4b10e110e0 Twenty Twenty-One: Use consistent casing in strings.
This converts strings using Title Case to sentence case, which is currently preferred for consistency (see discussions on #40244).

Also included is the replacement of an escaped apostrophe with `&#8217;`, which is also preferred per the Internationalization guidelines.

See #51526.

git-svn-id: https://develop.svn.wordpress.org/trunk@49578 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 19:28:35 +00:00
Jonathan Desrosiers
571d2f0061 Twenty Twenty-One: Ignore the node_modules folder in SVN.
[49576] mistakenly partially reverted [49250].

See #51526.

git-svn-id: https://develop.svn.wordpress.org/trunk@49577 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 19:05:40 +00:00
Jonathan Desrosiers
4d21077772 Twenty Twenty-One: Ignore .css.map files.
These are generated when Sass is compiled, but should never be committed.

See #51526.

git-svn-id: https://develop.svn.wordpress.org/trunk@49576 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 18:58:54 +00:00
Jonathan Desrosiers
2d2e1dd4ae Twenty Twenty-One: Convert inline ESLint comments to JSHint.
WordPress Core currently uses JSHint instead of ESlint.

See #51526.

git-svn-id: https://develop.svn.wordpress.org/trunk@49575 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 18:46:44 +00:00
Jonathan Desrosiers
db3ce8f32d Twenty Twenty-One: Merge the latest changes changes from GitHub for Beta 4.
In addition to syncing the latest changes, this change also merges the theme’s `.scss` files and other related build tool configurations required to compile the theme’s CSS.

This will allow development of the theme to continue on Trac after 5.6 is released and the GitHub repository is archived.

For a full list of changes since [], see e7d5991...aa284fd.

Props poena, luminuu kjellr, aristath, justinahinon.
See #51526.

git-svn-id: https://develop.svn.wordpress.org/trunk@49574 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 18:34:44 +00:00