mirror of
git://develop.git.wordpress.org/
synced 2025-02-07 08:04:27 +01:00
323ac54d4b
This was added to avoid creating leftover image sub-sizes in the version-controlled `DIR_TESTDATA` directory. However, this does not appear to be necessary: * `WP_Customizer_Manager::import_theme_starter_content()` already [source:tags/6.0.2/src/wp-includes/class-wp-customize-manager.php?marks=1370-1374#L1367 makes a copy of the image] before sideloading, so the test was essentially working with a copy of a copy. * The images were only used in one test out of 70 and do not need to be copied for every single test. Upon further investigation, there is also no evidence that creating these copies actually resolved the reported issue: * `WP_UnitTest_Factory_For_Attachment::create_object()` inserts an attachment, but does not create image sub-sizes. * `media_handle_sideload()` does create image sub-sizes, but the file is already in the media library by that time, and sub-sizes are created in the `uploads` directory, not in the version-controlled `DIR_TESTDATA` directory. This commit removes ~140 redundant file copying operations when running the test suite. Follow-up to [39276], [39346], [39411], [40142]. See #55652. git-svn-id: https://develop.svn.wordpress.org/trunk@54424 602fd350-edb4-49c9-b593-d223f7449a82