wordpress/tools/release/sync-gutenberg-packages.js
Bernie Reiter fbc337d7b2 Tools: Fix unresolvable conflicts computation in package sync script.
Computation of unresolvable version conflicts in the Gutenberg package
sync script had a few issues that were causing it to fail, among them
two type errors in the destructuring of function arguments.
Furthermore, de-duplication of required package versions was missing,
leading to false positives being reported, when multiple instances of
the same package all required the same version.

Props dmsnell.
Fixes #58628.

git-svn-id: https://develop.svn.wordpress.org/trunk@56035 602fd350-edb4-49c9-b593-d223f7449a82
2023-06-26 15:41:25 +00:00

228 lines
7.3 KiB
JavaScript

/* eslint-disable no-console */
/**
* External dependencies
*/
const fs = require( 'fs' );
const spawn = require( 'cross-spawn' );
const { zip, uniq, identity, groupBy } = require( 'lodash' );
/**
* Constants
*/
const WORDPRESS_PACKAGES_PREFIX = '@wordpress/';
const { getArgFromCLI } = require( `../../node_modules/@wordpress/scripts/utils` );
const distTag = getArgFromCLI( '--dist-tag' ) || 'latest';
/**
* The main function of this task.
*
* It installs any missing WordPress packages, and updates the
* mismatched dependencies versions, e.g. it would detect that Gutenberg
* updated react from 16.0.4 to 17.0.2 and install the latter.
*/
function main() {
const initialPackageJSON = readJSONFile( `package.json` );
// Install any missing WordPress packages:
const missingWordPressPackages = getMissingWordPressPackages();
if ( missingWordPressPackages.length ) {
console.log( "The following @wordpress dependencies are missing: " );
console.log( missingWordPressPackages );
console.log( "Installing via npm..." );
installPackages( missingWordPressPackages.map( name => [name, distTag] ) );
}
// Update any outdated non-WordPress packages:
const versionMismatches = getMismatchedNonWordPressDependencies();
if ( versionMismatches.length ) {
console.log( "The following dependencies are outdated: " );
console.log( versionMismatches );
console.log( "Updating via npm..." );
const requiredPackages = versionMismatches.map( ( { name, required } ) => [name, required] );
installPackages( requiredPackages );
}
const finalPackageJSON = readJSONFile( "package.json" );
outputPackageDiffReport(
getPackageVersionDiff( initialPackageJSON, finalPackageJSON ),
);
process.exit( 0 );
}
/**
* @param {string} fileName File to read.
* @return {Object} Parsed data.
*/
function readJSONFile( fileName ) {
const data = fs.readFileSync( fileName, 'utf8' );
return JSON.parse( data );
}
/**
* Spawns npm install --save.
*
* @param {Array} packages List of tuples [packageName, version] to install.
* @return {string} CLI output.
*/
function installPackages( packages ) {
const packagesWithVersion = packages.map(
( [packageName, version] ) => `${ packageName }@${ version }`,
);
return spawn.sync( 'npm', ['install', ...packagesWithVersion, '--save'], {
stdio: 'inherit',
} );
}
/**
* Computes which @wordpress packages are required by the Gutenberg
* dependencies that are missing from WordPress package.json.
*
* @return {Array} List of tuples [packageName, version].
*/
function getMissingWordPressPackages() {
const perPackageDeps = getPerPackageDeps();
const currentPackages = perPackageDeps.map( ( [name] ) => name );
const requiredWpPackages = uniq( perPackageDeps
// Capture the @wordpress dependencies of our dependencies into a flat list.
.flatMap( ( [, dependencies] ) => getWordPressPackages( { dependencies } ) )
.sort(),
);
return requiredWpPackages.filter(
packageName => !currentPackages.includes( packageName ) );
}
/**
* Computes which third party packages are required by the @wordpress
* packages, but not by the WordPress repo itself. This includes
* both packages that are missing from package.json and any version
* mismatches.
*
* @return {Array} List of objects {name, required, actual} describing version mismatches.
*/
function getMismatchedNonWordPressDependencies() {
// Get the installed dependencies from package-lock.json
const currentPackageJSON = readJSONFile( "package.json" );
const currentPackages = getWordPressPackages( currentPackageJSON );
const packageLock = readJSONFile( "package-lock.json" );
const versionConflicts = Object.entries( packageLock.dependencies )
.filter( ( [packageName] ) => currentPackages.includes( packageName ) )
.flatMap( ( [, { dependencies }] ) => Object.entries( dependencies || {} ) )
.filter( identity )
.map( ( [name, { version }] ) => ( {
name,
required: version,
actual: packageLock.dependencies[ name ].version,
} ) )
.filter( ( { required, actual } ) => required !== actual )
;
// Ensure that all the conflicts can be resolved with the same version
const unresolvableConflicts = Object.entries( groupBy( versionConflicts, ( {name} ) => name ) )
.map( ( [name, group] ) => [name, uniq( group.map( ( { required } ) => required ) )] )
.filter( ( [, group] ) => group.length > 1 );
if ( unresolvableConflicts.length > 0 ) {
console.error( "Can't resolve some conflicts automatically." );
console.error( "Multiple required versions of the following packages were detected:" );
console.error( unresolvableConflicts );
process.exit( 1 );
}
return versionConflicts;
}
/**
* Returns a list of dependencies of each @wordpress dependency.
*
* @return {Object} An object of shape {packageName: [[packageName, version]]}.
*/
function getPerPackageDeps() {
// Get the dependencies currently listed in the wordpress-develop package.json
const currentPackageJSON = readJSONFile( "package.json" );
const currentPackages = getWordPressPackages( currentPackageJSON );
// Get the dependencies that the above dependencies list in their package.json.
const deps = currentPackages
.map( ( packageName ) => `node_modules/${ packageName }/package.json` )
.map( ( jsonPath ) => readJSONFile( jsonPath ).dependencies );
return zip( currentPackages, deps );
}
/**
* Takes unserialized package.json data and returns a list of @wordpress dependencies.
*
* @param {Object} dependencies unserialized package.json data.
* @return {string[]} a list of @wordpress dependencies.
*/
function getWordPressPackages( { dependencies = {} } ) {
return Object.keys( dependencies )
.filter( isWordPressPackage );
}
/**
* Returns true if packageName represents a @wordpress package.
*
* @param {string} packageName Package name to test.
* @return {boolean} Is it a @wodpress package?
*/
function isWordPressPackage( packageName ) {
return packageName.startsWith( WORDPRESS_PACKAGES_PREFIX );
}
/**
* Computes the dependencies difference between two unserialized
* package JSON objects. Needed only for the final reporting.
*
* @param {Object} initialPackageJSON Initial package JSON data.
* @param {Object} finalPackageJSON Final package JSON data.
* @return {Object} Delta.
*/
function getPackageVersionDiff( initialPackageJSON, finalPackageJSON ) {
const diff = ['dependencies', 'devDependencies'].reduce(
( result, keyPackageJSON ) => {
return Object.keys(
finalPackageJSON[ keyPackageJSON ] || {},
).reduce( ( _result, dependency ) => {
const initial =
initialPackageJSON[ keyPackageJSON ][ dependency ];
const final = finalPackageJSON[ keyPackageJSON ][ dependency ];
if ( initial !== final ) {
_result.push( { dependency, initial, final } );
}
return _result;
}, result );
},
[],
);
return diff.sort( ( a, b ) => a.dependency.localeCompare( b.dependency ) );
}
/**
* Prints the delta between two package.json files.
*
* @param {Object} packageDiff Delta.
*/
function outputPackageDiffReport( packageDiff ) {
const readableDiff =
packageDiff
.map( ( { dependency, initial, final } ) => {
return `${ dependency }: ${ initial } -> ${ final }`;
} )
.filter( identity );
if ( !readableDiff.length ) {
console.log( 'No changes detected' );
return;
}
console.log(
[
'The following package versions were changed:',
...readableDiff,
].join( '\n' ),
);
}
main();
/* eslint-enable no-console */