openscad/BOSL2
1
0
Fork 0
mirror of https://github.com/revarbat/BOSL2.git synced 2025-08-28 22:09:56 +02:00
Code Issues Projects Releases Wiki Activity

fix for offset_sweep using private option to offset()

Browse Source
This commit is contained in:
Adrian Mariano
2025-08-24 14:56:45 -04:00
parent 14a0430fef
commit 11cbb84b61
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
regions.scad
View File

@@ -1016,7 +1016,7 @@ function offset(
path, r=undef, delta=undef, chamfer=false, path, r=undef, delta=undef, chamfer=false,
closed=true, check_valid=true, closed=true, check_valid=true,
quality=1, error=true, return_faces=false, firstface_index=0, quality=1, error=true, return_faces=false, firstface_index=0,
flip_faces=false, same_length=false flip_faces=false, same_length=false, _reduce_output_count=false
) = ) =
assert(!(same_length && return_faces), "\nCannot combine return_faces with same_length.") assert(!(same_length && return_faces), "\nCannot combine return_faces with same_length.")
is_region(path)? is_region(path)?
@@ -1097,7 +1097,7 @@ function offset(
goodsegs[i][0]-goodpath[i])) goodsegs[i][0]-goodpath[i]))
assert(!outsidecorner[i] || vang!=0, // If outsidecorner[i] is true then vang>0 needed to give valid step count assert(!outsidecorner[i] || vang!=0, // If outsidecorner[i] is true then vang>0 needed to give valid step count
"\nOffset computation failed, probably because validity check mistakenly removed a valid segment. Increasing quality might fix this.") "\nOffset computation failed, probably because validity check mistakenly removed a valid segment. Increasing quality might fix this.")
1+segs(r,vang) segs(r,vang)+(_reduce_output_count ? 0 : 1)
], ],
// newcorners is a list where each entry is a list of the points that correspond to a single point in the sharpcorners // newcorners is a list where each entry is a list of the points that correspond to a single point in the sharpcorners
// list: newcorners[i] is the point list that replaces goodpath[i]. Without rounding or chamfering (or reversals), // list: newcorners[i] is the point list that replaces goodpath[i]. Without rounding or chamfering (or reversals),

2
rounding.scad
View File

@@ -1679,7 +1679,7 @@ function _make_offset_polyhedron(path,offsets, offset_type, flip_faces, quality,
check_valid=check_valid, quality=quality, check_valid=check_valid, quality=quality,
return_faces=true, return_faces=true,
firstface_index=vertexcount, firstface_index=vertexcount,
flip_faces=flip_faces flip_faces=flip_faces, _reduce_output_count=true
) )
) )
_make_offset_polyhedron( _make_offset_polyhedron(