From 1363a8d44da793b9dcdaf1a5363688ebca0e145d Mon Sep 17 00:00:00 2001 From: Alex Matulich Date: Sat, 3 May 2025 19:18:24 -0700 Subject: [PATCH] Address regression error --- geometry.scad | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/geometry.scad b/geometry.scad index 54dff46a..388313c6 100644 --- a/geometry.scad +++ b/geometry.scad @@ -434,12 +434,12 @@ function _line_greatest_distance(points,line) = // internal function max(d); function line_from_points(points, check_collinear=false, eps=EPSILON) = - assert( is_path(points,dim=3), "\nImproper 3d point list." ) + assert( is_path(points), "\nInvalid point list." ) assert( is_finite(eps) && (eps>=0), "\nThe tolerance should be a non-negative value." ) len(points) == 2 ? points : let( - covmix = _covariance_evec_eval(points,0), // pass 0 to use largest eigenvalue + covmix = _covariance_evec_eval(path3d(points), 0), // pass 0 to use largest eigenvalue pm = covmix[0], // point mean evec = unit(covmix[1]), // normalized eigenvector corresponding to largest eigenvalue maxext = let(b=pointlist_bounds(points)) norm(b[1]-b[0])/2,