openscad/BOSL2
1
0
Fork 0
mirror of https://github.com/revarbat/BOSL2.git synced 2025-01-17 06:08:32 +01:00
Code Issues Projects Releases Wiki Activity

Merge pull request #21 from ether42/master

Browse Source 
Fix non isosceles triangle case for right_triangle with ORIENT_Z
This commit is contained in:
Revar Desmera 2019-05-18 16:50:33 -07:00 committed by GitHub
commit 339ef3fbd8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
shapes.scad
View File

@ -343,29 +343,23 @@ module right_triangle(size=[1, 1, 1], orient=ORIENT_Y, anchor=ALLNEG, center=und
if (orient == ORIENT_X) { if (orient == ORIENT_X) {
ang = atan2(size.y, size.z); ang = atan2(size.y, size.z);
masksize = [size.x, size.y, norm([size.y,size.z])] + [1,1,1]; masksize = [size.x, size.y, norm([size.y,size.z])] + [1,1,1];
xrot(ang) { difference() {
difference() { cube(size, center=true);
xrot(-ang) cube(size, center=true); xrot(ang) back(masksize.y/2) cube(masksize, center=true);
back(masksize.y/2) cube(masksize, center=true);
}
} }
} else if (orient == ORIENT_Y) { } else if (orient == ORIENT_Y) {
ang = atan2(size.x, size.z); ang = atan2(size.x, size.z);
masksize = [size.x, size.y, norm([size.x,size.z])] + [1,1,1]; masksize = [size.x, size.y, norm([size.x,size.z])] + [1,1,1];
yrot(-ang) { difference() {
difference() { cube(size, center=true);
yrot(ang) cube(size, center=true); yrot(-ang) right(masksize.x/2) cube(masksize, center=true);
right(masksize.x/2) cube(masksize, center=true);
}
} }
} else if (orient == ORIENT_Z) { } else if (orient == ORIENT_Z) {
ang = atan2(size.x, size.y); ang = atan2(size.x, size.y);
masksize = [norm([size.x,size.y]), size.y, size.z] + [1,1,1]; masksize = [size.y, norm([size.x,size.y]), size.z] + [1,1,1];
zrot(-ang) { difference() {
difference() { cube(size, center=true);
zrot(ang) cube(size, center=true); zrot(ang) right(masksize.x/2) cube(masksize, center=true);
back(masksize.y/2) cube(masksize, center=true);
}
} }
} }
children(); children();