openscad/BOSL2
1
0
Fork 0
mirror of https://github.com/revarbat/BOSL2.git synced 2025-08-29 16:59:49 +02:00
Code Issues Projects Releases Wiki Activity

adjust regression test for new best-fit line result

Browse Source
This commit is contained in:
Alex Matulich
2025-05-04 00:13:44 -07:00
parent d4761cb501
commit 3937270fc2
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
geometry.scad
View File

@@ -430,7 +430,8 @@ function line_closest_point(line, pt, bounded=false) =
// %move_copies(points) sphere(d=2, $fn=12);
function _line_greatest_distance(points,line) = // internal function
let(d = [ for(p=points) point_line_distance(p, line) ])
is_undef(line) ? INF
: let(d = [ for(p=points) point_line_distance(p, line) ])
max(d);
function line_from_points(points, check_collinear=false, eps=EPSILON) =
@@ -444,10 +445,11 @@ function line_from_points(points, check_collinear=false, eps=EPSILON) =
pm = covmix[0], // point mean
evec = unit(covmix[1]), // normalized eigenvector corresponding to largest eigenvalue
maxext = let(b=pointlist_bounds(points)) norm(b[1]-b[0])/2,
line = [pm-evec*maxext, pm+evec*maxext]
line3d = [pm-evec*maxext, pm+evec*maxext],
line = twod ? path2d(line3d) : line
)
check_collinear && _line_greatest_distance(points,line)>eps ? undef :
twod ? path2d(line) : line ;
check_collinear && _line_greatest_distance(points,line)>eps ? undef
: line;