openscad/BOSL2
1
0
Fork 0
mirror of https://github.com/revarbat/BOSL2.git synced 2025-08-16 14:34:00 +02:00
Code Issues Projects Releases Wiki Activity

logic improvement, typos, error documentation

Browse Source
This commit is contained in:
Alex Matulich
2025-05-04 12:24:34 -07:00
parent bd1e173941
commit 6261d20a34
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
regions.scad
View File

@@ -865,13 +865,13 @@ function _point_dist(path,pathseg_unit,pathseg_len,pt) =
// r = offset radius. Distance to offset, rounds over corners. // r = offset radius. Distance to offset, rounds over corners.
// delta = Distance to offset with pointed corners. // delta = Distance to offset with pointed corners.
// chamfer = Chamfer corners when you specify `delta`. Default: false // chamfer = Chamfer corners when you specify `delta`. Default: false
// closed = If true, path is treated as a polygon. Default: True. // closed = If true, path is treated as a polygon. Default: true
// check_valid = Perform segment validity check. Default: True. // check_valid = Perform segment validity check. Default: true
// quality = Validity check quality parameter, a small integer. Default: 1. // quality = Validity check quality parameter, a small integer. Default: 1
// error = If true, assert an error if offset path is degenerate. If false, return an empty list `[]` for a degenerate path. Default: true // error = If true, assert an error if offset path is degenerate. If false, return an empty list `[]` for a degenerate path. You must check the result yourself before passing it into another function. Default: true
// same_length = Return a path with the same length as the input. Only compatible with `delta=`. Default: false // same_length = Return a path with the same length as the input. Only compatible with `delta=`. Default: false
// return_faces = Return face list. Default: False. // return_faces = Return face list. Default: false
// firstface_index = Starting index for face list. Default: 0. // firstface_index = Starting index for face list. Default: 0
// flip_faces = Flip face direction. Default: false // flip_faces = Flip face direction. Default: false
// Example(2D,NoAxes): Offset the red star out by 10 units. // Example(2D,NoAxes): Offset the red star out by 10 units.
// star = star(5, r=100, ir=30); // star = star(5, r=100, ir=30);
@@ -1028,8 +1028,8 @@ function offset(
goodpath = bselect(path,good), goodpath = bselect(path,good),
degenerate = (len(goodsegs)-(!closed && select(good,-1)?1:0) <= 0) degenerate = (len(goodsegs)-(!closed && select(good,-1)?1:0) <= 0)
) )
degenerate && error ? assert(false, "\nOffset of path is degenerate.") assert(!(degenerate && error), "\nOffset of path is degenerate.")
: degenerate && !error ? [] // return empty path : degenerate ? [] // return empty path
: let( : let(
// Extend the shifted segments to their intersection points. For open curves the endpoints // Extend the shifted segments to their intersection points. For open curves the endpoints
// are simply the endpoints of the shifted segments. If segments are parallel then the intersection // are simply the endpoints of the shifted segments. If segments are parallel then the intersection