openscad/BOSL2
1
0
Fork 0
mirror of https://github.com/revarbat/BOSL2.git synced 2025-08-15 07:34:06 +02:00
Code Issues Projects Releases Wiki Activity

fixes

Browse Source
This commit is contained in:
Adrian Mariano
2025-03-03 20:33:35 -05:00
parent f5402b8246
commit 918579ba2b
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
shapes3d.scad
View File

@@ -2009,10 +2009,9 @@ function cyl(
sc = circum? 1/cos(180/sides) : 1, sc = circum? 1/cos(180/sides) : 1,
r1 = _r1 * sc, r1 = _r1 * sc,
r2 = _r2 * sc, r2 = _r2 * sc,
phi = atan2(l, r2-r1),
anchor = get_anchor(anchor,center,BOT,CENTER), anchor = get_anchor(anchor,center,BOT,CENTER),
extra1 = first_defined([extra1,extra,0]), extra1 = first_defined([extra1,extra,0]),
extra2 = first_defined([extra2,extra,0]), extra2 = first_defined([extra2,extra,0])
) )
assert(all_nonnegative([extra1,extra2]), "extra/extra1/extra2 must be positive") assert(all_nonnegative([extra1,extra2]), "extra/extra1/extra2 must be positive")
assert(is_finite(l), "l/h/length/height must be a finite number.") assert(is_finite(l), "l/h/length/height must be a finite number.")
@@ -2106,7 +2105,6 @@ module cyl(
sc = circum? 1/cos(180/sides) : 1; sc = circum? 1/cos(180/sides) : 1;
r1 = _r1 * sc; r1 = _r1 * sc;
r2 = _r2 * sc; r2 = _r2 * sc;
phi = atan2(l, r2-r1);
anchor = get_anchor(anchor,center,BOT,CENTER); anchor = get_anchor(anchor,center,BOT,CENTER);
skmat = down(l/2) * skew(sxz=shift.x/l, syz=shift.y/l) * up(l/2); skmat = down(l/2) * skew(sxz=shift.x/l, syz=shift.y/l) * up(l/2);
attachable(anchor,spin,orient, r1=r1, r2=r2, l=l, shift=shift) { attachable(anchor,spin,orient, r1=r1, r2=r2, l=l, shift=shift) {