From 9d267992b6d904ba57812ec1d8eb6657ecba0a07 Mon Sep 17 00:00:00 2001 From: Revar Desmera Date: Sun, 17 Dec 2023 20:13:49 -0800 Subject: [PATCH] Fix for #1329: wrong in cyl(), rotate_extrude() --- skin.scad | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/skin.scad b/skin.scad index e8b2bcd..d97e4c4 100644 --- a/skin.scad +++ b/skin.scad @@ -986,7 +986,7 @@ function rotate_sweep( style=style ) : let( - steps = ceil(segs(max_x) * angle / 360) + 1, + steps = ceil(segs(max_x) * angle / 360) + (angle<360? 1 : 0), skmat = down(min_y) * skew(sxz=shift.x/h, syz=shift.y/h) * up(min_y), transforms = [ if (angle==360) for (i=[0:1:steps-1]) skmat * rot([90,0,360-i*360/steps]), @@ -1046,7 +1046,7 @@ module rotate_sweep( spin=spin, orient=orient ) children(); } else { - steps = ceil(segs(max_x) * angle / 360) + 1; + steps = ceil(segs(max_x) * angle / 360) + (angle<360? 1 : 0); skmat = down(min_y) * skew(sxz=shift.x/h, syz=shift.y/h) * up(min_y); transforms = [ if (angle==360) for (i=[0:1:steps-1]) skmat * rot([90,0,360-i*360/steps]),