openscad/BOSL2
1
0
Fork 0
mirror of https://github.com/revarbat/BOSL2.git synced 2025-08-01 13:50:33 +02:00
Code Issues Projects Releases Wiki Activity

find_noncollinear_points() was, in fact, failing to test for collinearity.

Browse Source
This commit is contained in:
Revar Desmera
2019-10-30 17:44:03 -07:00
parent faea648e66
commit bca3ef74de
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
geometry.scad
View File

@@ -948,7 +948,7 @@ function polygon_shift_to_closest_point(path, pt) =
// Usage:
// first_noncollinear(i1, i2, points);
// Description:
// Finds the first point in `points` that is not collinear with the points indexed by `i1` and `i2`. Returns the index of the found point.
// Returns index of the first point in `points` that is not collinear with the points indexed by `i1` and `i2`.
// Arguments:
// i1 = The first point.
// i2 = The second point.
@@ -966,7 +966,11 @@ function find_noncollinear_points(points) =
let(
a = 0,
b = furthest_point(points[a], points),
c = max_index([for (p=points) norm(p-points[a])*norm(p-points[b])])
c = max_index([
for (p=points)
sin(vector_angle(points[a]-p,points[b]-p)) *
norm(p-points[a]) * norm(p-points[b])
])
) [a, b, c];