From fc45a40bd3c3b524d9edc226952482296e776831 Mon Sep 17 00:00:00 2001 From: Martin Budden Date: Wed, 31 Mar 2021 01:40:06 +0100 Subject: [PATCH 1/2] Added translated children to pulley. --- vitamins/pulley.scad | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/vitamins/pulley.scad b/vitamins/pulley.scad index fe1f293..f55d9b9 100644 --- a/vitamins/pulley.scad +++ b/vitamins/pulley.scad @@ -138,6 +138,10 @@ module pulley(type, colour = silver) { //! Draw a pulley else core(); } + + if($children) + translate_z(pulley_height(type)) + children(); } module pulley_assembly(type, colour = silver) { //! Draw a pulley with its grub screws in place From cc794cd7c3cd3e3f63d15ebbe5dabb773812ae72 Mon Sep 17 00:00:00 2001 From: Chris Palmer Date: Fri, 2 Apr 2021 19:48:35 +0100 Subject: [PATCH 2/2] Updated readme. --- readme.md | 2 +- vitamins/pulley.scad | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/readme.md b/readme.md index 96dbd5d..9e9a1ef 100644 --- a/readme.md +++ b/readme.md @@ -2699,7 +2699,7 @@ Timing belt pulleys, both toothed and plain with internal bearings for idlers. ### Modules | Module | Description | |:--- |:--- | -| `pulley(type, colour = silver)` | Draw a pulley | +| `pulley(type, colour = silver)` | Draw a pulley, any children are placed above. | | `pulley_assembly(type, colour = silver)` | Draw a pulley with its grub screws in place | ![pulleys](tests/png/pulleys.png) diff --git a/vitamins/pulley.scad b/vitamins/pulley.scad index 838b2e4..b070318 100644 --- a/vitamins/pulley.scad +++ b/vitamins/pulley.scad @@ -53,7 +53,7 @@ function pulley_extent(type) = max(pulley_flange_dia(type), pulley_hub_dia(type) T_angle = 40; GT_r = 0.555; -module pulley(type, colour = silver) { //! Draw a pulley +module pulley(type, colour = silver) { //! Draw a pulley, any children are placed above. teeth = pulley_teeth(type); od = pulley_od(type);