From 17240e79e01310e9649ff623a434985a9f0e5d8c Mon Sep 17 00:00:00 2001 From: Justin Lin Date: Wed, 10 May 2017 16:45:08 +0800 Subject: [PATCH] changed default value --- docs/lib-sphere_spiral_extrude.md | 39 ++++++++++--------------------- src/sphere_spiral_extrude.scad | 2 +- 2 files changed, 13 insertions(+), 28 deletions(-) diff --git a/docs/lib-sphere_spiral_extrude.md b/docs/lib-sphere_spiral_extrude.md index ce773a4b..44f5d17a 100644 --- a/docs/lib-sphere_spiral_extrude.md +++ b/docs/lib-sphere_spiral_extrude.md @@ -2,7 +2,7 @@ Extrudes a 2D shape along the path of a sphere spiral. -When using this module, you should use points to represent the 2D shape. You need to provide indexes of triangles, too. This module provides two prepared triangles indexes. See [polysections](https://openhome.cc/eGossip/OpenSCAD/lib-polysections.html) for details. +When using this module, you should use points to represent the 2D shape. If your 2D shape is not solid, indexes of triangles are required. See [polysections](https://openhome.cc/eGossip/OpenSCAD/lib-polysections.html) for details. Dependencies: `rotate_p`, `sphere_spiral`, `cross_sections`, `polysections`. @@ -12,7 +12,7 @@ Dependencies: `rotate_p`, `sphere_spiral`, `cross_sections`, `polysections`. - `radius` , `za_step`, `z_circles`, `begin_angle`, `end_angle`, `vt_dir`, `rt_dir` : See [sphere_spiral](https://openhome.cc/eGossip/OpenSCAD/lib-sphere_spiral.html) for details. - `twist` : The number of degrees of through which the shape is extruded. - `scale` : Scales the 2D shape by this value over the length of the extrusion. Scale can be a scalar or a vector. -- `triangles` : `"RADIAL"` (default), `"HOLLOW"`, `"TAPE"` or user-defined indexes. See [polysections](https://openhome.cc/eGossip/OpenSCAD/lib-polysections.html) for details. +- `triangles` : `"SOLID"` (default), `"HOLLOW"` or user-defined indexes. See [polysections](https://openhome.cc/eGossip/OpenSCAD/lib-polysections.html) for details. ## Examples @@ -22,41 +22,26 @@ Dependencies: `rotate_p`, `sphere_spiral`, `cross_sections`, `polysections`. include ; include ; - function shape_pentagram(r) = - [ - // shape points - [ - [0, 1], [-0.224514, 0.309017], - [-0.951057, 0.309017], [-0.363271, -0.118034], - [-0.587785, -0.809017], [0, -0.381966], - [0.587785, -0.809017], [0.363271, -0.118034], - [0.951057, 0.309017], [0.224514, 0.309017] - ] * r, - // triangles - [ - [0, 1, 9], - [2, 3, 1], - [4, 5, 3], - [6, 7, 5], - [8, 9, 7], - [1, 3, 5], - [1, 5, 7], - [1, 7, 9] - ] - ]; + function shape_pentagram(r) = + [ + [0, 1], [-0.224514, 0.309017], + [-0.951057, 0.309017], [-0.363271, -0.118034], + [-0.587785, -0.809017], [0, -0.381966], + [0.587785, -0.809017], [0.363271, -0.118034], + [0.951057, 0.309017], [0.224514, 0.309017] + ] * r; points_triangles = shape_pentagram(2); sphere_spiral_extrude( - shape_pts = points_triangles[0], + shape_pts = points_triangles, radius = 40, za_step = 2, z_circles = 20, begin_angle = 90, end_angle = 450, vt_dir = "SPI_UP", - scale = 5, - triangles = points_triangles[1] + scale = 5 ); ![sphere_spiral_extrude](images/lib-sphere_spiral_extrude-1.JPG) diff --git a/src/sphere_spiral_extrude.scad b/src/sphere_spiral_extrude.scad index 89600f23..a43e53d9 100644 --- a/src/sphere_spiral_extrude.scad +++ b/src/sphere_spiral_extrude.scad @@ -12,7 +12,7 @@ module sphere_spiral_extrude(shape_pts, radius, za_step, z_circles = 1, begin_angle = 0, end_angle = 0, vt_dir = "SPI_DOWN", rt_dir = "CT_CLK", - twist = 0, scale = 1.0, triangles = "RADIAL") { + twist = 0, scale = 1.0, triangles = "SOLID") { points_angles = sphere_spiral( radius = radius,