From 62849b537443395978ebdc41656fd1cb8588086e Mon Sep 17 00:00:00 2001 From: Justin Lin Date: Mon, 18 Apr 2022 10:36:57 +0800 Subject: [PATCH] avoid floating error --- src/shape_circle.scad | 6 +++++- src/shape_ellipse.scad | 1 - 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/shape_circle.scad b/src/shape_circle.scad index 5ee5de01..eeae9192 100644 --- a/src/shape_circle.scad +++ b/src/shape_circle.scad @@ -16,4 +16,8 @@ function shape_circle(radius, n) = step_a = 360 / _frags, end = (is_undef(n) || n > _frags) ? _frags - 1: n - 1 ) - [for(a = [0:step_a:end * step_a]) [radius * cos(a), radius * sin(a)]]; + [ + for(i = [0:end]) + let(a = i * step_a) + [radius * cos(a), radius * sin(a)] + ]; diff --git a/src/shape_ellipse.scad b/src/shape_ellipse.scad index 782e4451..92e6248a 100644 --- a/src/shape_ellipse.scad +++ b/src/shape_ellipse.scad @@ -14,7 +14,6 @@ function shape_ellipse(axes) = let( frags = __frags(axes[0]), step_a = 360 / frags, - a_end = 360 - step_a, shape_pts = [ for(i = [0:frags - 1]) let(a = i * step_a)