From 6529e5682016a6ad4a9b22d43241d17c3377b4cd Mon Sep 17 00:00:00 2001 From: Justin Lin Date: Mon, 27 Jan 2020 08:52:04 +0800 Subject: [PATCH] refactor --- .../{__comm__/__m_scaling.scad => _impl/_m_scaling_impl.scad} | 2 +- .../__m_shearing.scad => _impl/_m_shearing_impl.scad} | 2 +- src/matrix/m_scaling.scad | 4 ++-- src/matrix/m_shearing.scad | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) rename src/matrix/{__comm__/__m_scaling.scad => _impl/_m_scaling_impl.scad} (92%) rename src/matrix/{__comm__/__m_shearing.scad => _impl/_m_shearing_impl.scad} (89%) diff --git a/src/matrix/__comm__/__m_scaling.scad b/src/matrix/_impl/_m_scaling_impl.scad similarity index 92% rename from src/matrix/__comm__/__m_scaling.scad rename to src/matrix/_impl/_m_scaling_impl.scad index 886ecbb5..265b5df5 100644 --- a/src/matrix/__comm__/__m_scaling.scad +++ b/src/matrix/_impl/_m_scaling_impl.scad @@ -5,7 +5,7 @@ function __m_scaling_to_3_elems_scaling_vect(s) = function __m_scaling_to_scaling_vect(s) = is_num(s) ? [s, s, s] : __m_scaling_to_3_elems_scaling_vect(s); -function __m_scaling(s) = +function _m_scaling_impl(s) = let(v = __m_scaling_to_scaling_vect(s)) [ [v[0], 0, 0, 0], diff --git a/src/matrix/__comm__/__m_shearing.scad b/src/matrix/_impl/_m_shearing_impl.scad similarity index 89% rename from src/matrix/__comm__/__m_shearing.scad rename to src/matrix/_impl/_m_shearing_impl.scad index 91c6bf74..f4f10a2d 100644 --- a/src/matrix/__comm__/__m_shearing.scad +++ b/src/matrix/_impl/_m_shearing_impl.scad @@ -1,4 +1,4 @@ -function __m_shearing(sx, sy, sz) = +function _m_shearing_impl(sx, sy, sz) = let( sx_along_y = sx[0], sx_along_z = sx[1], diff --git a/src/matrix/m_scaling.scad b/src/matrix/m_scaling.scad index 3b66977d..e4e75277 100644 --- a/src/matrix/m_scaling.scad +++ b/src/matrix/m_scaling.scad @@ -8,6 +8,6 @@ * **/ -use ; +use ; -function m_scaling(s) = __m_scaling(s); \ No newline at end of file +function m_scaling(s) = _m_scaling_impl(s); \ No newline at end of file diff --git a/src/matrix/m_shearing.scad b/src/matrix/m_shearing.scad index 431f3c14..f6a9fe53 100644 --- a/src/matrix/m_shearing.scad +++ b/src/matrix/m_shearing.scad @@ -8,6 +8,6 @@ * **/ -use ; +use ; -function m_shearing(sx = [0, 0], sy = [0, 0], sz = [0, 0]) = __m_shearing(sx, sy, sz); \ No newline at end of file +function m_shearing(sx = [0, 0], sy = [0, 0], sz = [0, 0]) = _m_shearing_impl(sx, sy, sz); \ No newline at end of file