From 72b3bcab2e6551d0fca3344011fcc5cfeede89f7 Mon Sep 17 00:00:00 2001
From: Justin Lin <caterpillar@openhome.cc>
Date: Fri, 3 Apr 2020 17:40:27 +0800
Subject: [PATCH] refactor

---
 src/experimental/_impl/_voronoi2d_cells_impl.scad | 4 +---
 src/experimental/voronoi_cells.scad               | 3 ++-
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/experimental/_impl/_voronoi2d_cells_impl.scad b/src/experimental/_impl/_voronoi2d_cells_impl.scad
index eeb340c8..f5f504ad 100644
--- a/src/experimental/_impl/_voronoi2d_cells_impl.scad
+++ b/src/experimental/_impl/_voronoi2d_cells_impl.scad
@@ -1,4 +1,3 @@
-
 use <ptf/ptf_rotate.scad>;
 
 function _default_region_size(points) = 
@@ -8,8 +7,7 @@ function _default_region_size(points) =
     )
     max([(max(xs) -  min(xs) / 2), (max(ys) -  min(ys)) / 2]);
 
-function _cells_lt_before_intersection(shape, size, points, pt) =
-    let(half_region_size = 0.5 * size)
+function _cells_lt_before_intersection(shape, size, points, pt, half_region_size) =
     [
         for(p = points)
             if(pt != p)
diff --git a/src/experimental/voronoi_cells.scad b/src/experimental/voronoi_cells.scad
index 40015b38..cd3ea876 100644
--- a/src/experimental/voronoi_cells.scad
+++ b/src/experimental/voronoi_cells.scad
@@ -5,10 +5,11 @@ use <shape_square.scad>;
 function voronoi_cells(points) = 
     let(
         size = _default_region_size(points),
+        half_size = size * 0.5,
         shape = shape_square(size),
         regions_lt = [
             for(p = points) 
-                _cells_lt_before_intersection(shape, size, points, p)
+                _cells_lt_before_intersection(shape, size, points, p, half_size)
         ]        
     )
     [