From 7b3f27358bdc0e68a6e656f82abfff9707f8af20 Mon Sep 17 00:00:00 2001 From: Justin Lin Date: Tue, 12 Apr 2022 19:37:15 +0800 Subject: [PATCH] refactor: we don't really need angle --- src/ptf/ptf_circle.scad | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/ptf/ptf_circle.scad b/src/ptf/ptf_circle.scad index 21a66f26..5293ae15 100644 --- a/src/ptf/ptf_circle.scad +++ b/src/ptf/ptf_circle.scad @@ -12,8 +12,11 @@ function ptf_circle(size, point) = let( p_offset = -size / 2, p = point + p_offset, - n = max(abs(p.x), abs(p.y)), - r = n * 1.414, - a = atan2(p.x, p.y) + leng = norm(p) ) - [r * cos(a), r * sin(a)]; \ No newline at end of file + leng == 0 ? [0, 0] : + let( + n = max(abs(p.x), abs(p.y)), + r = n * 1.414 + ) + [p.y, p.x] * (r / leng); \ No newline at end of file