From 82e328dc56cf9b2f845a868fd2dc25284ffffd48 Mon Sep 17 00:00:00 2001 From: Justin Lin Date: Sat, 10 Jul 2021 17:19:06 +0800 Subject: [PATCH] perf improved when inner_thickness = 0 --- src/experimental/polyhedron_frame.scad | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/experimental/polyhedron_frame.scad b/src/experimental/polyhedron_frame.scad index e4da8a68..b24b92f8 100644 --- a/src/experimental/polyhedron_frame.scad +++ b/src/experimental/polyhedron_frame.scad @@ -108,12 +108,12 @@ module polyhedron_frame(points, faces, deep, outer_thickness, inner_thickness = ]; offset_face_inner_pts = [ for(face = faces) - inner_thickness == 0 ? reverse([for(i = face) inner_pts[i]]) : + inner_thickness == 0 ? [for(i = face) inner_pts[i]] : reverse(convex_offset([for(i = face) inner_pts[i]], -inner_thickness)) ]; outer = hollow_faces(face_pts, offset_face_pts); - inner = hollow_faces(face_inner_pts, offset_face_inner_pts); + inner = inner_thickness == 0 ? [[], []] : hollow_faces(face_inner_pts, offset_face_inner_pts); outer_inner_pts = concat(outer[0], inner[0]); leng_outer = len(outer[0]); @@ -123,10 +123,12 @@ module polyhedron_frame(points, faces, deep, outer_thickness, inner_thickness = ]); // offset_face_pts - offset_face_inner_pts2 = [ - for(face_pts = offset_face_inner_pts) - reverse(face_pts) - ]; + offset_face_inner_pts2 = inner_thickness == 0 ? + offset_face_inner_pts : + [ + for(face_pts = offset_face_inner_pts) + reverse(face_pts) + ]; hollow_sides = sides(offset_face_pts, offset_face_inner_pts2);