From 86d5da1e2305edeba38371ae21b900e1a40d1184 Mon Sep 17 00:00:00 2001 From: Justin Lin Date: Fri, 29 Jul 2022 08:32:43 +0800 Subject: [PATCH] remove center param --- src/experimental/great_circle_arc.scad | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/experimental/great_circle_arc.scad b/src/experimental/great_circle_arc.scad index edb9f767..6befe7dd 100644 --- a/src/experimental/great_circle_arc.scad +++ b/src/experimental/great_circle_arc.scad @@ -1,16 +1,16 @@ use <__comm__/__frags.scad> use -function great_circle_arc(p1, p2, center = [0, 0, 0]) = +function great_circle_arc(p1, p2) = let( - radius = norm(p1 - center), + radius = norm(p1), normal_vt = cross(p2, p1), a = acos(p2 * p1 / pow(radius, 2)), steps = round(a / (360 / __frags(radius))) ) steps == 0 ? [p1, p2] : let(a_step = a / steps) - [for(i = [0:steps]) ptf_rotate(p1, a_step * i, normal_vt) + center]; + [for(i = [0:steps]) ptf_rotate(p1, a_step * i, normal_vt)]; /* use