From 920b09ed07be9190672c8e73cb9831a1f89cd3c7 Mon Sep 17 00:00:00 2001
From: Justin Lin <justin.sdk@gmail.com>
Date: Sun, 1 May 2022 16:34:56 +0800
Subject: [PATCH] refactor: loop onice

---
 src/experimental/perlin_sphere.scad | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)

diff --git a/src/experimental/perlin_sphere.scad b/src/experimental/perlin_sphere.scad
index 9036be53..12a3cb70 100644
--- a/src/experimental/perlin_sphere.scad
+++ b/src/experimental/perlin_sphere.scad
@@ -1,5 +1,5 @@
 use <util/rand.scad>;
-use <noise/nz_perlin3s.scad>;
+use <noise/nz_perlin3.scad>;
 use <polyhedra/geom_icosahedron.scad>;
 
 radius = 30;
@@ -14,17 +14,11 @@ module perlin_sphere(radius, detail, amplitude, period = 1, seed = undef) {
 	points = points_faces[0];
 	faces = points_faces[1];
 
-	sd = is_undef(seed) ? rand() * 1000: seed;
-    noisy = nz_perlin3s(period * points, sd);
-
-	noisy_points = [
-		for(i = [0:len(points) - 1])
-		let(
-			p = points[i],
-			nz = noisy[i]
-		)
-		p * (radius + nz * amplitude)
-	];
+	sd = is_undef(seed) ? floor(rand(0, 256)) : seed % 256;
+    noisy_points = [
+		for(p = points) 
+		p * (radius + nz_perlin3(p.x, p.y, p.z, sd) * amplitude)
+	];    
 	
 	polyhedron(noisy_points, faces);
 }
\ No newline at end of file