From a3b9e42098f672f395c78a3c810e2687aed3a8d0 Mon Sep 17 00:00:00 2001 From: Justin Lin Date: Mon, 4 Apr 2022 10:57:55 +0800 Subject: [PATCH] use vector sub --- examples/dragon/torus_knot_dragon.scad | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/examples/dragon/torus_knot_dragon.scad b/examples/dragon/torus_knot_dragon.scad index c389cf5e..ff5d221c 100644 --- a/examples/dragon/torus_knot_dragon.scad +++ b/examples/dragon/torus_knot_dragon.scad @@ -24,13 +24,11 @@ module torus_knot_dragon() { one_segment(body_r, body_fn, one_body_scale_data); function __angy_angz(p1, p2) = - let( - dx = p2.x - p1.x, - dy = p2.y - p1.y, - dz = p2.z - p1.z, - ya = atan2(dz, sqrt(dx * dx + dy * dy)), - za = atan2(dy, dx) - ) [ya, za]; + let(v = p2 - p1) + [ + atan2(v.z, norm([v.x, v.y])), + atan2(v.y, v.x) + ]; h_angy_angz = __angy_angz(d_path[len(d_path) - 2], d_path[len(d_path) - 1]);