From a735ab0365486fdff6a18b10a7c3d1ba9b6ce0a1 Mon Sep 17 00:00:00 2001 From: Justin Lin Date: Sun, 14 Feb 2021 19:53:02 +0800 Subject: [PATCH] fix wrong phi --- docs/lib3x-spherical_coordinate.md | 2 +- src/util/spherical_coordinate.scad | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/lib3x-spherical_coordinate.md b/docs/lib3x-spherical_coordinate.md index 5a714f8e..d8860df2 100644 --- a/docs/lib3x-spherical_coordinate.md +++ b/docs/lib3x-spherical_coordinate.md @@ -16,4 +16,4 @@ Converts from Cartesian to Spherical coordinates (used in mathematics). It retur r = round(coord[0]); theta = round(coord[1]); phi = round(coord[2]); - assert([r, theta, phi] == [173, 45, 35]); \ No newline at end of file + assert([r, theta, phi] == [173, 45, 55]); \ No newline at end of file diff --git a/src/util/spherical_coordinate.scad b/src/util/spherical_coordinate.scad index a65e9e99..d69ab747 100644 --- a/src/util/spherical_coordinate.scad +++ b/src/util/spherical_coordinate.scad @@ -13,5 +13,5 @@ function spherical_coordinate(point) = [ norm(point), atan2(point[1], point[0]), - atan2(point[2], sqrt(point[0]^2 + point[1]^2)) + atan2(sqrt(point[0]^2 + point[1]^2), point[2]) ];