From e1e5ca3cdb96a5c53bcd88edef833a7525c5f591 Mon Sep 17 00:00:00 2001 From: Justin Lin Date: Tue, 9 Feb 2021 14:30:44 +0800 Subject: [PATCH] refactor --- src/spherical_coordinate.scad | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/spherical_coordinate.scad b/src/spherical_coordinate.scad index 295315d5..47608097 100644 --- a/src/spherical_coordinate.scad +++ b/src/spherical_coordinate.scad @@ -1,6 +1,7 @@ -use <__comm__/__angy_angz.scad>; - function spherical_coordinate(point) = - let(ayz = __angy_angz([0, 0, 0], point)) - // mathematics, r, theta, phi - [norm(point), ayz[1], ayz[0]]; \ No newline at end of file + // mathematics [r, theta, phi] + [ + norm(point), + atan2(point[1], point[0]), + atan2(point[2], sqrt(point[0]^2 + point[1]^2)) + ];