From f690952f1fcc9e9fbf8c5d92a1d62942f52887a3 Mon Sep 17 00:00:00 2001
From: Justin Lin <caterpillar@openhome.cc>
Date: Wed, 15 May 2019 19:12:18 +0800
Subject: [PATCH] refactor

---
 src/m_rotation.scad | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/m_rotation.scad b/src/m_rotation.scad
index 77c41c4d..5a450de9 100644
--- a/src/m_rotation.scad
+++ b/src/m_rotation.scad
@@ -68,14 +68,16 @@ function _m_zRotation(a) =
         [0, 0, 0, 1]
     ];    
 
-function _to_avect(a) =
+function _to_3_elems_vect(a) =
      let(leng = len(a))
      leng == 3 ? a : (
          leng == 2 ? [a[0], a[1], 0] :  [a[0], 0, 0]
      );
 
+function _to_ang_vect(a) = __is_float(a) ? [0, 0, a] :  _to_3_elems_vect(a);
+
 function _xyz_rotation(a) =
-    let(ang = __is_float(a) ? [0, 0, a] :  _to_avect(a))
+    let(ang = _to_ang_vect(a))
     _m_zRotation(ang[2]) * _m_yRotation(ang[1]) * _m_xRotation(ang[0]);
 
 function m_rotation(a, v) =