info/DesignPatternsPHP
1
0
Fork 0
mirror of https://github.com/DesignPatternsPHP/DesignPatternsPHP.git synced 2025-08-02 05:00:15 +02:00
Code Issues Projects Releases Wiki Activity

fix: add return types for all methods

Browse Source
This commit is contained in:
Mathieu
2024-04-18 11:25:59 +02:00
parent 3a8af1c42f
commit 0c8f10f6b5
6 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Behavioral/State/ContextOrder.php
View File

@@ -16,17 +16,17 @@ class ContextOrder
return $order;
}
public function setState(StateOrder $state)
public function setState(StateOrder $state): void
{
$this->state = $state;
}
public function proceedToNext()
public function proceedToNext(): void
{
$this->state->proceedToNext($this);
}
public function toString()
public function toString(): string
{
return $this->state->toString();
}

2
Behavioral/State/CreateOrder.php
View File

@@ -6,7 +6,7 @@ namespace DesignPatterns\Behavioral\State;
class CreateOrder implements StateOrder
{
public function proceedToNext(ContextOrder $context)
public function proceedToNext(ContextOrder $context): void
{
$context->setState(new ShippingOrder());
}

2
Behavioral/State/OrderDone.php
View File

@@ -6,7 +6,7 @@ namespace DesignPatterns\Behavioral\State;
class OrderDone implements StateOrder
{
public function proceedToNext(ContextOrder $context)
public function proceedToNext(ContextOrder $context): void
{
// there is nothing more to do
}

2
Behavioral/State/ShippingOrder.php
View File

@@ -6,7 +6,7 @@ namespace DesignPatterns\Behavioral\State;
class ShippingOrder implements StateOrder
{
public function proceedToNext(ContextOrder $context)
public function proceedToNext(ContextOrder $context): void
{
$context->setState(new OrderDone());
}

2
Behavioral/State/StateOrder.php
View File

@@ -6,7 +6,7 @@ namespace DesignPatterns\Behavioral\State;
interface StateOrder
{
public function proceedToNext(ContextOrder $context);
public function proceedToNext(ContextOrder $context): void;
public function toString(): string;
}

8
Behavioral/State/Tests/StateTest.php
View File

@@ -9,14 +9,14 @@ use PHPUnit\Framework\TestCase;
class StateTest extends TestCase
{
public function testIsCreatedWithStateCreated()
public function testIsCreatedWithStateCreated(): void
{
$orderContext = ContextOrder::create();
$this->assertSame('created', $orderContext->toString());
}
public function testCanProceedToStateShipped()
public function testCanProceedToStateShipped(): void
{
$contextOrder = ContextOrder::create();
$contextOrder->proceedToNext();
@@ -24,7 +24,7 @@ class StateTest extends TestCase
$this->assertSame('shipped', $contextOrder->toString());
}
public function testCanProceedToStateDone()
public function testCanProceedToStateDone(): void
{
$contextOrder = ContextOrder::create();
$contextOrder->proceedToNext();
@@ -33,7 +33,7 @@ class StateTest extends TestCase
$this->assertSame('done', $contextOrder->toString());
}
public function testStateDoneIsTheLastPossibleState()
public function testStateDoneIsTheLastPossibleState(): void
{
$contextOrder = ContextOrder::create();
$contextOrder->proceedToNext();