info/DesignPatternsPHP
1
0
Fork 0
mirror of https://github.com/DesignPatternsPHP/DesignPatternsPHP.git synced 2025-06-28 20:23:34 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request from FatBoyXPC/dry-datamapper

Browse Source 
DRY things up a bit
This commit is contained in:
Dominik Liebler
2016-09-21 14:47:16 +02:00
committed by GitHub
parent 8f54955452 118c37adab
commit 72c44dc754
2 changed files with 5 additions and 6 deletions
More/EAV
Value.php
Structural/DataMapper
User.php

5
More/EAV/Value.php

@ -22,8 +22,7 @@ class Value implements ValueInterface
*/
public function __construct(Attribute $attribute)
{
$attribute->addValue($this);
$this->attribute = $attribute;
$this->setAttribute($attribute);
}
/**
@ -33,7 +32,7 @@ class Value implements ValueInterface
*/
public function setAttribute(Attribute $attribute)
{
$this->attribute->removeValue($this); // Remove value from current attribute
$this->attribute && $this->attribute->removeValue($this); // Remove value from current attribute
$attribute->addValue($this); // Add value to new attribute
$this->attribute = $attribute;

6
Structural/DataMapper/User.php

@ -33,9 +33,9 @@ class User
*/
public function __construct($id = null, $username = null, $email = null)
{
$this->userId = $id;
$this->username = $username;
$this->email = $email;
$this->setUserID($id);
$this->setUsername($username);
$this->setEmail($email);
}
/**