1
0
mirror of https://github.com/jupeter/clean-code-php.git synced 2025-09-25 21:49:04 +02:00

Merge pull request #34 from peter-gribanov/unneeded_context

Don't add unneeded context
This commit is contained in:
Tomáš Votruba
2017-08-30 19:50:44 +02:00
committed by GitHub

View File

@@ -151,34 +151,36 @@ foreach ($locations as $location) {
### Don't add unneeded context
If your class/object name tells you something, don't repeat that in your
variable name.
**Bad:**
```php
$car = [
'carMake' => 'Honda',
'carModel' => 'Accord',
'carColor' => 'Blue',
];
function paintCar(&$car) {
$car['carColor'] = 'Red';
```php
class Car
{
public $carMake;
public $carModel;
public $carColor;
//...
}
```
**Good**:
```php
$car = [
'make' => 'Honda',
'model' => 'Accord',
'color' => 'Blue',
];
function paintCar(&$car) {
$car['color'] = 'Red';
```php
class Car
{
public $make;
public $model;
public $color;
//...
}
```
**[⬆ back to top](#table-of-contents)**
### Use default arguments instead of short circuiting or conditionals