info/clean-code-php
1
0
Fork 0
mirror of https://github.com/jupeter/clean-code-php.git synced 2025-09-26 05:59:04 +02:00
Code Issues Releases Wiki Activity

Merge pull request #50 from emnsen/master

Browse Source 
Duplicated fixes.
This commit is contained in:
Tomáš Votruba
2017-09-04 00:46:07 +02:00
committed by GitHub
parent 1db3e5301b c058329bff
commit a64ad7fb87
1 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
README.md
View File

@@ -528,8 +528,6 @@ var_dump($name); // ['Ryan', 'McDermott'];
**Good**: **Good**:
```php ```php
$name = 'Ryan McDermott';
function splitIntoFirstAndLastName($name) { function splitIntoFirstAndLastName($name) {
return preg_split('/ /', $name); return preg_split('/ /', $name);
} }
@@ -970,8 +968,9 @@ your codebase.
```php ```php
class UserSettings { class UserSettings {
private $user; private $user;
public function __construct($user) { public function __construct($user) {
$this->user = user; $this->user = $user;
} }
public function changeSettings($settings) { public function changeSettings($settings) {
@@ -990,8 +989,9 @@ class UserSettings {
```php ```php
class UserAuth { class UserAuth {
private $user; private $user;
public function __construct($user) { public function __construct($user) {
$this->user = user; $this->user = $user;
} }
public function verifyCredentials() { public function verifyCredentials() {
@@ -1002,6 +1002,7 @@ class UserAuth {
class UserSettings { class UserSettings {
private $user; private $user;
public function __construct($user) { public function __construct($user) {
$this->user = $user; $this->user = $user;
$this->auth = new UserAuth($user); $this->auth = new UserAuth($user);
@@ -1185,12 +1186,12 @@ class Square extends Rectangle {
} }
function renderLargeRectangles($rectangles) { function renderLargeRectangles($rectangles) {
foreach($rectangle in $rectangles) { foreach($rectangles as $rectangle) {
$rectangle->setWidth(4); $rectangle->setWidth(4);
$rectangle->setHeight(5); $rectangle->setHeight(5);
$area = $rectangle->getArea(); // BAD: Will return 25 for Square. Should be 20. $area = $rectangle->getArea(); // BAD: Will return 25 for Square. Should be 20.
$rectangle->render($area); $rectangle->render($area);
}); }
} }
$rectangles = [new Rectangle(), new Rectangle(), new Square()]; $rectangles = [new Rectangle(), new Rectangle(), new Square()];
@@ -1249,7 +1250,7 @@ class Square extends Shape {
} }
function renderLargeRectangles($rectangles) { function renderLargeRectangles($rectangles) {
foreach($rectangle in $rectangles) { foreach($rectangles as $rectangle) {
if ($rectangle instanceof Square) { if ($rectangle instanceof Square) {
$rectangle->setLength(5); $rectangle->setLength(5);
} else if ($rectangle instanceof Rectangle) { } else if ($rectangle instanceof Rectangle) {
@@ -1259,7 +1260,7 @@ function renderLargeRectangles($rectangles) {
$area = $rectangle->getArea(); $area = $rectangle->getArea();
$rectangle->render($area); $rectangle->render($area);
}); }
} }
$shapes = [new Rectangle(), new Rectangle(), new Square()]; $shapes = [new Rectangle(), new Rectangle(), new Square()];