1
0
mirror of https://github.com/jupeter/clean-code-php.git synced 2025-10-01 16:36:42 +02:00
Commit Graph

265 Commits

Author SHA1 Message Date
Tomáš Votruba
ab111641be Merge pull request #142 from mwmichael/typos
fixed some typos and inconsistencies
2018-02-26 13:46:20 +01:00
Tomáš Votruba
48af26aaef Merge pull request #143 from jopacicdev/patch-1
Wording adjustment
2018-02-26 13:45:45 +01:00
Tomáš Votruba
9a7c33a065 Merge pull request #145 from yujineeee/patch-1
add Korean translation
2018-02-26 13:43:39 +01:00
yujinee
9ae7bbf8f6 add Korean translation
I wrote the korean translation for this guide.
2018-02-26 03:24:39 +09:00
jopacicdev
e90be29ff3 Wording adjustment 2018-02-16 22:35:08 +01:00
Michael Millar
46a3882721 fixed some typos and inconsistencies 2018-01-29 22:08:34 +01:00
Tomáš Votruba
c72d41321f Merge pull request #106 from mcustiel/master
Proposal to fix issue #37
2017-12-29 22:09:44 +01:00
Tomáš Votruba
b133b4f6f3 Merge branch 'master' into master 2017-12-29 22:08:53 +01:00
Tomáš Votruba
25696c0354 Merge branch 'master' into master 2017-12-29 22:07:53 +01:00
Tomáš Votruba
77c0a5b2e4 Merge pull request #128 from ismail1432/master
yoda condition and identical comparison added
2017-12-29 22:01:36 +01:00
Tomáš Votruba
935db2c2fd Merge pull request #136 from hoseinz3/master
Fix const color miss match
2017-12-29 21:59:58 +01:00
Tomáš Votruba
0344eabeec Merge pull request #134 from DylanDelobel/master
Fix Php version for void type hinting
2017-12-29 17:03:42 +01:00
Dylan Delobel
0662992e4a Add peter-gribanov suggestion 2017-12-29 15:50:26 +01:00
hoseinz3
1b4a2a1234 Fix const color miss match 2017-12-28 12:45:20 +03:30
Dylan Delobel
d807a2454c Fix Php version for type hinting 2017-12-21 15:59:44 +01:00
Tomáš Votruba
409b5ceaf9 Merge pull request #133 from ErrOrnAmE/patch-1
Add french translation
2017-11-26 23:01:02 +01:00
Thibaud Courtoison
79eabeed6b Add french translation
I wrote the french translation for this guide
2017-11-26 17:27:05 +01:00
smaine M
588a2e130d more details about identical comparison 2017-10-23 11:42:22 +02:00
smaine M
348809d64d remove yoda condition and keep identical comparison 2017-10-23 11:12:51 +02:00
Tomáš Votruba
006f2c440f Merge pull request #127 from peter-gribanov/balance
Rename methods in BankAccount
2017-10-07 10:14:29 +02:00
smaine M
2e03a7689d yoda condition and identical comparison added 2017-10-07 09:10:54 +02:00
Peter Gribanov
27103f43ef Rename get balance method 2017-10-07 09:48:29 +03:00
Mariano Custiel
42fcf8c7a9 Made changes suggested in code review 2017-10-06 19:13:34 +02:00
Peter Gribanov
40ca2e5959 rename methods in BankAccount 2017-10-06 11:11:00 +03:00
Tomáš Votruba
2d8720c7c8 Merge pull request #125 from peter-gribanov/cityZipCodeRegex
Optimize City and ZipCode regex
2017-10-02 00:48:36 +02:00
Peter Gribanov
dc125f02c9 optimize cityZipCodeRegex 2017-09-28 17:41:05 +03:00
Peter Gribanov
0eb9d0405b zipCode is required 2017-09-28 17:39:57 +03:00
Peter Gribanov
b26983358e Merge pull request #18 from jupeter/master
Update master
2017-09-27 18:39:32 +03:00
Tomáš Votruba
3309c0909a Merge pull request #117 from yuriyzinchenko/fix_lsp
fix example in LSP section
2017-09-27 15:38:14 +02:00
Tomáš Votruba
091009e2d4 add Rectangle[] typehints 2017-09-27 15:37:44 +02:00
Tomáš Votruba
72896e053e Merge pull request #122 from ZielinskiLukasz/master
Update README.md
2017-09-27 15:36:21 +02:00
Tomáš Votruba
e9b19fc40f Merge pull request #123 from peter-gribanov/version_announce
Fix typo in announce of PHP version
2017-09-25 14:55:47 +02:00
Peter Gribanov
3239445b8c fix typo 2017-09-25 10:31:14 +03:00
ZielinskiLukasz
1cf35d42f0 Update README.md 2017-09-23 11:59:08 +02:00
Tomáš Votruba
62fc6bdb35 Merge pull request #118 from AlaaAttya/master
force type check for `in_array`
2017-09-22 21:21:22 +02:00
Tomáš Votruba
8fc58f6cc6 Merge pull request #121 from peter-gribanov/version_announce
Announce PHP version
2017-09-22 16:20:19 +02:00
Peter Gribanov
f213dfd4e5 version announce 2017-09-22 13:44:04 +03:00
Peter Gribanov
664bfe052b Merge pull request #17 from jupeter/master
Update master
2017-09-22 13:41:35 +03:00
Alaa Attya
4df90deaa9 use true for trick types. Check http://php.net/manual/en/function.in-array.php 2017-09-20 19:39:17 +02:00
Yuriy Zinchenko
b488cc2acc fix example in LSP section 2017-09-18 17:47:44 +03:00
Tomáš Votruba
998dd02b92 Merge pull request #116 from yuriyzinchenko/avoid_nesting2
Optimize conditions in 'Avoid nesting too deeply and return early (pa…
2017-09-18 14:13:13 +02:00
Tomáš Votruba
0e13574dee Merge pull request #115 from peter-gribanov/trans
Update translations
2017-09-18 13:33:52 +02:00
Yuriy Zinchenko
51b4b87821 Optimize conditions in 'Avoid nesting too deeply and return early (part 2)' section 2017-09-18 12:38:25 +03:00
Peter Gribanov
0b6ab70f45 add Spanish translation 2017-09-18 10:56:55 +03:00
Peter Gribanov
a26b56addd remove out of date chinese translations 2017-09-18 10:56:17 +03:00
Peter Gribanov
f2563f82a8 Merge pull request #15 from jupeter/master
Update master
2017-09-18 10:51:09 +03:00
Tomáš Votruba
4386410294 Merge pull request #109 from peter-gribanov/private_protected
Make objects have private/protected members
2017-09-16 05:14:16 +02:00
Peter Gribanov
0b06120c1e fix mistakes 2017-09-15 17:13:52 +03:00
Tomáš Votruba
278a45aa88 Merge pull request #113 from okj579/patch-1
Minor grammatical fixes
2017-09-15 16:05:17 +02:00
Tomáš Votruba
bc8c10da38 Merge pull request #104 from peter-gribanov/avoid_nesting
Add links to table of contents
2017-09-15 16:04:46 +02:00