- updated code to protect against null pointers and uninitialized values and threading issues

source/shared_lib/sources/platform/miniupnpc/connecthostport.c

@@ -143,7 +143,8 @@ int connecthostport(const char * host, unsigned short port,
 	hints.ai_socktype = SOCK_STREAM;
 	hints.ai_family = AF_UNSPEC; /* AF_INET, AF_INET6 or AF_UNSPEC */
 	/* hints.ai_protocol = IPPROTO_TCP; */
-	snprintf(port_str, sizeof(port_str), "%hu", port);
+	snprintf(port_str, 7, "%hu", port);
+	port_str[7] = '\0';
 	if(host[0] == '[')
 	{
 		/* literal ip v6 address */

source/shared_lib/sources/platform/posix/socket.cpp

@@ -2465,7 +2465,7 @@ int UPNP_Tools::upnp_init(void *param) {
 			}
 
 			dev = devlist;
-			while (dev) {
+			while (dev && dev->st) {
 				if (strstr(dev->st, "InternetGatewayDevice")) {
 					break;
 				}

source/shared_lib/sources/platform/win32/glob.cpp

@@ -297,6 +297,9 @@ int glob(   char const  *pattern
                 cbAlloc = new_cbAlloc;
             }
 
+			if(buffer == NULL) {
+				throw exception("buffer == NULL");
+			}
             (void)lstrcpynA(buffer + cbCurr, szRelative, 1 + (int)(file_part - effectivePattern));
             (void)lstrcatA(buffer + cbCurr, sFileName.c_str());
             cbCurr += cch + 1;