mirror/devicon
1
0
Fork 0
mirror of https://github.com/konpa/devicon.git synced 2025-04-21 05:11:56 +02:00
Code Issues Releases Wiki Activity

Fix checkbot's check version issue

Browse Source
This commit is contained in:
Thomas Bui 2022-03-22 22:13:21 -07:00
parent 7dd928a3b7
commit 29ffe6fd83
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
.github/scripts/build_assets/util.py vendored
View File

@ -75,3 +75,7 @@ valid_svg_filename_pattern = re.compile(r"-(original|plain|line)(-wordmark)?\.sv
def is_svg_name_valid(filename: str):
return valid_svg_filename_pattern.search(filename) is not None
valid_svg_version_pattern = re.compile(r"^(original|plain|line)(-wordmark)?$")
def is_svg_version_valid(version):
return valid_svg_version_pattern.search(version) is not None

4
.github/scripts/check_icon_pr.py vendored
View File

@ -82,7 +82,7 @@ def check_devicon_object(icon: dict):
err_msgs.append("- must contain at least 1 svg version in a list.")
for version in icon["versions"]["svg"]:
if not util.is_svg_name_valid(version):
if not util.is_svg_version_valid(version):
err_msgs.append(f"- Invalid version name in versions['svg']: '{version}'. Must match regexp: (original|plain|line)(-wordmark)?")
except KeyError:
err_msgs.append("- missing key: 'svg' in 'versions'.")
@ -92,7 +92,7 @@ def check_devicon_object(icon: dict):
err_msgs.append("- must contain at least 1 font version in a list.")
for version in icon["versions"]["font"]:
if not util.is_svg_name_valid(version):
if not util.is_svg_version_valid(version):
err_msgs.append(f"- Invalid version name in versions['font']: '{version}'. Must match regexp: (original|plain|line)(-wordmark)?")
except KeyError:
err_msgs.append("- missing key: 'font' in 'versions'.")