mirror of
https://github.com/konpa/devicon.git
synced 2025-08-09 16:16:57 +02:00
Merge pull request #333 from devicons/TB_bugFix
Comment Bot temporary bug fix, mocha font fix and build script update
This commit is contained in:
Clemens Bastian
GitHub
8
.github/workflows/build_icons.yml
vendored
8
.github/workflows/build_icons.yml
vendored
@@ -1,11 +1,8 @@
|
||||
name: Build Icons
|
||||
on:
|
||||
pull_request:
|
||||
types: [labeled]
|
||||
on: workflow_dispatch
|
||||
jobs:
|
||||
build:
|
||||
name: Get Fonts From Icomoon
|
||||
if: contains(github.event.pull_request.labels.*.name, 'bot:build')
|
||||
runs-on: windows-2019
|
||||
steps:
|
||||
- uses: actions/checkout@v2
|
||||
@@ -46,7 +43,8 @@ jobs:
|
||||
uses: peter-evans/create-pull-request@v3
|
||||
with:
|
||||
branch: ${{ format('build/{0}', github.head_ref) }}
|
||||
base: 'develop'
|
||||
commit-message: 'Built new icons, icomoon.json and devicon.css'
|
||||
title: 'bot:build new icons, icomoon.json and devicon.css'
|
||||
body: 'Automated font-building task ran by GitHub Actions bot'
|
||||
delete-branch: ${{true}}
|
||||
delete-branch: true
|
||||
|
||||
23
.github/workflows/peek_icons.yml
vendored
23
.github/workflows/peek_icons.yml
vendored
@@ -38,16 +38,17 @@ jobs:
|
||||
with:
|
||||
name: new_icons
|
||||
path: ./new_icons.png
|
||||
- name: Comment on the PR about the result
|
||||
uses: github-actions-up-and-running/pr-comment@v1.0.1
|
||||
with:
|
||||
repo-token: ${{ secrets.GITHUB_TOKEN }}
|
||||
message: >
|
||||
Hi! I'm Devicons' GitHub Actions Bot!
|
||||
# - name: Comment on the PR about the result
|
||||
# uses: github-actions-up-and-running/pr-comment@v1.0.1
|
||||
# with:
|
||||
# repo-token: ${{ secrets.GITHUB_TOKEN }}
|
||||
# message: >
|
||||
# Hi! I'm Devicons' GitHub Actions Bot!
|
||||
|
||||
I just peeked at the icons that you wanted to add and upload them to the
|
||||
[Actions page](https://github.com/devicons/devicon/actions). The maintainers
|
||||
will now take a look at it and decide whether to merge your PR.
|
||||
# I just peeked at the icons that you wanted to add and upload them to the
|
||||
# [Actions page](https://github.com/devicons/devicon/actions). The maintainers
|
||||
# will now take a look at it and decide whether to merge your PR.
|
||||
|
||||
Cheers :),
|
||||
Bot
|
||||
# Cheers :),
|
||||
|
||||
# Bot
|
||||
|
||||
@@ -26,9 +26,8 @@ First of all, thanks for taking the time to contribute! This project can only gr
|
||||
<li>Include the name of the icon in the pull request title. Follow this format: <code>new icon: {{logoName}} ({{versions}})</code> </li>
|
||||
<li><i>Optional</i>: Add images of the new icon(s) to the description of the pull request. This would help speed up the review process </li>
|
||||
<li><i>Optional</i>: Reference the issues regarding the new icon. </li>
|
||||
<li>Wait for a repo maintainer to review your changes. Once they are satisfied, they will <a href="#buildScript">build your repo </a>. This will create a PR into your branch.</li>
|
||||
<li>Review the PR. It should contain the icon versions of your svgs. Accept the changes if you are satisfied</li>
|
||||
<li>Once you accept the changes, a maintainer will accept your PR into the repo.</li>
|
||||
<li>Wait for a repo maintainer to review your changes. They will run a script to check your icons. </li>
|
||||
<li>If there are no issue, they will accept your PR into the repo. Else, they will let you know and give you a chance to fix it.</li>
|
||||
</ol>
|
||||
|
||||
<hr>
|
||||
@@ -64,6 +63,8 @@ Some icons are really simple (like the Apple one), so the original version can b
|
||||
</li>
|
||||
<li>Optimize/compress your SVGs. You can use a service like <a href="https://compressor.io/">compressor</a> or <a href="https://petercollingridge.appspot.com/svg-editor">SVG Editor</a>.</li>
|
||||
<li>The icon's strokes and texts must be fills. We use Icomoon to make our icon, which has its<a href="https://icomoon.io/#docs/stroke-to-fill"> requirements</a></li>
|
||||
<li>Each <code>.svg</code> file contains one version of an icon in a <code>0 0 128 128</code> viewbox</li>
|
||||
<li>The naming convention for the svg file is the following: <code>(icon name)-(original|plain|line)-(wordmark)</code></li>
|
||||
</ul>
|
||||
|
||||
<hr>
|
||||
@@ -72,8 +73,6 @@ Some icons are really simple (like the Apple one), so the original version can b
|
||||
<li>Each icon has its own folder located in the <code>icons</code> folder</li>
|
||||
<li>Each icon folder contains one <code>.eps</code> file and as many <code>.svg</code> files as versions available</li>
|
||||
<li>The <code>.eps</code> file contains all available versions of an icon. Each version is contained in a 128px by 128px artboard</li>
|
||||
<li>Each <code>.svg</code> file contains one version of an icon in a <code>0 0 128 128</code> viewbox</li>
|
||||
<li>The naming convention for the svg file is the following: <code>(icon name)-(original|plain|line)-(wordmark)</code></li>
|
||||
</ul>
|
||||
|
||||
<hr>
|
||||
@@ -158,6 +157,7 @@ As an example, let's assume you have created the svgs for Amazon Web Services an
|
||||
"font": [ // here are the versions that will be used to create icons
|
||||
"original", // original is simple enough to be used as plain
|
||||
"plain-wordmark",
|
||||
// note that the alias "plain" is not listed here. It must be listed in the `aliases` attribute
|
||||
]
|
||||
},
|
||||
"color": "#F7A80D", // note the '#' character
|
||||
@@ -232,9 +232,13 @@ As an example, let's assume you have created the svgs for Amazon Web Services an
|
||||
<hr>
|
||||
<h2 id='buildScript'>Regarding The Build Script</h2>
|
||||
<p>To make adding icons easier for repo maintainers, we rely on GitHub Actions, Python, Selenium, and Gulp to automate our tasks.</p>
|
||||
<p>So far, the tasks that we have automated are:</p>
|
||||
<p>So far, the tasks in the build script are:</p>
|
||||
<ul>
|
||||
<li>Upload svgs to <a href="https://icomoon.io/app/#/select">icomoon.io</a> and get the icons back. For details, see <a href="https://github.com/devicons/devicon/issues/252"> the original disscussion</a>, <a href="https://github.com/devicons/devicon/pull/268">this PR that introduce the feature</a> and <a href="https://github.com/devicons/devicon/issues/300">the final changes to it.</a></li>
|
||||
<li>Build, combine, and minify CSS files. For details, see <a href="https://github.com/devicons/devicon/pull/290">this</a></li>
|
||||
</ul>
|
||||
<p>There are also other tasks that we are automating, such as:</p>
|
||||
<ul>
|
||||
<li>Ensure code quality is up to standard</li>
|
||||
<li>Upload svgs to <a href="https://icomoon.io/app/#/select">icomoon.io</a> and take a screenshot for check.
|
||||
</ul>
|
||||
@@ -1 +1 @@
|
||||
<svg id="Layer_1" data-name="Layer 1" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 112 126.38"><defs><style>.cls-1{fill:#8d6748;}</style></defs><title>mocha</title><g id="plain"><polygon class="cls-1" points="91.78 58.77 89.48 64.19 94.09 64.19 91.78 58.77"/><path class="cls-1" d="M60.91,52h4a1,1,0,0,0,.54-.24C67.77,49,68.1,43.6,68.1,41.7a.7.7,0,0,0-.68-.7h-9a.68.68,0,0,0-.68.68c.07,1.9.34,7.36,2.65,10.08A.65.65,0,0,0,60.91,52Zm4.41-5.16C67,46.23,67,45.62,67,45.62a10.69,10.69,0,0,1-2,5.24.51.51,0,0,1-.41.15H61.25c-.14,0-.34,0-.41-.15a9.6,9.6,0,0,1-1.7-3.77S63.08,47.65,65.32,46.84Z" transform="translate(-8 -0.81)"/><path class="cls-1" d="M116.42,29.94,67.48,1.72a6.83,6.83,0,0,0-6.83,0L11.6,29.94A6.9,6.9,0,0,0,8,35.78V92.22a7,7,0,0,0,3.58,5.83l48.94,28.22a6.83,6.83,0,0,0,6.83,0L116.4,98.06a7.14,7.14,0,0,0,3.6-5.83V35.78A7,7,0,0,0,116.42,29.94ZM112,88.29a5.77,5.77,0,0,1-2.94,5L66.86,117.66a5.65,5.65,0,0,1-5.84,0L18.87,93.31a5.63,5.63,0,0,1-2.87-5V39.58a5.71,5.71,0,0,1,2.87-5L61,10.2a5.6,5.6,0,0,1,5.82,0l42.21,24.35a5.69,5.69,0,0,1,2.93,5Z" transform="translate(-8 -0.81)"/><circle class="cls-1" cx="40" cy="62.53" r="4.84"/><path class="cls-1" d="M108.06,36.32,65.85,12a3.87,3.87,0,0,0-1.91-.54A4.06,4.06,0,0,0,62,12L19.87,36.32A3.88,3.88,0,0,0,18,39.65V88.35a3.87,3.87,0,0,0,1.87,3.32L62,116a3.62,3.62,0,0,0,1.89.54,3.82,3.82,0,0,0,1.9-.54l42.23-24.35A3.94,3.94,0,0,0,110,88.35V39.65A3.94,3.94,0,0,0,108.06,36.32ZM67,68.19a4.8,4.8,0,0,0,3.65-1.69L72.17,68a7.7,7.7,0,0,1-1.08,1,5.9,5.9,0,0,1-1.22.75,5,5,0,0,1-1.42.47,8.33,8.33,0,0,1-1.83.14,6.72,6.72,0,0,1-4.88-2,6.1,6.1,0,0,1-1.3-2.24A7.34,7.34,0,0,1,60,63.39v-.07a7.12,7.12,0,0,1,.42-2.71,7.63,7.63,0,0,1,1.36-2.24A6.35,6.35,0,0,1,64,56.88a7.53,7.53,0,0,1,2.83-.54,13.09,13.09,0,0,1,1.69.14c.54.14.95.27,1.42.41a6.43,6.43,0,0,1,1.15.68,11.79,11.79,0,0,1,1,.88l-1.56,1.63A4.83,4.83,0,1,0,67,68.19ZM64.17,30.56c-.34.47.07,1.63.95,3a2.83,2.83,0,0,1-.95,4,3.83,3.83,0,0,0-.75-2.31C61.8,32.79,63.29,31.64,64.17,30.56Zm-2.71,2.51c-.27.27,0,1.09.61,2a1.91,1.91,0,0,1-.61,2.71A2.74,2.74,0,0,0,61,36.25C59.9,34.56,60.85,33.81,61.46,33.07ZM56.5,39H69.26a.64.64,0,0,1,.68.63C69.94,42,69.6,50,66.2,53.77a.64.64,0,0,1-.47.23H60a.67.67,0,0,1-.47-.26C56.16,49.88,55.83,42,55.83,39.66A.66.66,0,0,1,56.5,39ZM21,49H55.35s.07,0,.07,1H21ZM55,63.32v.07a7.37,7.37,0,0,1-.47,2.71,6.7,6.7,0,0,1-1.46,2.24,6.4,6.4,0,0,1-2.22,1.49,6.63,6.63,0,0,1-2.84.54,7.86,7.86,0,0,1-2.84-.54,6.47,6.47,0,0,1-2.24-1.49,6.3,6.3,0,0,1-1.41-2.24A7.16,7.16,0,0,1,41,63.39v-.07a7.43,7.43,0,0,1,.53-2.71A6.79,6.79,0,0,1,43,58.37a6.46,6.46,0,0,1,2.23-1.49,6.66,6.66,0,0,1,2.85-.54,7.88,7.88,0,0,1,2.85.54,6.48,6.48,0,0,1,2.24,1.49,6.18,6.18,0,0,1,1.35,2.24A7.14,7.14,0,0,1,55,63.32ZM29.1,67H29l-4-6.46V70H22V57h3l4.14,6.38L33.23,57H36V70H33V60.47ZM107,75H21V74h86ZM86,62V57h2V70H86V64H79v6H77V57h2v5Zm6.73,8,6-13h2.17l6,13h-2.51L103,67H96.6l-1.42,3ZM107,50H70.41c0-1,.07-1,.07-1H107Z" transform="translate(-8 -0.81)"/></g></svg>
|
||||
<svg id="Layer_1" data-name="Layer 1" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 128 128"><defs><style>.cls-1{fill:#8d6748;}</style></defs><title>mocha</title><g id="plain"><polygon class="cls-1" points="91.78 58.77 89.48 64.19 94.09 64.19 91.78 58.77"/><path class="cls-1" d="M60.91,52h4a1,1,0,0,0,.54-.24C67.77,49,68.1,43.6,68.1,41.7a.7.7,0,0,0-.68-.7h-9a.68.68,0,0,0-.68.68c.07,1.9.34,7.36,2.65,10.08A.65.65,0,0,0,60.91,52Zm4.41-5.16C67,46.23,67,45.62,67,45.62a10.69,10.69,0,0,1-2,5.24.51.51,0,0,1-.41.15H61.25c-.14,0-.34,0-.41-.15a9.6,9.6,0,0,1-1.7-3.77S63.08,47.65,65.32,46.84Z" /><path class="cls-1" d="M116.42,29.94,67.48,1.72a6.83,6.83,0,0,0-6.83,0L11.6,29.94A6.9,6.9,0,0,0,8,35.78V92.22a7,7,0,0,0,3.58,5.83l48.94,28.22a6.83,6.83,0,0,0,6.83,0L116.4,98.06a7.14,7.14,0,0,0,3.6-5.83V35.78A7,7,0,0,0,116.42,29.94ZM112,88.29a5.77,5.77,0,0,1-2.94,5L66.86,117.66a5.65,5.65,0,0,1-5.84,0L18.87,93.31a5.63,5.63,0,0,1-2.87-5V39.58a5.71,5.71,0,0,1,2.87-5L61,10.2a5.6,5.6,0,0,1,5.82,0l42.21,24.35a5.69,5.69,0,0,1,2.93,5Z" /><circle class="cls-1" cx="40" cy="62.53" r="4.84"/><path class="cls-1" d="M108.06,36.32,65.85,12a3.87,3.87,0,0,0-1.91-.54A4.06,4.06,0,0,0,62,12L19.87,36.32A3.88,3.88,0,0,0,18,39.65V88.35a3.87,3.87,0,0,0,1.87,3.32L62,116a3.62,3.62,0,0,0,1.89.54,3.82,3.82,0,0,0,1.9-.54l42.23-24.35A3.94,3.94,0,0,0,110,88.35V39.65A3.94,3.94,0,0,0,108.06,36.32ZM67,68.19a4.8,4.8,0,0,0,3.65-1.69L72.17,68a7.7,7.7,0,0,1-1.08,1,5.9,5.9,0,0,1-1.22.75,5,5,0,0,1-1.42.47,8.33,8.33,0,0,1-1.83.14,6.72,6.72,0,0,1-4.88-2,6.1,6.1,0,0,1-1.3-2.24A7.34,7.34,0,0,1,60,63.39v-.07a7.12,7.12,0,0,1,.42-2.71,7.63,7.63,0,0,1,1.36-2.24A6.35,6.35,0,0,1,64,56.88a7.53,7.53,0,0,1,2.83-.54,13.09,13.09,0,0,1,1.69.14c.54.14.95.27,1.42.41a6.43,6.43,0,0,1,1.15.68,11.79,11.79,0,0,1,1,.88l-1.56,1.63A4.83,4.83,0,1,0,67,68.19ZM64.17,30.56c-.34.47.07,1.63.95,3a2.83,2.83,0,0,1-.95,4,3.83,3.83,0,0,0-.75-2.31C61.8,32.79,63.29,31.64,64.17,30.56Zm-2.71,2.51c-.27.27,0,1.09.61,2a1.91,1.91,0,0,1-.61,2.71A2.74,2.74,0,0,0,61,36.25C59.9,34.56,60.85,33.81,61.46,33.07ZM56.5,39H69.26a.64.64,0,0,1,.68.63C69.94,42,69.6,50,66.2,53.77a.64.64,0,0,1-.47.23H60a.67.67,0,0,1-.47-.26C56.16,49.88,55.83,42,55.83,39.66A.66.66,0,0,1,56.5,39ZM21,49H55.35s.07,0,.07,1H21ZM55,63.32v.07a7.37,7.37,0,0,1-.47,2.71,6.7,6.7,0,0,1-1.46,2.24,6.4,6.4,0,0,1-2.22,1.49,6.63,6.63,0,0,1-2.84.54,7.86,7.86,0,0,1-2.84-.54,6.47,6.47,0,0,1-2.24-1.49,6.3,6.3,0,0,1-1.41-2.24A7.16,7.16,0,0,1,41,63.39v-.07a7.43,7.43,0,0,1,.53-2.71A6.79,6.79,0,0,1,43,58.37a6.46,6.46,0,0,1,2.23-1.49,6.66,6.66,0,0,1,2.85-.54,7.88,7.88,0,0,1,2.85.54,6.48,6.48,0,0,1,2.24,1.49,6.18,6.18,0,0,1,1.35,2.24A7.14,7.14,0,0,1,55,63.32ZM29.1,67H29l-4-6.46V70H22V57h3l4.14,6.38L33.23,57H36V70H33V60.47ZM107,75H21V74h86ZM86,62V57h2V70H86V64H79v6H77V57h2v5Zm6.73,8,6-13h2.17l6,13h-2.51L103,67H96.6l-1.42,3ZM107,50H70.41c0-1,.07-1,.07-1H107Z" /></g></svg>
|
||||
|
Before Width: | Height: | Size: 2.9 KiB After Width: | Height: | Size: 2.8 KiB |
Reference in New Issue
Block a user