Build to prepare to tag

Update CHttpGet.php for php 8.1 deprecated notice

CCache.php

@@ -51,6 +51,15 @@ class CCache
             return $path;
         }
 
+        if ($create && defined('WINDOWS2WSL')) {
+            // Special case to solve Windows 2 WSL integration
+            $path = $this->path . "/" . $subdir;
+
+            if (mkdir($path)) {
+                return realpath($path);
+            }
+        }
+
         if ($create && is_writable($this->path)) {
             $path = $this->path . "/" . $subdir;
 

CHttpGet.php

@@ -215,7 +215,7 @@ class CHttpGet
     {
         $type = isset($this->response['header']['Content-Type'])
             ? $this->response['header']['Content-Type']
-            : null;
+            : '';
 
         return preg_match('#[a-z]+/[a-z]+#', $type)
             ? $type

CImage.php

@@ -679,9 +679,9 @@ class CImage
      *
      * @return string $extension as a normalized file extension.
      */
-    private function normalizeFileExtension($extension = null)
+    private function normalizeFileExtension($extension = "")
     {
-        $extension = strtolower($extension ? $extension : $this->extension);
+        $extension = strtolower($extension ? $extension : $this->extension ?? "");
 
         if ($extension == 'jpeg') {
                 $extension = 'jpg';
@@ -964,8 +964,11 @@ class CImage
     {
         $file = $file ? $file : $this->pathToImage;
 
-        is_readable($file)
-            or $this->raiseError('Image file does not exist.');
+        // Special case to solve Windows 2 WSL integration
+        if (!defined('WINDOWS2WSL')) {
+            is_readable($file)
+                or $this->raiseError('Image file does not exist.');
+        }
 
         $info = list($this->width, $this->height, $this->fileType) = getimagesize($file);
         if (empty($info)) {
@@ -2440,8 +2443,10 @@ class CImage
             return;
         }
 
-        is_writable($this->saveFolder)
+        if (!defined("WINDOWS2WSL")) {
+            is_writable($this->saveFolder)
             or $this->raiseError('Target directory is not writable.');
+        }
 
         $type = $this->getTargetImageExtension();
         $this->Log("Saving image as " . $type);

README.md

@@ -2,8 +2,10 @@ Image conversion on the fly using PHP
 =====================================
 
 [![Join the chat at https://gitter.im/mosbth/cimage](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/mosbth/cimage?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
+<!--
 [![Build Status](https://travis-ci.org/mosbth/cimage.svg?branch=master)](https://travis-ci.org/mosbth/cimage)
 [![Build Status](https://scrutinizer-ci.com/g/mosbth/cimage/badges/build.png?b=master)](https://scrutinizer-ci.com/g/mosbth/cimage/build-status/master)
+-->
 
 About
 -------------------------------------

REVISION.md

@@ -1,8 +1,25 @@
 Revision history
 =====================================
 
+<!--
 [![Build Status](https://travis-ci.org/mosbth/cimage.svg?branch=master)](https://travis-ci.org/mosbth/cimage)
 [![Build Status](https://scrutinizer-ci.com/g/mosbth/cimage/badges/build.png?b=master)](https://scrutinizer-ci.com/g/mosbth/cimage/build-status/master)
+--->
+
+v0.8.5 (2022-11-17)
+-------------------------------------
+
+* "Enable configuration fix for solving Windows 2 WSL2 issue with is_readable/is_writable #189."
+* Update CHttpGet.php for php 8.1 deprecated notice #188.
+* Remove build status from README (since it is not up to date).
+
+
+
+v0.8.4 (2022-05-30)
+-------------------------------------
+
+* Support PHP 8.1 and remove (more) deprecated messages when run in in development mode.
+
 
 
 v0.8.3 (2022-05-24)

defines.php

@@ -1,6 +1,6 @@
 <?php
 // Version of cimage and img.php
-define("CIMAGE_VERSION", "v0.8.3 (2022-05-24)");
+define("CIMAGE_VERSION", "v0.8.5 (2022-11-17)");
 
 // For CRemoteImage
 define("CIMAGE_USER_AGENT", "CImage/" . CIMAGE_VERSION);

webroot/img.php

@@ -319,7 +319,7 @@ if (isset($shortcut)
 /**
  * src - the source image file.
  */
-$srcImage = urldecode(get('src'))
+$srcImage = urldecode(get('src', ""))
     or errorPage('Must set src-attribute.', 404);
 
 // Get settings for src-alt as backup image

webroot/img_config.php

@@ -21,6 +21,15 @@ if (!defined("CIMAGE_DEBUG")) {
     define("CIMAGE_DEBUG_FILE", "/tmp/cimage");
 }
 
+/**
+ * Set this if you work with a webserver in Windows and try to access files
+ * within WSL2.
+ * The issue seems to be with functions like `is_writable()` and
+ * `is_readable()`.
+ * When WINDOWS2WSL is defined (to any value) it ignores these functions.
+ */
+#define('WINDOWS2WSL', 1);
+
 
 
 return array(

webroot/imgd.php

@@ -38,7 +38,7 @@ $config = array(
 
 
 // Version of cimage and img.php
-define("CIMAGE_VERSION", "v0.8.3 (2022-05-24)");
+define("CIMAGE_VERSION", "v0.8.5 (2022-11-17)");
 
 // For CRemoteImage
 define("CIMAGE_USER_AGENT", "CImage/" . CIMAGE_VERSION);
@@ -465,7 +465,7 @@ class CHttpGet
     {
         $type = isset($this->response['header']['Content-Type'])
             ? $this->response['header']['Content-Type']
-            : null;
+            : '';
 
         return preg_match('#[a-z]+/[a-z]+#', $type)
             ? $type
@@ -1816,9 +1816,9 @@ class CImage
      *
      * @return string $extension as a normalized file extension.
      */
-    private function normalizeFileExtension($extension = null)
+    private function normalizeFileExtension($extension = "")
     {
-        $extension = strtolower($extension ? $extension : $this->extension);
+        $extension = strtolower($extension ? $extension : $this->extension ?? "");
 
         if ($extension == 'jpeg') {
                 $extension = 'jpg';
@@ -2101,8 +2101,11 @@ class CImage
     {
         $file = $file ? $file : $this->pathToImage;
 
-        is_readable($file)
-            or $this->raiseError('Image file does not exist.');
+        // Special case to solve Windows 2 WSL integration
+        if (!defined('WINDOWS2WSL')) {
+            is_readable($file)
+                or $this->raiseError('Image file does not exist.');
+        }
 
         $info = list($this->width, $this->height, $this->fileType) = getimagesize($file);
         if (empty($info)) {
@@ -3577,8 +3580,10 @@ class CImage
             return;
         }
 
-        is_writable($this->saveFolder)
+        if (!defined("WINDOWS2WSL")) {
+            is_writable($this->saveFolder)
             or $this->raiseError('Target directory is not writable.');
+        }
 
         $type = $this->getTargetImageExtension();
         $this->Log("Saving image as " . $type);
@@ -4140,6 +4145,15 @@ class CCache
             return $path;
         }
 
+        if ($create && defined('WINDOWS2WSL')) {
+            // Special case to solve Windows 2 WSL integration
+            $path = $this->path . "/" . $subdir;
+
+            if (mkdir($path)) {
+                return realpath($path);
+            }
+        }
+
         if ($create && is_writable($this->path)) {
             $path = $this->path . "/" . $subdir;
 
@@ -4757,7 +4771,7 @@ if (isset($shortcut)
 /**
  * src - the source image file.
  */
-$srcImage = urldecode(get('src'))
+$srcImage = urldecode(get('src', ""))
     or errorPage('Must set src-attribute.', 404);
 
 // Get settings for src-alt as backup image

webroot/imgp.php

@@ -38,7 +38,7 @@ $config = array(
 
 
 // Version of cimage and img.php
-define("CIMAGE_VERSION", "v0.8.3 (2022-05-24)");
+define("CIMAGE_VERSION", "v0.8.5 (2022-11-17)");
 
 // For CRemoteImage
 define("CIMAGE_USER_AGENT", "CImage/" . CIMAGE_VERSION);
@@ -465,7 +465,7 @@ class CHttpGet
     {
         $type = isset($this->response['header']['Content-Type'])
             ? $this->response['header']['Content-Type']
-            : null;
+            : '';
 
         return preg_match('#[a-z]+/[a-z]+#', $type)
             ? $type
@@ -1816,9 +1816,9 @@ class CImage
      *
      * @return string $extension as a normalized file extension.
      */
-    private function normalizeFileExtension($extension = null)
+    private function normalizeFileExtension($extension = "")
     {
-        $extension = strtolower($extension ? $extension : $this->extension);
+        $extension = strtolower($extension ? $extension : $this->extension ?? "");
 
         if ($extension == 'jpeg') {
                 $extension = 'jpg';
@@ -2101,8 +2101,11 @@ class CImage
     {
         $file = $file ? $file : $this->pathToImage;
 
-        is_readable($file)
-            or $this->raiseError('Image file does not exist.');
+        // Special case to solve Windows 2 WSL integration
+        if (!defined('WINDOWS2WSL')) {
+            is_readable($file)
+                or $this->raiseError('Image file does not exist.');
+        }
 
         $info = list($this->width, $this->height, $this->fileType) = getimagesize($file);
         if (empty($info)) {
@@ -3577,8 +3580,10 @@ class CImage
             return;
         }
 
-        is_writable($this->saveFolder)
+        if (!defined("WINDOWS2WSL")) {
+            is_writable($this->saveFolder)
             or $this->raiseError('Target directory is not writable.');
+        }
 
         $type = $this->getTargetImageExtension();
         $this->Log("Saving image as " . $type);
@@ -4140,6 +4145,15 @@ class CCache
             return $path;
         }
 
+        if ($create && defined('WINDOWS2WSL')) {
+            // Special case to solve Windows 2 WSL integration
+            $path = $this->path . "/" . $subdir;
+
+            if (mkdir($path)) {
+                return realpath($path);
+            }
+        }
+
         if ($create && is_writable($this->path)) {
             $path = $this->path . "/" . $subdir;
 
@@ -4757,7 +4771,7 @@ if (isset($shortcut)
 /**
  * src - the source image file.
  */
-$srcImage = urldecode(get('src'))
+$srcImage = urldecode(get('src', ""))
     or errorPage('Must set src-attribute.', 404);
 
 // Get settings for src-alt as backup image

webroot/tests.php

@@ -0,0 +1,22 @@
+<?php
+
+$links = [
+    "img.php?src=car.png&v",
+    "img.php?src=car.png&w=700&v",
+];
+
+?><!doctype html>
+<html>
+    <head>
+        <title>Links to use for testing</title>
+    </head>
+    <body>
+        <h1>Links useful for testing</h1>
+        <p>A collection of linkt to use to test various aspects of the cimage process.</p>
+        <ul>
+        <?php foreach ($links as $link) : ?>
+            <li><a href="<?= $link ?>"><?= $link ?></a></li>
+        <?php endforeach; ?>
+        </ul>
+    </body>
+</html>