mirror/php-e107
1
0
Fork 0
mirror of https://github.com/e107inc/e107.git synced 2025-01-17 12:48:24 +01:00
Code Issues Releases Wiki Activity

Issue #3301 Revert "Removed problematic cache from e107plugin::getinfo()"

Browse Source 
This reverts commit 89e28e38c5f2a3f9762fa826299f8e6945adee03 because it breaks thumb.php
This commit is contained in:
Cameron 2018-07-21 12:23:44 -07:00
parent 8c2bf18679
commit 55be7e35a2
3 changed files with 31 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
e107_admin/plugin.php
View File

@ -631,7 +631,7 @@ class plugin_ui extends e_admin_ui
$eplug_addons = $plugin -> getAddons($eplug_folder);
$info = e107plugin::getPluginRecord($this->id);
$info = $plugin->getinfo($this->id);
$name = deftrue($info['plugin_name'],$info['plugin_name']). " v".$eplug_version. "({e_PLUGIN}".$info['plugin_path'].")";

47
e107_handlers/plugin_class.php
View File

@ -1631,21 +1631,32 @@ class e107plugin
* @param int $id
* @return array plugin info
*/
static function getPluginRecord($id)
function getinfo($id, $force = false)
{
$sql = e107::getDb();
$getinfo_results = array();
$path = (!is_numeric($id)) ? $id : false;
$id = (int)$id;
$qry = "plugin_id = " . $id;
$qry .= ($path != false) ? " OR plugin_path = '" . $path . "' " : "";
if ($sql->select('plugin', '*', $qry)) {
$getinfo_results[$id] = $sql->fetch();
static $getinfo_results;
if (!is_array($getinfo_results))
{
$getinfo_results = array();
}
$path = (!is_numeric($id)) ? $id : false;
$id = (int) $id;
$qry = "plugin_id = ".$id;
$qry .= ($path != false) ? " OR plugin_path = '".$path."' " : "";
if (!isset($getinfo_results[$id]) || $force == true)
{
if ($sql->select('plugin', '*', $qry))
{
$getinfo_results[$id] = $sql->fetch();
}
else
{
return false;
}
}
return $getinfo_results[$id];
}
@ -1934,7 +1945,7 @@ class e107plugin
function manage_userclass($action, $class_name, $class_description='')
{
$this->log("Running ".__FUNCTION__);
$e107 = e107::getInstance();
global $e107;
$tp = e107::getParser();
$sql = e107::getDb();
$mes = e107::getMessage();
@ -2490,12 +2501,12 @@ class e107plugin
elseif(is_numeric($id)) // plugin database id
{
$id = (int) $id;
$plug = e107plugin::getPluginRecord($id); // Get plugin info from DB
$plug = $this->getinfo($id); // Get plugin info from DB
}
else // Plugin Path.
{
$id = $this->getId($id);
$plug = e107plugin::getPluginRecord($id); // Get plugin info from DB
$plug = $this->getinfo($id); // Get plugin info from DB
}
$this->current_plug = $plug;
@ -3874,7 +3885,7 @@ class e107plugin
}
else
{
$plug = e107plugin::getPluginRecord($id);
$plug = $this->getinfo($id);
}
$_path = e_PLUGIN.$plug['plugin_path'].'/';
@ -4007,7 +4018,7 @@ class e107plugin
$sql = e107::getDb();
$tp = e107::getParser();
$plug = e107plugin::getPluginRecord($dir);
$plug = $this->getinfo($dir);
$this->options = array('nolinks'=>true);
@ -4060,7 +4071,7 @@ class e107plugin
$text = '';
// install plugin ...
$plug = e107plugin::getPluginRecord($id);
$plug = $this->getinfo($id);
if(!is_array($plug))
{
@ -4108,7 +4119,7 @@ class e107plugin
$tp = e107::getParser();
$sql = e107::getDb();
$plug = e107plugin::getPluginRecord($id);
$plug = $this->getinfo($id);
$this->log("Uninstalling :".$plug['plugin_path']." with options: ".print_r($options, true));

2
e107_handlers/pref_class.php
View File

@ -845,7 +845,7 @@ final class e_core_pref extends e_pref
parent::__construct($pref_id, $pref_alias);
if($load && $pref_id)
{
$this->load($pref_id, $load);
$this->load();
}