mirror/php-e107
1
0
Fork 0
mirror of https://github.com/e107inc/e107.git synced 2025-03-13 17:09:46 +01:00
Code Issues Releases Wiki Activity

fixes #3657: In case a user with user_class e_UC_NEWUSER logged in and

Browse Source 
was ready to be "promoted" to a "normal" user, the e_UC_NEWUSER should
be removed. Unfortunately, the db:update() function was used in the
wrong way.
The third argument of update() function is for debugging
purposes and NOT used for the WHERE clause.
Therefore the query was run without WHERE, which resulted into applying
the new classes to all users....
This commit is contained in:
Achim Ennenbach 2019-03-02 09:47:19 +01:00
parent a2d5b9c31e
commit e356c3aa1d
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
e107_handlers/login.php
View File

@ -278,7 +278,13 @@ class userlogin
{ // 'New user' probationary period expired - we can take them out of the class
$this->userData['user_class'] = $this->e107->user_class->ucRemove(e_UC_NEWUSER, $this->userData['user_class']);
// $this->e107->admin_log->e_log_event(4,__FILE__."|".__FUNCTION__."@".__LINE__,"DBG","Login new user complete",$this->userData['user_class'],FALSE,FALSE);
$sql->update('user',"`user_class` = '".$this->userData['user_class']."'", 'WHERE `user_id`='.$this->userData['user_id']. " LIMIT 1");
/**
* issue e107inc/e107#3657: Third argument of update() function is for debugging purposes and NOT used for the WHERE clause.
* Therefore the query was run without WHERE, which resulted into applyiing the new classes to all users....
*/
//$sql->update('user',"`user_class` = '".$this->userData['user_class']."'", 'WHERE `user_id`='.$this->userData['user_id']. " LIMIT 1");
$sql->update('user',"`user_class` = '" . $this->userData['user_class'] . "' WHERE `user_id`=" . $this->userData['user_id'] . " LIMIT 1");
unset($class_list[e_UC_NEWUSER]);
$edata_li = array('user_id' => $user_id, 'user_name' => $username, 'class_list' => implode(',',$class_list), 'user_email'=> $user_email);
$e_event->trigger('userNotNew', $edata_li);