mirror/php-e107
1
0
Fork 0
mirror of https://github.com/e107inc/e107.git synced 2025-01-17 12:48:24 +01:00
Code Issues Releases Wiki Activity

Non-standard arg_separator.output value fix.

Browse Source
This commit is contained in:
Cameron 2018-05-04 17:57:43 -07:00
parent 745f9a7c61
commit ed36008286
8 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
e107_admin/cpage.php
View File

@ -141,7 +141,7 @@ class page_admin_form_ui extends e_admin_form_ui
parse_str(str_replace('&', '&', e_QUERY), $query); //FIXME - FIX THIS
$query['action'] = 'edit';
$query['id'] = $id;
$query = http_build_query($query);
$query = http_build_query($query,null, '&');
$text = "<a href='".e_SELF."?{$query}' class='btn btn-default' title='".LAN_EDIT."' data-toggle='tooltip' data-placement='left'>
".ADMIN_EDIT_ICON."</a>";

2
e107_admin/users.php
View File

@ -2938,7 +2938,7 @@ class users_admin_form_ui extends e_admin_form_ui
parse_str(str_replace('&amp;', '&', e_QUERY), $query); //FIXME - FIX THIS
$query['action'] = 'edit';
$query['id'] = $id;
$query = http_build_query($query);
$query = http_build_query($query, null, '&amp;');
$text = "<a href='".e_SELF."?{$query}' class='btn btn-default' title='".LAN_EDIT."' data-toggle='tooltip' data-placement='left'>
".ADMIN_EDIT_ICON."</a>";

2
e107_core/shortcodes/batch/admin_shortcodes.php
View File

@ -2276,7 +2276,7 @@ Inverse 10 <span class="badge badge-inverse">10</span>
$get = $_GET;
$get['elan'] = $code;
$qry = http_build_query($get);
$qry = http_build_query($get, null, '&amp;');
$link = e_REQUEST_SELF.'?'.$qry;
}

4
e107_handlers/admin_ui.php
View File

@ -6680,7 +6680,7 @@ class e_admin_form_ui extends e_form
$vars = $this->getController()->getQuery();
$vars['from'] = '[FROM]';
$paginate = http_build_query($vars);
$paginate = http_build_query($vars, null, '&amp;');
return $this->pagination(e_REQUEST_SELF.'?'.$paginate,$totalRecords,$fromPage,$perPage,array('template'=>'basic'));
@ -6744,7 +6744,7 @@ class e_admin_form_ui extends e_form
$gridAction = $this->getController()->getAction() === 'grid' ? 'list' : 'grid';
$gridQuery = (array) $_GET;
$gridQuery['action'] = $gridAction;
$toggleUrl = e_REQUEST_SELF."?".http_build_query($gridQuery);
$toggleUrl = e_REQUEST_SELF."?".http_build_query($gridQuery, null, '&amp;');
$gridIcon = ($gridAction === 'grid') ? ADMIN_GRID_ICON : ADMIN_LIST_ICON;
$gridTitle = ($gridAction === 'grid') ? LAN_UI_VIEW_GRID_LABEL : LAN_UI_VIEW_LIST_LABEL;
$gridToggle = "<a class='btn btn-default' href='".$toggleUrl."' title=\"".$gridTitle."\">".$gridIcon."</a>";

2
e107_handlers/e107_class.php
View File

@ -3788,7 +3788,7 @@ class e107
// setup some php options
self::ini_set('magic_quotes_runtime', 0);
self::ini_set('magic_quotes_sybase', 0);
self::ini_set('arg_separator.output', '&amp;');
// self::ini_set('arg_separator.output', '&amp;'); // non-standard and bad for third-party script compatibility. @see https://github.com/e107inc/e107/issues/3116
self::ini_set('session.use_only_cookies', 1);
self::ini_set('session.use_trans_sid', 0);
self::ini_set('session.cookie_httponly', 1); // cookie won't be accessible by scripting languages, such as JavaScript. Can effectively help to reduce identity theft through XSS attacks

2
e107_handlers/e_parse_class.php
View File

@ -4660,7 +4660,7 @@ class e_parser
$ytpref['cc_lang_pref'] = e_LAN; // switch captions with chosen user language.
}
$ytqry = http_build_query($ytpref);
$ytqry = http_build_query($ytpref, null, '&amp;');
$defClass = (deftrue('BOOTSTRAP')) ? "embed-responsive embed-responsive-16by9" : "video-responsive"; // levacy backup.

2
e107_handlers/form_handler.php
View File

@ -4221,7 +4221,7 @@ class e_form
$eModalCap = "";
}
$query = http_build_query($query);
$query = http_build_query($query, null, '&amp;');
$value .= "<a href='".e_SELF."?{$query}' class='btn btn-default btn-secondary".$eModal."' ".$eModalCap." title='".LAN_EDIT."' data-toggle='tooltip' data-placement='left'>
".$editIconDefault."</a>";
}

2
e107_plugins/download/download_shortcodes.php
View File

@ -291,7 +291,7 @@ class download_shortcodes extends e_shortcode
}
return "<a href='".e_REQUEST_SELF."?".http_build_query($qry)."'>".$text."</a>" ;
return "<a href='".e_REQUEST_SELF."?".http_build_query($qry, null, '&amp;')."'>".$text."</a>" ;
}