mirror/php-e107
1
0
Fork 0
mirror of https://github.com/e107inc/e107.git synced 2025-03-14 01:19:44 +01:00
Code Issues Releases Wiki Activity

Fixes #5093 - True/False labels on <select> options.

Browse Source
This commit is contained in:
camer0n 2023-11-01 08:07:30 -07:00
parent fb98771b82
commit faa2f8ad34
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
e107_handlers/form_handler.php
View File

@ -3597,10 +3597,11 @@ var_dump($select_options);*/
$options = $this->format_options('option', '', $options);
$options['selected'] = $selected; //comes as separate argument just for convenience
$ltitle = strtolower($option_title);
$label = ($ltitle === 'true' || $ltitle === 'false') ? $option_title : defset($option_title, $option_title);
return "<option" . $this->attributes(['value' => $value]) . $this->get_attributes($options) . '>'
. defset($option_title, $option_title) .
. $label .
'</option>';
}

8
e107_tests/tests/unit/e_formTest.php
View File

@ -779,6 +779,14 @@ class e_formTest extends \Codeception\Test\Unit
$this->assertEquals($expected, $actual);
$tests = ['true'=>'True', 'false'=>'False', 'legacy'=>'Legacy'];
foreach($tests as $k=>$v)
{
$expected = "<option value='$k'>$v</option>";
$result = $this->_frm->option($v,$k);
$this->assertSame($expected, $result);
}
}
public function testOption_multi()