mirror of
https://github.com/e107inc/e107.git
synced 2025-08-06 06:38:00 +02:00
Updated e107 Coding Standard (markdown)
@@ -228,10 +228,10 @@ Don't enclose integer values in quotes in WHERE clauses - slows up the query. (B
|
||||
$id = 1;
|
||||
|
||||
//BAD - Slower and risk of failure.
|
||||
$sql->db_Select_gen("SELECT * FROM `#user` WHERE user_id = '".$id."' LIMIT 1");
|
||||
$sql->gen("SELECT * FROM `#user` WHERE user_id = '".$id."' LIMIT 1"); // previously db_Select_gen
|
||||
|
||||
//GOOD - Faster, 0 if no value
|
||||
$sql->db_Select_gen("SELECT * FROM `#user` WHERE user_id = ".intval($id)." LIMIT 1");
|
||||
$sql->gen("SELECT * FROM `#user` WHERE user_id = ".intval($id)." LIMIT 1"); // previously db_Select_gen
|
||||
|
||||
|
||||
Where only one record is expected, use "LIMIT 1" in the query for better performance.
|
||||
|
Reference in New Issue
Block a user