mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-08-08 09:26:34 +02:00
Code Issues Releases Wiki Activity

fix: compat: still return controls view item, even if empty (#4057)

Browse Source
This commit is contained in:
IanM
2024-10-03 09:01:17 +01:00
committed by GitHub
parent 1c71ee0968
commit 1665d47adc
1 changed files with 13 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
framework/core/js/src/forum/components/DiscussionListItem.tsx
View File

@@ -74,7 +74,7 @@ export default class DiscussionListItem<CustomAttrs extends IDiscussionListItemA
const discussion = this.attrs.discussion; const discussion = this.attrs.discussion;
const controls = DiscussionControls.controls(discussion, this).toArray(); const controls = DiscussionControls.controls(discussion, this).toArray();
!!controls.length && items.add('controls', this.controlsView(controls), 100); items.add('controls', this.controlsView(controls), 100);
items.add('slidableUnderneath', this.slidableUnderneathView(), 90); items.add('slidableUnderneath', this.slidableUnderneathView(), 90);
items.add('content', this.contentView(), 80); items.add('content', this.contentView(), 80);
@@ -83,14 +83,18 @@ export default class DiscussionListItem<CustomAttrs extends IDiscussionListItemA
controlsView(controls: Mithril.ChildArray): Mithril.Children { controlsView(controls: Mithril.ChildArray): Mithril.Children {
return ( return (
<Dropdown <>
icon="fas fa-ellipsis-v" {!!controls.length && (
className="DiscussionListItem-controls" <Dropdown
buttonClassName="Button Button--icon Button--flat Slidable-underneath Slidable-underneath--right" icon="fas fa-ellipsis-v"
accessibleToggleLabel={app.translator.trans('core.forum.discussion_controls.toggle_dropdown_accessible_label')} className="DiscussionListItem-controls"
> buttonClassName="Button Button--icon Button--flat Slidable-underneath Slidable-underneath--right"
{controls} accessibleToggleLabel={app.translator.trans('core.forum.discussion_controls.toggle_dropdown_accessible_label')}
</Dropdown> >
{controls}
</Dropdown>
)}
</>
); );
} }