mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-07-22 01:01:28 +02:00
Code Issues Releases Wiki Activity

Don't include post content in the "basic" serializer

Browse Source 
Currently all of a post's replies are loaded in full whenever the post
is loaded, which is kind of overkill - we really just need to know that
they exist (and who posted them) in order to render the "X replied to
this" line.
This commit is contained in:
Toby Zerner
2017-09-19 19:10:07 +09:30
parent 5fc3ea94b5
commit 705ef7536b
2 changed files with 3 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
framework/core/src/Api/Serializer/DiscussionBasicSerializer.php
View File

@@ -54,7 +54,7 @@ class DiscussionBasicSerializer extends AbstractSerializer
*/ */
protected function startPost($discussion) protected function startPost($discussion)
{ {
return $this->hasOne($discussion, 'Flarum\Api\Serializer\PostBasicSerializer'); return $this->hasOne($discussion, 'Flarum\Api\Serializer\PostSerializer');
} }
/** /**
@@ -70,7 +70,7 @@ class DiscussionBasicSerializer extends AbstractSerializer
*/ */
protected function lastPost($discussion) protected function lastPost($discussion)
{ {
return $this->hasOne($discussion, 'Flarum\Api\Serializer\PostBasicSerializer'); return $this->hasOne($discussion, 'Flarum\Api\Serializer\PostSerializer');
} }
/** /**
@@ -86,6 +86,6 @@ class DiscussionBasicSerializer extends AbstractSerializer
*/ */
protected function relevantPosts($discussion) protected function relevantPosts($discussion)
{ {
return $this->hasMany($discussion, 'Flarum\Api\Serializer\PostBasicSerializer'); return $this->hasMany($discussion, 'Flarum\Api\Serializer\PostSerializer');
} }
} }

6
framework/core/src/Api/Serializer/PostBasicSerializer.php
View File

@@ -43,12 +43,6 @@ class PostBasicSerializer extends AbstractSerializer
'contentType' => $post->type 'contentType' => $post->type
]; ];
if ($post instanceof CommentPost) {
$attributes['contentHtml'] = $post->content_html;
} else {
$attributes['content'] = $post->content;
}
return $attributes; return $attributes;
} }