mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-08-04 07:27:39 +02:00
Code Issues Releases Wiki Activity

Fix Button component not working because of attrs.children being frozen

Browse Source
This commit is contained in:
David Sevilla Martin
2020-01-25 08:45:31 -05:00
parent 056e6c0fea
commit 87792f5911
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
js/src/common/components/Button.tsx
View File

@@ -32,10 +32,7 @@ export interface ButtonProps extends ComponentProps {
*/
export default class Button<T extends ButtonProps = ButtonProps> extends Component<T> {
view(vnode) {
const attrs: ButtonProps = vnode.attrs;
const children = attrs.children;
delete attrs.children;
const { children, ...attrs} = vnode.attrs;
attrs.className = attrs.className || '';
attrs.type = attrs.type || 'button';
@@ -50,7 +47,7 @@ export default class Button<T extends ButtonProps = ButtonProps> extends Compone
const loading = extract(attrs, 'loading');
if (attrs.disabled || loading) {
attrs.className += ' disabled' + (loading ? ' loading' : '');
attrs.className += ' ' + classNames('disabled', loading && 'loading');
delete attrs.onclick;
}