mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-08-06 08:27:42 +02:00
Code Issues Releases Wiki Activity

fix: $relationsArray can end up containing closures (#146)

Browse Source 
* fix: `$relationsArray` can end up containing closures

Not sure I didn't simply unset the first time around..

* Use a new array instead of modifying one
This commit is contained in:
Sami Mazouz
2021-09-29 21:58:32 +01:00
committed by GitHub
parent ea5ee5a9a3
commit de6d291a09
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
extensions/tags/src/TagRepository.php
View File

@@ -33,15 +33,16 @@ class TagRepository
*/
public function with($relations, User $actor): Builder
{
$relationsArray = is_string($relations) ? explode(',', $relations) : $relations;
foreach (self::TAG_RELATIONS as $relation) {
if (in_array($relation, $relationsArray, true)) {
$relationsArray = array_diff($relationsArray, [$relation]);
$relations = is_string($relations) ? explode(',', $relations) : $relations;
$relationsArray = [];
foreach ($relations as $relation) {
if (in_array($relation, self::TAG_RELATIONS, true)) {
$relationsArray[$relation] = function ($query) use ($actor) {
$query->whereVisibleTo($actor);
};
} else {
$relationsArray[] = $relation;
}
}