mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-01-17 22:29:15 +01:00
Code Issues Releases Wiki Activity

Don't use body as tooltip container, allow notification area overflow (#2166)

Browse Source 
* Don't use body as tooltip container, allow notification area overflow

Badge tooltips are using container: 'body', so they can overflow the
notification area. When the user navigates back while a badge tooltip is
showing, the tooltip remains visible.
This commit removes the body container attribute and instead allows the
notificationDropDown to overflow, so badge tooltips aren't cut off.
Instead, this adds overflow: hidden to NotificationList.
Fixes #2118.

* Remove newline
This commit is contained in:
julakali 2020-05-16 02:10:40 +02:00 committed by GitHub
parent 9b936d4baa
commit f89f114fad
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
js/src/common/components/Badge.js
View File

@ -30,6 +30,6 @@ export default class Badge extends Component {
config(isInitialized) {
if (isInitialized) return;
if (this.props.label) this.$().tooltip({ container: 'body' });
if (this.props.label) this.$().tooltip();
}
}

1
less/forum/NotificationList.less
View File

@ -1,5 +1,6 @@
.NotificationList {
overflow: hidden;
& .loading-indicator {
height: 100px;
}

1
less/forum/NotificationsDropdown.less
View File

@ -1,7 +1,6 @@
.NotificationsDropdown {
.Dropdown-menu {
padding: 0;
overflow: hidden;
.NotificationList-content {
max-height: 70vh;